biweekly Critical issues plea

2011-01-19 Thread Graham Percival
Did you know that English is an absolutely stupid language? The word "biweekly" can mean either "4 times each 14 days", or "1 time each 14 days"! Anyway, here's my less-than-twice-a-week plea to new contributors: We are, yet again, about 10-20 hours of work away from having 0 critical issues. T

Re: biweekly Critical issues plea

2011-01-19 Thread m...@apollinemike.com
I'll take care of 1472, but I need a copy of Valentin's opera. Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: biweekly Critical issues plea

2011-01-19 Thread Benkő Pál
> Work on Critical issues has pretty much wound down.  Carl asked > about the status of 1474 recently; I'd like to take that a step > further and ask for a dedicated volunteer to act as "shepherd" for > each issue. > - you *don't* need to program, or even understand programming >  (but that would b

Re: biweekly Critical issues plea

2011-01-19 Thread David Kastrup
Graham Percival writes: > Did you know that English is an absolutely stupid language? The > word "biweekly" can mean either "4 times each 14 days", or "1 time > each 14 days"! What's wrong with "fortnightly"? -- David Kastrup ___ lilypond-devel ma

Re: biweekly Critical issues plea

2011-01-19 Thread Bernard Hurley
I'll take on 1474 Bernard ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: biweekly Critical issues plea

2011-01-19 Thread Graham Percival
On Wed, Jan 19, 2011 at 06:57:27AM -0500, m...@apollinemike.com wrote: > I'll take care of 1472, but I need a copy of Valentin's opera. Valentin's opera is available as a git checkout: http://repo.or.cz/w/opera_libre.git but did you mean 1475 instead? Benk has claimed it. I tried briefly lookin

Re: biweekly Critical issues plea

2011-01-19 Thread Benkő Pál
>> I'll take care of 1472, but I need a copy of Valentin's opera. > > Valentin's opera is available as a git checkout: > http://repo.or.cz/w/opera_libre.git > but did you mean 1475 instead?  Benk has claimed it. > > > I tried briefly looking at the opera a few days ago, but it didn't > compile in 2

Re: biweekly Critical issues plea

2011-01-19 Thread Graham Percival
On 1/19/11, Benkő Pál wrote: >> I tried briefly looking at the opera a few days ago, but it didn't >> compile in 2.12.3 or 2.13.46, so I gave up after a few minutes. >> Finding a minimal example that works in both 2.12.3 and 2.13.46 >> might be tricky, > > tonight I'll prepare a smaller example, t

Re: biweekly Critical issues plea

2011-01-19 Thread Benkő Pál
2011/1/19 Graham Percival : > On 1/19/11, Benkő Pál wrote: >>> I tried briefly looking at the opera a few days ago, but it didn't >>> compile in 2.12.3 or 2.13.46, so I gave up after a few minutes. >>> Finding a minimal example that works in both 2.12.3 and 2.13.46 >>> might be tricky, >> >> tonig

Re: biweekly Critical issues plea

2011-01-19 Thread Francisco Vila
2011/1/19 Graham Percival : >it's no problem for me to recompile lilypond > 30 or 40 times. Finding a commit out of 40 by git-bisect shouldn't need to recompile more than log2(40)=5.32 , this gives 6 times in the worst case. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.co

Re: biweekly Critical issues plea

2011-01-19 Thread Graham Percival
On Wed, Jan 19, 2011 at 04:32:21PM +0100, Francisco Vila wrote: > 2011/1/19 Graham Percival : > >it's no problem for me to recompile lilypond > > 30 or 40 times. > > Finding a commit out of 40 by git-bisect shouldn't need to recompile > more than log2(40)=5.32 , this gives 6 times in the worst ca

Re: biweekly Critical issues plea

2011-01-19 Thread m...@apollinemike.com
My bad! I'll take on 1472...gulp... Cheers, Mike On Jan 19, 2011, at 7:29 AM, Graham Percival wrote: > On Wed, Jan 19, 2011 at 06:57:27AM -0500, m...@apollinemike.com wrote: >> I'll take care of 1472, but I need a copy of Valentin's opera. > > Valentin's opera is available as a git checkout: >

Re: biweekly Critical issues plea

2011-01-19 Thread Francisco Vila
2011/1/19 Graham Percival : > On Wed, Jan 19, 2011 at 04:32:21PM +0100, Francisco Vila wrote: >> 2011/1/19 Graham Percival : >> >it's no problem for me to recompile lilypond >> > 30 or 40 times. >> >> Finding a commit out of 40 by git-bisect shouldn't need to recompile >> more than log2(40)=5.32  ,

Re: biweekly Critical issues plea

2011-01-19 Thread m...@apollinemike.com
result of git bisect for issue 1472 ee0488f3aa19e0060b6e17c46a4d88cb9d57c489 is the first bad commit commit ee0488f3aa19e0060b6e17c46a4d88cb9d57c489 Author: Joe Neeman Date: Fri Jun 18 16:53:17 2010 +0300 Fix 1120. Don't add vertical padding to the skylines that are used for h

Re: biweekly Critical issues plea

2011-01-19 Thread Graham Percival
On Wed, Jan 19, 2011 at 04:31:47PM -0500, m...@apollinemike.com wrote: > result of git bisect for issue 1472 > > ee0488f3aa19e0060b6e17c46a4d88cb9d57c489 is the first bad commit > Fix 1120. > > What next? Umm. Next you read the emails on lilypond-devel which have been discussing this fo

Re: biweekly Critical issues plea

2011-01-19 Thread m...@apollinemike.com
Graham et all, I have read all of the postings and am up to date - I meant "what next" as a general question to the community in the sense of "would anyone who was actually involved in the pushing of this commit (Joe - I see your name associated with it - how much work did you do on it?) like t

Re: biweekly Critical issues plea

2011-01-19 Thread Carl Sorensen
On 1/19/11 2:51 PM, "m...@apollinemike.com" wrote: > Graham et all, > > I have read all of the postings and am up to date - I meant "what next" as a > general question to the community in the sense of "would anyone who was > actually involved in the pushing of this commit (Joe - I see your name

Re: biweekly Critical issues plea

2011-01-19 Thread Carl Sorensen
On 1/19/11 2:51 PM, "m...@apollinemike.com" wrote: > Graham et all, > > I have read all of the postings and am up to date - I meant "what next" as a > general question to the community in the sense of "would anyone who was > actually involved in the pushing of this commit (Joe - I see your name

Re: biweekly Critical issues plea

2011-01-19 Thread Mike Solomon
Got it. Then, here is the state of things: 1/6 Bug is first reported on the bug list. 1/7 Neil reports adding a default 'extra-spacing-height to key signature. 1/10 Keith confirms that this works and that he gets a clean make check. 1/13 Phil holmes reports the regression on the bugtracker (2.

Re: biweekly Critical issues plea

2011-01-19 Thread Carl Sorensen
On 1/19/11 4:33 PM, "Mike Solomon" wrote: > Got it. > > Then, here is the state of things: > > 1/6 > Bug is first reported on the bug list. > > 1/7 > Neil reports adding a default 'extra-spacing-height to key signature. > > 1/10 > Keith confirms that this works and that he gets a clean make

Re: biweekly Critical issues plea

2011-01-19 Thread Mike Solomon
Also works, also passes make check, also attached, also on Rietveld: http://codereview.appspot.com/4006044 From Neil's e-mail, it seems that he advocates this solution because "Clefs are taken into account (shown by the yellow-blue skyline pair) when calculating horizontal skylines for NonMusica

Re: biweekly Critical issues plea

2011-01-19 Thread Carl Sorensen
On 1/19/11 6:06 PM, "Mike Solomon" wrote: > Also works, also passes make check, also attached, also on Rietveld: > http://codereview.appspot.com/4006044 > From Neil's e-mail, it seems that he advocates this solution because "Clefs > are taken into account (shown by the yellow-blue skyline pair

Re: biweekly Critical issues plea

2011-01-19 Thread Carl Sorensen
On 1/19/11 6:06 PM, "Mike Solomon" wrote: > Also works, also passes make check, also attached, also on Rietveld: > http://codereview.appspot.com/4006044 > From Neil's e-mail, it seems that he advocates this solution because "Clefs > are taken into account (shown by the yellow-blue skyline pair) w

Re: biweekly Critical issues plea

2011-01-20 Thread Keith OHara
%{ Fellow Contributors, The patches look like they do the job, and give clean regression tests, but the developers are hesitant. I am not a programmer, and I cannot read minds, but I can tell you what makes *me* hesitant. Look at issue 1120. A lyric syllable covering more than one note spread th

Re: biweekly Critical issues plea

2011-01-20 Thread Keith OHara
On Thu, 20 Jan 2011 01:33:10 -0800, Keith OHara wrote: ... because that fixes 1120 more solidly and removes the cause for issues 1474 and 1472, Well, reverting ee0488 removes the cause of our /noticing/ issue 1472 (multi-measure rests colliding with key signatures). The way that KeySigs res

Re: biweekly Critical issues plea

2011-01-20 Thread m...@apollinemike.com
Pushed to Rietveld:http://codereview.appspot.com/4056043 Note that there is a trailing whitespace error on line 47 of the diff. Cheers, MS On Jan 20, 2011, at 5:13 AM, Keith OHara wrote: > On Thu, 20 Jan 2011 01:33:10 -0800, Keith OHara wrote: > >> ... because that fixes 1120 more >> solidly