On 6 June 2010 09:51, Benkő Pál benko@gmail.com wrote:
attached the updated patch for 1082.
Thanks, applied.
Regards,
Neil
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
attached the updated patch for 1082.
thanks,
p
patch16
Description: Binary data
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
hi Neil,
updated the patch fixing the issue and attached
an example where the previous version failed.
LGTM.
A few minor nitpicks:
+ /*
+ note that note_dur may be strictly less than left_to_do_
+ (say, if left_to_do_ == 5/8)
+ */
This comment would be better
On 5/20/10 1:45 AM, Benkő Pál benko@gmail.com wrote:
Please change this to something which explains that the polyphony in
this test works properly.
what about Versions up to 2.13.21 got complex completion heads wrong
in polyphonic environment?
A better phrase would be:
Complex
On 14 May 2010 06:26, Benkő Pál benko@gmail.com wrote:
updated the patch fixing the issue and attached
an example where the previous version failed.
LGTM.
A few minor nitpicks:
+ /*
+ note that note_dur may be strictly less than left_to_do_
+ (say, if left_to_do_ == 5/8)
hi all,
attached a patch fixing the issue.
the cause of the problem was note_dur being
less than left_to_do_, as noted in the comment I added.
the fix itself is the following part:
- if (nb.main_part_ nb note_dur.get_length ())
+ if (nb.main_part_ nb left_to_do_)
the remaining bit
hi all,
updated the patch fixing the issue and attached
an example where the previous version failed.
the cause of the problem was note_dur being
less than left_to_do_, as noted in the comment I added.
the fix itself is the following part:
- if (nb.main_part_ nb note_dur.get_length ())
