On 2020/04/11 15:59:32, hahnjo wrote:
> Rename my_round() to round_halfway_up()
As promised, the updated patch keeps the functionality. However I've
renamed the function and added clear documentation that it should not be
used in new code.
https://codereview.appspot.com/553740043/
On 2020/03/18 00:17:12, Dan Eble wrote:
> Jonas,
>
> I'm low on energy, so I'm not going to review this now, but I there
are a few
> points I want to mention.
>
> 1. thanks for cleaning things up!
> 2. maybe the rounding change should wait for 2.21.1
I'll rework the patch to keep the rounding
Jonas,
I'm low on energy, so I'm not going to review this now, but I there are
a few points I want to mention.
1. thanks for cleaning things up!
2. maybe the rounding change should wait for 2.21.1
3. please don't look at real.hh/cc; I've got a patch for it that I'm
waiting to post
On 2020/03/17 21:27:52, hanwenn wrote:
>
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly
> File input/regression/tie-single-manual.ly (right):
>
>
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly#newcode19
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly
File input/regression/tie-single-manual.ly (right):
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly#newcode19
input/regression/tie-single-manual.ly:19:
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly
File input/regression/tie-single-manual.ly (right):
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly#newcode19
input/regression/tie-single-manual.ly:19:
Reviewers: ,
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly
File input/regression/tie-single-manual.ly (right):
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly#newcode19
