Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-29 Thread graham
LGTM http://codereview.appspot.com/5846075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-23 Thread Julien Rioux
On Fri, Mar 23, 2012 at 4:33 AM, wrote: > I'm seeing "old chunk mismatch" for this patch.  Could you try uploading > it again to a new rietveld issue? > > http://codereview.appspot.com/5846075/ Fixed, it was a bad upload (no need for a new issue number).

Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-22 Thread graham
I'm seeing "old chunk mismatch" for this patch. Could you try uploading it again to a new rietveld issue? http://codereview.appspot.com/5846075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-22 Thread Julien Rioux
On Wed, Mar 21, 2012 at 9:37 AM, Julien Rioux wrote: > On Wed, Mar 21, 2012 at 1:39 AM,   wrote: >> >> http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py >> File scripts/lilypond-book.py (right): >> >> http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py#newcode

Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-21 Thread Julien Rioux
On Wed, Mar 21, 2012 at 1:39 AM, wrote: > > http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py > File scripts/lilypond-book.py (right): > > http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py#newcode639 > scripts/lilypond-book.py:639: global_options.include_pa

Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-20 Thread joeneeman
http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py File scripts/lilypond-book.py (right): http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py#newcode639 scripts/lilypond-book.py:639: global_options.include_path.insert (0, inverse_relpath (original_dir, global

lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-20 Thread graham
LGTM http://codereview.appspot.com/5846075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel