On 2011/09/17 19:29:40, janek wrote:
It is ready to go except for the above.
Greetings,
I realize that this patch has been sort of forgotten, so I thought I’d
update it and re-upload it:
https://codereview.appspot.com/227070043/
https://codereview.appspot.com/4636081/
Needs a regression test exercising the different settings.
http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):
http://codereview.appspot.com/4636081/diff/38001/lily/stem-tremolo.cc#newcode118
lily/stem-tremolo.cc:118: shape = ly_symbol2scm
cannot apply to master due to fixcc.
http://codereview.appspot.com/4636081/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Oh no! I hoped to get it on this countdown.
A version compatible with fixcc uploaded.
http://codereview.appspot.com/4636081/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
make passes and no reg tests differences
http://codereview.appspot.com/4636081/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Am Freitag 29 Juli 2011, 07:38:26 schrieben Sie:
New patch set uploaded. Minor style change: slash shape that was named
default (which was confusing) is now named parallelogram (because
that's how it looks like).
If you don't like parallelograms ;) we can name it beam-like or sth.
Yes,
Reinhold:
ok, replaced parallelogram with beam-like
http://codereview.appspot.com/4636081/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
New patch set uploaded. Minor style change: slash shape that was named
default (which was confusing) is now named parallelogram (because
that's how it looks like).
If you don't like parallelograms ;) we can name it beam-like or sth.
http://codereview.appspot.com/4636081/
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode93
lily/stem-tremolo.cc:93: style = ly_symbol2scm (constant);
On 2011/07/23 19:58:19, Janek Warchol wrote:
On
makes fine. No reg test differences now.
http://codereview.appspot.com/4636081/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Joe: redundant lines removed.
Interesting thing happens when i compare regtests: i see a difference in
part-combine-tuplet-end.ly, which is completely unrelated to tremolos.
Even funnier, my branch compiled this test better than master...
Perhaps i should've built from scratch.
BTW, should i
New patch set uploaded. Current Lily default behaviour is kept as
default now.
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode42
lily/stem-tremolo.cc:42:
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):
http://codereview.appspot.com/4636081/diff/10001/lily/stem-tremolo.cc#newcode42
lily/stem-tremolo.cc:42: style = ly_symbol2scm (constant);
You can remove these two lines and use
style ==
Make works now and I get some reg test output differences
See
http://code.google.com/p/lilypond/issues/detail?id=1735#c4
James
http://codereview.appspot.com/4636081/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
2011/7/19 pkx1...@gmail.com:
Make works now and I get some reg test output differences
http://code.google.com/p/lilypond/issues/detail?id=1735#c4
They look exacly like they are expected to look.
thanks,
Janek
___
lilypond-devel mailing list
Hello, can someone else verify?
I get a make fail:
--snip--
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm]
Writing internals.texi...ERROR: In procedure procedure-name:
ERROR: Wrong type argument in position 1: #f
make[1]: *** [out/internals.texi] Error 1
rm
2011/7/18 pkx1...@gmail.com:
Hello, can someone else verify?
I get a make fail:
I get it too... Strange, it compiled some time ago.
Btw,
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm]
Writing internals.texi...ERROR: In procedure procedure-name:
ERROR:
2011/7/18 Janek Warchoł lemniskata.bernoull...@gmail.com:
Btw,
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm]
Writing internals.texi...ERROR: In procedure procedure-name:
ERROR: Wrong type argument in position 1: #f
make[1]: *** [out/internals.texi]
2011/7/18 Neil Puttock n.putt...@gmail.com:
2011/7/18 Janek Warchoł lemniskata.bernoull...@gmail.com:
Btw,
[/home/jlowe/lilypond-git/build/out/share/lilypond/current/scm/document-markup.scm]
Writing internals.texi...ERROR: In procedure procedure-name:
ERROR: Wrong type argument in position
Actually, non-rectangular, constant-sloped beams used to be the default,
but I changed them (some years ago now) to be rectangular and parallel
to the beam, since that's what most of my scores have. My music
collection isn't with me right now, but I can confirm at least that
BH's urtext edition
Reviewers: xratamacue_hotmail.com, reinhold_kainhofer.com,
Message:
Passes regtests.
Description:
modifying default behaviour of tremolo slashes
It turned out that tremolo slashes should have
quite constant slope (definately not depending
on beam slope), so i change that. I also changed
slash
Looks mostly good to me.
Thanks,
Carl
http://codereview.appspot.com/4636081/diff/1/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):
http://codereview.appspot.com/4636081/diff/1/lily/stem-tremolo.cc#newcode42
lily/stem-tremolo.cc:42: that it's not proper notation.
We shouldn't keep
Hi Janek,
I'm afraid I don't like this at all. While the authorities may be in
agreement that the slashes should be sloped, all the scores I've looked
at follow the same style as LilyPond (which I think reflects a more
traditional hand-engraved style).
It would be preferable to allow users to
23 matches
Mail list logo
