2012/1/16 pls p.l.schm...@gmx.de:
BTW: http://codereview.appspot.com/5303063/ is still open and hasn't been
pushed.
Oops! Looks like this patch slipped through the cracks because it
wasn't mentioned in tracker issue 1985. I'm adding it now, it should
be checked soon.
thanks,
Janek
Hi Janek,
done!
Thanks
patrick
BTW: http://codereview.appspot.com/5303063/ is still open and hasn't been
pushed.
Am 16.01.2012 um 00:07 schrieb Janek Warchoł:
Hi Patrick,
your patch was pushed when i was absent; now i see that Rietveld issue
is still opened. Could you close it please?
Hi Patrick,
your patch was pushed when i was absent; now i see that Rietveld issue
is still opened. Could you close it please?
http://codereview.appspot.com/5096050/
Janek
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2011/09/25 18:30:51, janek wrote:
2011/9/25 ptrcklsch...@googlemail.com:
Hi Janek,
I was talking about uploading some changes of this patch to
rietveld. I
forgot to add some bits and pieces I had announced in the
description of
this patch to the reworked version. I would have had to
LGTM.
Thanks!
http://codereview.appspot.com/5096050/diff/20001/python/musicexp.py
File python/musicexp.py (right):
http://codereview.appspot.com/5096050/diff/20001/python/musicexp.py#newcode1510
python/musicexp.py:1510: # Print out the style if we have ome, but the
'() should only be
The typo
This also passes a completely fresh make ; make doc.
http://codereview.appspot.com/5096050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Patrick,
2011/9/24 ptrcklsch...@googlemail.com:
I just discovered that I forgot to add the changes related to
conversion-info and \center-column. Do I have to make a completely new
patch containing all 3 files (musicxml2ly.py, musicxml.py and
musicexp.py) or is it ok to upload only the
On 2011/09/25 10:31:14, janek wrote:
Hi Patrick,
2011/9/24 ptrcklsch...@googlemail.com:
I just discovered that I forgot to add the changes related to
conversion-info and \center-column. Do I have to make a completely
new
patch containing all 3 files (musicxml2ly.py, musicxml.py and
2011/9/25 ptrcklsch...@googlemail.com:
Hi Janek,
I was talking about uploading some changes of this patch to rietveld. I
forgot to add some bits and pieces I had announced in the description of
this patch to the reworked version. I would have had to adjust only 2 of
the 3 files in the
On 2011/09/23 15:36:15, p-l-s wrote:
Hi Reinhold and Janek,
I hope I got it right this time. I didn't include the bit about
miscellaneous.
This will be part of a seperate patch.
BTW: I noticed that the midi-block is not always inserted in every .ly
file
(this is not related to my
passes make and reg tests
http://codereview.appspot.com/5096050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/09/22 13:26:54, Reinhold wrote:
Welcome to the wonderful world of LilyPond development!
:)
Most changes look fine, but there are some things that can't be
submitted yet.
See my comments.
Most important: Please edit the source file in scripts/musicxml2ly.py
and don't
modify the
Hm, I didn't understand all of this. What do I have to change in
musicxml2ly? My
idea was to use the description misc field for a custom header
variable named
'miscellaneous' by default. I was thinking about implementing a cmd
line option
('-t' and '--texinfo') to be able to use the
Hi Reinhold and Janek,
I hope I got it right this time. I didn't include the bit about
miscellaneous. This will be part of a seperate patch.
BTW: I noticed that the midi-block is not always inserted in every .ly
file (this is not related to my patch). I will do some testing...
Thanks for your
Some concerns and a handful of questions (as usual in my case).
http://codereview.appspot.com/5096050/diff/1/python/musicexp.py
File python/musicexp.py (right):
http://codereview.appspot.com/5096050/diff/1/python/musicexp.py#newcode63
python/musicexp.py:63: self.print_verbatim ('\\version
Welcome to the wonderful world of LilyPond development!
Most changes look fine, but there are some things that can't be
submitted yet. See my comments.
Most important: Please edit the source file in scripts/musicxml2ly.py
and don't modify the installed musicxml2ly file and copy it over to the
16 matches
Mail list logo
