Re: note-name-engraver: add user-defined note names support (issue 8593046)

2015-04-12 Thread v . villenave
On 2013/04/26 22:38:57, janek wrote: New patchset should be "announced" in the tracker issue, yes. Hi everybody, I realize this patch has been (sort of) forgotten, so I thought I’d update it and re-upload it: https://codereview.appspot.com/221710044/ Cheers, Valentin. https://codereview.appsp

Re: note-name-engraver: add user-defined note names support (issue 8593046)

2013-04-26 Thread janek . lilypond
On 2013/04/24 17:16:14, fanziye1 wrote: I found the variable 'pitchnames'(Thanks for your teaching:). There is a note-name->lily-string procedure can be used to get a pitch's name. Now I want to use it in C++ code. According to the Guile Reference, 'gh_call' seems a right choice. But I found

Re: note-name-engraver: add user-defined note names support (issue 8593046)

2013-04-25 Thread pkx166h
On 2013/04/24 17:16:14, fanziye1 wrote: but now that I've uploaded a patch here, how could I modify it (or add new changes)? should I upload new patch to the same googlecode issue? If you use git-cl it does it all for you. It will set the googlecode issue to 'Patch-new' automatically (which mea

Re: note-name-engraver: add user-defined note names support (issue 8593046)

2013-04-24 Thread fanziye1
I found the variable 'pitchnames'(Thanks for your teaching:). There is a note-name->lily-string procedure can be used to get a pitch's name. Now I want to use it in C++ code. According to the Guile Reference, 'gh_call' seems a right choice. But I found no appearance of 'gh_call' in lily/*.cc . So

Re: note-name-engraver: add user-defined note names support (issue 8593046)

2013-04-21 Thread janek . lilypond
Hi, On 2013/04/20 00:03:17, fanziye1 wrote: Hi Janek, It seems I forgot to publish this issue in list. This is for the googlecode issue 1367. Only a few c++ code was added, nothing done with regression test and docs. Was it appropriate to post a patch like this? Or is there anything I should do

note-name-engraver: add user-defined note names support (issue 8593046)

2013-04-19 Thread fanziye1
Reviewers: janek, Message: Hi Janek, It seems I forgot to publish this issue in list. This is for the googlecode issue 1367. Only a few c++ code was added, nothing done with regression test and docs. Was it appropriate to post a patch like this? Or is there anything I should do for an issue? I th