On Wed, 20 Nov 2013 00:53:24 -0800, wrote:
If min_sys_count would happen
to be negative, this loop will never get run at all
Exactly that was happening with the example from issue 1553, before the patch.
The code above seemed to be trying to ensured that min_sys_count >= 0 but
thinking in
https://codereview.appspot.com/22750045/diff/1/lily/optimal-page-breaking.cc
File lily/optimal-page-breaking.cc (right):
https://codereview.appspot.com/22750045/diff/1/lily/optimal-page-breaking.cc#newcode120
lily/optimal-page-breaking.cc:120: for (vsize sys_count =
ideal_sys_count + 1; --sys_co
LGTM.
I think that this would warrant a comment (it's quite surprising that
min_sys_count could ever be negative), but i don't insist.
thanks,
Janek
https://codereview.appspot.com/22750045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https
LGTM.
https://codereview.appspot.com/22750045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
