Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-09 Thread hanwenn
commit 146b73cdd061c264b294f58c6bf7f86667505da5 Author: Han-Wen Nienhuys Date: Fri Apr 3 23:32:38 2020 +0200 https://codereview.appspot.com/563810043/

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread Han-Wen Nienhuys
On Sat, Apr 4, 2020 at 1:43 PM wrote: > > I will run this through "make check" and push to staging now. > Done. -- Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread nine . fierce . ballads
On 2020/04/04 07:53:24, hahnjo wrote: > 1: As a side note, this means there's a very funny workaround: Just push *any* > commit to master with a pure ASCII description and you'll not see the failure > anymore :D In the distance, a brass band plays "The Star-Spangled Banner."

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread hanwenn
I will run this through "make check" and push to staging now. https://codereview.appspot.com/563810043/diff/545810044/scripts/build/output-distance.py File scripts/build/output-distance.py (right):

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread David Kastrup
Valentin Villenave writes: > On 4/4/20, jonas.hahnf...@gmail.com wrote: >> The reason is that the latest commit in master has a non-ASCII >> character in the first line of its commit message [1]. > > So IIUC it *was* f5f907599ce88d3d610483fa42fa78be12f53d2e in the end… > but just because of a

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread rietveldpkx--- via Discussions on LilyPond development
On 2020/04/04 09:07:08, hahnjo wrote: > On 2020/04/04 09:04:50, pkx166h-lilypond wrote: > > Actually I am using Python 2.7. I don't as far as I can tell have any python > 3.x > > on my system. > > > > James > > That's impossible ;-) it's required in master and you tested the patch switching > to

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread jonas . hahnfeld
On 2020/04/04 09:02:01, valentin_villenave.net wrote: > On 4/4/20, mailto:jonas.hahnf...@gmail.com wrote: > > The reason is that the latest commit in master has a non-ASCII > > character in the first line of its commit message [1]. > > So IIUC it *was*

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread jonas . hahnfeld
On 2020/04/04 09:04:50, pkx166h-lilypond wrote: > Actually I am using Python 2.7. I don't as far as I can tell have any python 3.x > on my system. > > James That's impossible ;-) it's required in master and you tested the patch switching to Python 3, so I'm fairly certain you have it. The

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread rietveldpkx--- via Discussions on LilyPond development
On 2020/04/04 07:16:40, hahnjo wrote: > On 2020/04/03 22:15:06, hanwenn wrote: > > On 2020/04/03 22:00:02, dak wrote: > > > Is this likely related to the problems in `make check` that James currently > > > experiences? > > > > Yes. > > > > Unfortunately, the default encoding depends on the

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread Valentin Villenave
On 4/4/20, jonas.hahnf...@gmail.com wrote: > The reason is that the latest commit in master has a non-ASCII > character in the first line of its commit message [1]. So IIUC it *was* f5f907599ce88d3d610483fa42fa78be12f53d2e in the end… but just because of a char in the commit message!? Man, how

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread jonas . hahnfeld
To add another data point: I'm able to reproduce the failure with a self-compiled Python 3.5.9 that I have laying around for testing. The reason is that the latest commit in master has a non-ASCII character in the first line of its commit message [1]. Applying the change to open_write_file solves

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-04 Thread jonas . hahnfeld
On 2020/04/03 22:15:06, hanwenn wrote: > On 2020/04/03 22:00:02, dak wrote: > > Is this likely related to the problems in `make check` that James currently > > experiences? > > Yes. > > Unfortunately, the default encoding depends on the environment > > " > In text mode, if encoding is not

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-03 Thread dak
https://codereview.appspot.com/563810043/diff/545810044/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/563810043/diff/545810044/scripts/build/output-distance.py#newcode1328 scripts/build/output-distance.py:1328: system (u'echo HEAD

Re: output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-03 Thread hanwenn
Reviewers: dak, Message: On 2020/04/03 22:00:02, dak wrote: > Is this likely related to the problems in `make check` that James currently > experiences? Yes. Unfortunately, the default encoding depends on the environment " In text mode, if encoding is not specified the encoding used is

output-distance: write HTML as UTF-8 (issue 563810043 by hanw...@gmail.com)

2020-04-03 Thread dak
Is this likely related to the problems in `make check` that James currently experiences? https://codereview.appspot.com/563810043/