Re: Add comments to code related to page breaking/layout (issue 563630043 by hanw...@gmail.com)

commit 0b9804f7ed4ac285a432c12b0dea5ab9c67a5eb0 Author: Han-Wen Nienhuys Date: Fri Feb 28 14:01:38 2020 +0100 Add comments to code related to page breaking/layout https://sourceforge.net/p/testlilyissues/issues/5802 http://codereview.appspot.com/563630043 https

Re: Add some const declarations to page breaking code (issue 569490044 by hanw...@gmail.com)

Reviewers: lemzwerg, Message: commit e3c676f1f477818504992ac6c4c938aa56e69b78 Author: Han-Wen Nienhuys Date: Fri Feb 28 14:48:56 2020 +0100 Add some const declarations to page breaking code https://sourceforge.net/p/testlilyissues/issues/5820 http://codereview.appspot.com

Add some const declarations to page breaking code (issue 569490044 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/569490044/

Add comments to code related to page breaking/layout (issue 563630043 by hanw...@gmail.com)

LGTM. Please feel free to ignore (most of) my remarks if you consider such nitpicking as unnecessary :-) https://codereview.appspot.com/563630043/diff/571770043/lily/include/page-breaking.hh File lily/include/page-breaking.hh (right):

Re: Set page breaking properties in the System grob (issue 581470047 by hanw...@gmail.com)

On 2020/01/22 18:51:07, Erlend Aasland wrote: > On 2020/01/22 16:20:21, Dan Eble wrote: > > Veto! I've had more than one bad experience with lowercase ell. > > > > In one case--I think it was elsewhere in LilyPond--it was purely a readability > > issue, but reason enough to avoid it. > > > > In

Re: Set page breaking properties in the System grob (issue 581470047 by hanw...@gmail.com)

On 2020/01/22 16:20:21, Dan Eble wrote: > Veto! I've had more than one bad experience with lowercase ell. > > In one case--I think it was elsewhere in LilyPond--it was purely a readability > issue, but reason enough to avoid it. > > In the other, one person *thought* that he was using it as a

Set page breaking properties in the System grob (issue 581470047 by hanw...@gmail.com)

What's the purpose of this change? Is it preparation for a new feature? https://codereview.appspot.com/581470047/diff/565490043/lily/page-breaking.cc File lily/page-breaking.cc (right): https://codereview.appspot.com/581470047/diff/565490043/lily/page-breaking.cc#newcode624

lily/page-breaking: pass vector by reference (issue 581510043 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/581510043/

Re: [2.20] Issue 4943 Manual page breaking causing assertion failureusing Windows

orle...@gmail.com> Cc: "David Kastrup" <d...@gnu.org>; "lilypond-devel" <lilypond-devel@gnu.org> Sent: Friday, November 03, 2017 11:20 PM Subject: Re: [2.20] Issue 4943 Manual page breaking causing assertion failureusing Windows I appreciate this

Re: [2.20] Issue 4943 Manual page breaking causing assertion failureusing Windows

p" <d...@gnu.org>; "lilypond-devel" < > lilypond-devel@gnu.org> > Sent: Friday, November 03, 2017 11:20 PM > Subject: Re: [2.20] Issue 4943 Manual page breaking causing assertion > failureusing Windows > > > I appreciate this is going back a whole 9 month

Re: [2.20] Issue 4943 Manual page breaking causing assertion failureusing Windows

- Original Message - From: "Chris Yate" <chrisy...@gmail.com> To: "Thomas Morley" <thomasmorle...@gmail.com> Cc: "David Kastrup" <d...@gnu.org>; "lilypond-devel" <lilypond-devel@gnu.org> Sent: Friday, November 03, 2017 11:2

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

I appreciate this is going back a whole 9 months, but I've just started looking again at one of my projects and I'm back, stuck against this completely debilitating bug. I'm now using 2.19.80 and it's not been fixed. Granted, a release build probably wouldn't throw on "assert", but is anyone

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

On Fri, 6 Jan 2017 at 12:41 Chris Yate wrote: > On Fri, 6 Jan 2017 at 12:23 Thomas Morley > wrote: > > 2017-01-06 13:10 GMT+01:00 Chris Yate : > > > > > Curiously, this didn't fail with assertions. I've just upgraded to >

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

aking. -- David Kastrup All very well for avoiding a crash, but of course that doesn't solve the problem, if whatever bug or issue it is that's causing the problem is affecting the page breaking of scores. IIRC that code goes back a long way, and the knowledge of why it's asserting at al

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

On Fri, 6 Jan 2017 at 12:23 Thomas Morley wrote: > 2017-01-06 13:10 GMT+01:00 Chris Yate : > > > > > Curiously, this didn't fail with assertions. I've just upgraded to > 2.19.54, > > and the test cases that crashed for me previously still crash :) >

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

Chris Yate writes: > On Fri, 6 Jan 2017 at 11:34 David Kastrup wrote: > >> >> Assertions should not be used when LilyPond has a sane way to continue: >> for that case, programming errors are more appropriate. The question is >> whether this is the case here:

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

2017-01-06 13:10 GMT+01:00 Chris Yate : > > Curiously, this didn't fail with assertions. I've just upgraded to 2.19.54, > and the test cases that crashed for me previously still crash :) > > Log attached (although I don't think this will be very helpful). Strange that your

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

2017-01-06 13:10 GMT+01:00 Chris Yate : > Curiously, this didn't fail with assertions. I've just upgraded to 2.19.54, > and the test cases that crashed for me previously still crash :) Could you remove all "Test 3x"-scores from the test-file and redo compilation, please.

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

On Fri, 6 Jan 2017 at 10:23 Thomas Morley wrote: > 2017-01-04 16:01 GMT+01:00 Chris Yate : > > On Wed, 4 Jan 2017 at 14:25 Thomas Morley > wrote: > > > Well, it's odd. I'm not sure this is anything to do with >

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

ut even when assertions are disabled: right? On Linux no assertion failure happens and the output _is_ as expected. Lines running out of page or compressed over-full pages are forced by the test-cases. So the bad output is intended in the tests. > But as long as it is not _dangerous_ to continue (li

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

On Fri, 6 Jan 2017 at 11:34 David Kastrup wrote: > > Assertions should not be used when LilyPond has a sane way to continue: > for that case, programming errors are more appropriate. The question is > whether this is the case here: I think we are also dealing with bad > output

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

Thomas Morley writes: > 2017-01-04 16:01 GMT+01:00 Chris Yate : >> On Wed, 4 Jan 2017 at 14:25 Thomas Morley wrote: > >> Well, it's odd. I'm not sure this is anything to do with /overrideProperty. >> >> Referring back to

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

2017-01-04 16:01 GMT+01:00 Chris Yate : > On Wed, 4 Jan 2017 at 14:25 Thomas Morley wrote: > Well, it's odd. I'm not sure this is anything to do with /overrideProperty. > > Referring back to my original tests, I can change your definitions to the >

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

On Wed, 4 Jan 2017 at 14:25 Thomas Morley wrote: > 2017-01-04 14:26 GMT+01:00 Chris Yate : > > > > On Wed, 4 Jan 2017 at 12:39 Thomas Morley > wrote: > >> > >> 2017-01-04 11:11 GMT+01:00 Chris Yate : >

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

Hi everybody! On 64-bit Linux I also saw failures caused by manual page breaking with too few space a few months ago. I had no time to investigate the problem then, but there definitely is a problem not only on windows. I saw assertion failures, but I also managed to immediately kill lilypond

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

2017-01-04 14:26 GMT+01:00 Chris Yate : > > On Wed, 4 Jan 2017 at 12:39 Thomas Morley wrote: >> >> 2017-01-04 11:11 GMT+01:00 Chris Yate : >> >> > I'm not quite sure what you want me to test, but, here's what I've >> > tried. >>

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

On Wed, 4 Jan 2017 at 12:39 Thomas Morley wrote: > 2017-01-04 11:11 GMT+01:00 Chris Yate : > > > I'm not quite sure what you want me to test, but, here's what I've tried. > [...] > > Hi Chris, > > sorry not been clear enough. > Many thanks for your

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

2017-01-04 11:11 GMT+01:00 Chris Yate : > I'm not quite sure what you want me to test, but, here's what I've tried. [...] Hi Chris, sorry not been clear enough. Many thanks for your testings though. I've now created the attached test-file (and the pdf I get [*]) Please

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

On Tue, 3 Jan 2017 at 22:58 Thomas Morley wrote: > 2017-01-03 18:04 GMT+01:00 Chris Yate : > > On Tue, 3 Jan 2017 at 16:23 Thomas Morley > wrote: > > >> > >> Do you have the same problems, while putting it in \layout and

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

2017-01-03 18:04 GMT+01:00 Chris Yate : > On Tue, 3 Jan 2017 at 16:23 Thomas Morley wrote: >> >> Do you have the same problems, while putting it in \layout and using >> manual breaks? Like: >> >> \layout { >> \autoBreaksOff >> } >> >> { \repeat

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

lly don't have > >> > motivation for). > >> > > >> > I've given up trying to make an instrumented build of Lilypond for > >> > Windows/Mingw now, so if anybody else is able to create one for me > >> > that'd > >> > be very welcome. &

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

>> > time to investigate why Gub isn't working (which I really don't have >> > motivation for). >> > >> > I've given up trying to make an instrumented build of Lilypond for >> > Windows/Mingw now, so if anybody else is able to create one for me >>

Re: [2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

Windows/Mingw now, so if anybody else is able to create one for me that'd > > be very welcome. > > > > Chris_ > > Hi Chris, > > I've just reread the Rietveld-discussion about > Issue 4169: Line and page breaking syntactic sugar > https://codereview.appspot.com/156400

[2.20] Issue 4943 Manual page breaking causing assertion failure using Windows

; motivation for). > > I've given up trying to make an instrumented build of Lilypond for > Windows/Mingw now, so if anybody else is able to create one for me that'd > be very welcome. > > Chris_ Hi Chris, I've just reread the Rietveld-discussion about Issue 4169: Line and page break

Back to work on Issue 4752: Add ly:one-page-breaking

Hi all, I have some time to work again on ly:one-page-breaking. Ideally I'd like to land it before 2.20 is released. I've just updated the patches so they apply to current master. James (or anyone), one possible complication was different gcc versions on different machines giving

Re: Add ly:one-page-breaking (issue 288910043 by paulwmor...@gmail.com)

This patch unfortunately broke staging. See thread: http://lists.gnu.org/archive/html/lilypond-devel/2016-02/msg5.html For now this has been set back to 'needs work'. https://codereview.appspot.com/288910043/ ___ lilypond-devel mailing list

Re: Add ly:one-page-breaking (issue 288910043 by paulwmor...@gmail.com)

Now that ly:one-line-auto-height is in master, this patch set updates the docs so it and ly:one-page-breaking are both present and accounted for. -Paul https://codereview.appspot.com/288910043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https

Re: Add ly:one-page-breaking (issue 288910043 by paulwmor...@gmail.com)

Am 27. Januar 2016 05:34:46 MEZ, schrieb paulwmor...@gmail.com: >Now that ly:one-line-auto-height is in master, this patch set updates >the docs so it and ly:one-page-breaking are both present and accounted >for. -Paul LGTM > > >https://codereview.appspot.com/288910043/di

Re: Add ly:one-page-breaking (issue 288910043 by paulwmor...@gmail.com)

Please review, thanks, -Paul https://codereview.appspot.com/288910043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: ly:one-page-breaking (was: ly:one-line-breaking)

> Namely the tagline and any footnotes are not included, > and bookparts trigger default page breaking for some reason. > I haven’t tested it extensively but titles (etc.), top level markups, > multiple scores, > all seem to work just fine. That's great news! For the app

Re: ly:one-page-breaking (was: ly:one-line-breaking)

> On Jan 19, 2016, at 4:02 AM, Richard Shann wrote: > > That's great news! For the application to Denemo taglines and footnotes > are not wanted anyway as it is for creating a score to play from > on-screen. > I guess it will be some time before this code gets into a

ly:one-page-breaking (was: ly:one-line-breaking)

the music, leaving the width as set. I’m glad to report that I’ve made some real progress. The code in the attached patch delivers the basic functionality, with a few "known issues". Namely the tagline and any footnotes are not included, and bookparts trigger default page breakin

ly:one-page-breaking (was: ly:one-line-breaking)

the music, leaving the width as set. I’m glad to report that I’ve made some real progress. The code in the attached patch delivers the basic functionality, with a few "known issues". Namely the tagline and any footnotes are not included, and bookparts trigger default page breakin

Re: ly:one-page-breaking (was: ly:one-line-breaking)

> On Jan 18, 2016, at 7:09 PM, Paul Morris wrote: > > (Also, I now see how to improve the ly:one-line-auto-height code to avoid > some of the unintuitive results related to bottom-margin and > top-system-spacing. So a new patch set for that is on the way, when I can >

ly:one-page-breaking? plus the cheapest line breaking algorithm

Hi all, I just had an idea and would like to get your opinion on it. I just read about the ly:one-line-breaking function and thought it would be a good idea to have a ly:one-page-breaking complement for it too. This would produce a score with regular line length and paper width, but on one

Re: ly:one-page-breaking? plus the cheapest line breaking algorithm

Urs Liska u...@openlilylib.org writes: I just had an idea and would like to get your opinion on it. I just read about the ly:one-line-breaking function and thought it would be a good idea to have a ly:one-page-breaking complement for it too. This would produce a score with regular line

Re: ly:one-page-breaking? plus the cheapest line breaking algorithm

Am 21.11.2014 10:46, schrieb David Kastrup: Urs Liska u...@openlilylib.org writes: I just had an idea and would like to get your opinion on it. I just read about the ly:one-line-breaking function and thought it would be a good idea to have a ly:one-page-breaking complement for it too

Re: ly:one-page-breaking? plus the cheapest line breaking algorithm

On Nov 21, 2014, at 04:53 , Urs Liska u...@openlilylib.org wrote: Am 21.11.2014 10:46, schrieb David Kastrup: Urs Liska u...@openlilylib.org writes: I just read about the ly:one-line-breaking function and thought it would be a good idea to have a ly:one-page-breaking complement

Re: ly:one-page-breaking? plus the cheapest line breaking algorithm

-page-breaking complement for it too. This would produce a score with regular line length and paper width, but on one long page. So it would seem to me like we should likely be able to specify the page breaking strategy (including none) and the line breaking strategy (including none

Re: ly:one-page-breaking? plus the cheapest line breaking algorithm

and thought it would be a good idea to have a ly:one-page-breaking complement for it too. This would produce a score with regular line length and paper width, but on one long page. So it would seem to me like we should likely be able to specify the page breaking strategy (including none) and the line

Re: ly:one-page-breaking? plus the cheapest line breaking algorithm

Urs Liska u...@openlilylib.org writes: Having a displaying program (be it an editor, a LaTeX or an HTML document) stitch together the systems and optionally take care of page breaking seems like a good idea in that context. In any case, such a program that want to implement a pageless

Re: ly:one-page-breaking? plus the cheapest line breaking algorithm

Am 21.11.2014 14:51, schrieb David Kastrup: Urs Liska u...@openlilylib.org writes: Having a displaying program (be it an editor, a LaTeX or an HTML document) stitch together the systems and optionally take care of page breaking seems like a good idea in that context. In any case

Re: ly:one-page-breaking? plus the cheapest line breaking algorithm

Urs Liska u...@openlilylib.org writes: Am 21.11.2014 14:51, schrieb David Kastrup: Urs Liska u...@openlilylib.org writes: Having a displaying program (be it an editor, a LaTeX or an HTML document) stitch together the systems and optionally take care of page breaking seems like a good idea

page-breaking: allow degenerate scores; issue 4161 (issue 169660043 by k-ohara5...@oco.net)

https://codereview.appspot.com/169660043/diff/1/lily/page-breaking.cc File lily/page-breaking.cc (right): https://codereview.appspot.com/169660043/diff/1/lily/page-breaking.cc#newcode834 lily/page-breaking.cc:834: printf(\nQQQ min_system_count %d, ret); Uh, that one looks like a

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

On 2014/10/22 05:48:36, Keith wrote: On Tue, 21 Oct 2014 09:33:56 -0700, mailto:tdanielsmu...@googlemail.com wrote: I've decided to keep the reverts for the On predefs, since \once does not do what [the name implies] with these overrides. Yuck. The problem seems to be that the

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

Thanks Keith On 2014/10/22 05:48:36, you wrote: Yuck. The problem seems to be that the override takes effect at the first beat in a bar, after the paper-column for the previous barline has been generated, and the \once makes the override expire before the next bar. Unfortunately this

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

with \overrideProperty. ... but only for line breaking. It seems that page breaking needs a window of opportunity to break a page that is several bars long. The number of bars required varies with the length of the music between 2 and 5 or so, but I've never seen it less than 2. So there's no chance \once

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

On 2014/10/22 11:20:48, Trevor Daniels wrote: On 2014/10/22 10:33:30, Trevor Daniels wrote: ... but only for line breaking. It seems that page breaking needs a window of opportunity to break a page that is several bars long. The number of bars required varies with the length

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

On 2014/10/22 07:12:16, dak wrote: I never really got \overrideProperty. Would it cooperate with \once? Does it only take effect once? \overrideProperty uses an ApplyOutput event (as opposed to an OverrideProperty event) to change a property in grobs that *already* *exist* at the current

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

On 2014/10/20 04:34:56, Keith wrote: Looks good to me. I'm just suggesting more changes that you might want to do at the same time. https://codereview.appspot.com/156400043/diff/20001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right):

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

On Tue, 21 Oct 2014 09:33:56 -0700, tdanielsmu...@googlemail.com wrote: I've decided to keep the reverts for the On predefs, since \once does not do what [the name implies] with these overrides. Yuck. The problem seems to be that the override takes effect at the first beat in a bar, after

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

2014-10-20 6:33 GMT+02:00 k-ohara5...@oco.net: https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359 using \override's for re-establishing the default settings, What do others think? Yes, \autoLineBreaksOn is an assertive statement, so I would expect it to set the

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

On 2014/10/19 22:30:06, Trevor Daniels wrote: Actually, prompted by Kieren's recent mail, it might be preferable to go back to using \override's for re-establishing the default settings, as that would permit \once to work consistently, in particular permitting \once \autoLineBreaksOn to

Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly File ly/property-init.ly (right): https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359 ly/property-init.ly:359: lineBreaksOn = It might be more consistent with other overrides in this file to make the

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

Hello, I think it may be a good idea to add auto prefix to these commands. They will get longer, but i think the clarification gained is worth it; we also have \autoBeamOn/Off following this convention. best, Janek https://codereview.appspot.com/156400043/

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

be more consistent with other overrides in this file to make the commands for (re-)establishing the default settings, namely \lineBreaksOn and \pageBreaksOn, be reverts rather than overrides. done Description: Issue 4169: Line and page breaking syntactic sugar Install line- and page

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

On 2014/10/19 16:58:45, janek wrote: Hello, I think it may be a good idea to add auto prefix to these commands. They will get longer, but i think the clarification gained is worth it; we also have \autoBeamOn/Off following this convention. Good thinking, especially as these commands

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

thanks, LGTM :) https://codereview.appspot.com/156400043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

On 2014/10/19 18:04:32, Trevor Daniels wrote: On 2014/10/19 16:58:04, dak wrote: https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly File ly/property-init.ly (right): https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359 ly/property-init.ly:359:

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

https://codereview.appspot.com/156400043/diff/1/ly/property-init.ly#newcode359 ly/property-init.ly:359: lineBreaksOn = using \override's for re-establishing the default settings, What do others think? Yes, \autoLineBreaksOn is an assertive statement, so I would expect it to set the state

Re: Issue 4169: Line and page breaking syntactic sugar (issue 156400043 by tdanielsmu...@googlemail.com)

Looks good to me. I'm just suggesting more changes that you might want to do at the same time. https://codereview.appspot.com/156400043/diff/20001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right):

Re: optimal-page-breaking: signed/unsigned bug; issue 1553 (issue 22750045)

https://codereview.appspot.com/22750045/diff/1/lily/optimal-page-breaking.cc File lily/optimal-page-breaking.cc (right): https://codereview.appspot.com/22750045/diff/1/lily/optimal-page-breaking.cc#newcode120 lily/optimal-page-breaking.cc:120: for (vsize sys_count = ideal_sys_count + 1;

Re: optimal-page-breaking: signed/unsigned bug; issue 1553 (issue 22750045)

On Wed, 20 Nov 2013 00:53:24 -0800, d...@gnu.org wrote: If min_sys_count would happen to be negative, this loop will never get run at all Exactly that was happening with the example from issue 1553, before the patch. The code above seemed to be trying to ensured that min_sys_count = 0 but

Re: page-breaking: allow ragged pages to be compressed; issue 3281 (issue 25710043)

LGTM apart from a suggested doc change. https://codereview.appspot.com/25710043/diff/180001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/25710043/diff/180001/Documentation/notation/spacing.itely#newcode401

Re: page-breaking: allow ragged pages to be compressed; issue 3281 (issue 25710043)

On 2013/11/19 07:57:36, lemzwerg wrote: LGTM. Just to be sure: Does the warning message regarding forced compressed pages (if ragged-bottom is active) get emitted even for single-system pages? A single system on a ragged-bottom page gets a warning from lilypond, but not lilypond-book. If I

Re: page-breaking: allow ragged pages to be compressed; issue 3281 (issue 25710043)

On 2013/11/19 09:16:34, Keith wrote: On 2013/11/19 07:57:36, lemzwerg wrote: LGTM. Just to be sure: Does the warning message regarding forced compressed pages (if ragged-bottom is active) get emitted even for single-system pages? A single system on a ragged-bottom page gets a warning

Re: page-breaking: allow ragged pages to be compressed; issue 3281 (issue 25710043)

On 2013/11/19 08:59:17, Trevor Daniels wrote: LGTM apart from a suggested doc change. Got it. Thanks https://codereview.appspot.com/25710043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: page-breaking: allow ragged pages to be compressed; issue 3281 (issue 25710043)

On 2013/11/19 09:31:24, dak wrote: Can you see any effect from ragged-bottom in those runs of lilypond-book where the warning disappears? No. Changing the warning behavior was a side-topic, so I'm putting it back and finishing the main issue alone. https://codereview.appspot.com/25710043/

Re: page-breaking: allow ragged pages to be compressed; issue 3281 (issue 25710043)

LGTM. Just to be sure: Does the warning message regarding forced compressed pages (if ragged-bottom is active) get emitted even for single-system pages? https://codereview.appspot.com/25710043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: optimal-page-breaking: signed/unsigned bug; issue 1553 (issue 22750045)

LGTM. I think that this would warrant a comment (it's quite surprising that min_sys_count could ever be negative), but i don't insist. thanks, Janek https://codereview.appspot.com/22750045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: page-breaking: allow ragged pages to be compressed; issue 3281 (issue 25710043)

-back to the natural force on the page, not 0.0. Description: page-breaking: allow ragged pages to be compressed; issue 3281 Please review this at https://codereview.appspot.com/25710043/ Affected files (+39, -18 lines): M Documentation/notation/spacing.itely M lily/include/page-breaking.hh M

page-breaking: allow ragged pages to be compressed; issue 3281 (issue 25710043)

LGTM, thanks, with one comment. https://codereview.appspot.com/25710043/diff/40001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/25710043/diff/40001/Documentation/notation/spacing.itely#newcode411

optimal-page-breaking: signed/unsigned bug; issue 1553 (issue 22750045)

LGTM. https://codereview.appspot.com/22750045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

page-breaking: do not try to fill ragged-pages; issue 3441 (issue 24100045)

LGTM, without testing. https://codereview.appspot.com/24100045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Help with page breaking code

Hi all. I wrote this message a lot of time ago, but for some unknown reasons I didn't send it to the list. Maybe this is still interesting. I tested with 2.16.2 and 2.17.95. 2013/5/22 David Kastrup d...@gnu.org: #(define-markup-command (ugly layout props) () (ly:make-stencil (ly:stencil-expr

Re: Help with page breaking code

Thomas Morley thomasmorle...@gmail.com writes: FWIW, I can confirm with: 2.17.17 2.16.2 2.14.2 Though, 2.12.3 returns correct output. Thanks, that's good to know. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Help with page breaking code

Keith OHara k-ohara5...@oco.net writes: David Kastrup dak at gnu.org writes: #(define-markup-command (ugly layout props) () (ly:make-stencil (ly:stencil-expr (interpret-markup layout props x)) '(0 . 0) '(0 . -100))) \markup \ugly \markup * The page-breaker seems to be allowing for

Re: Help with page breaking code

Keith OHara k-ohara5...@oco.net writes: David Kastrup dak at gnu.org writes: #(define-markup-command (ugly layout props) () (ly:make-stencil (ly:stencil-expr (interpret-markup layout props x)) '(0 . 0) '(0 . -100))) \markup \ugly \markup * The page-breaker seems to be allowing for

Re: Help with page breaking code

David Kastrup d...@gnu.org writes: Keith OHara k-ohara5...@oco.net writes: David Kastrup dak at gnu.org writes: #(define-markup-command (ugly layout props) () (ly:make-stencil (ly:stencil-expr (interpret-markup layout props x)) '(0 . 0) '(0 . -100))) \markup \ugly \markup * The

Fix accounting problem in page breaking (issue 9705043)

LGTM https://codereview.appspot.com/9705043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Help with page breaking code

Keith OHara k-ohara5...@oco.net writes: David Kastrup dak at gnu.org writes: #(set! empty-stencil (ly:make-stencil '() empty-interval empty-interval)) \markup \fill-line { } Basically, the first \markup produces an empty stencil with extents (+inf.0 . -inf.0) and the page breaking code

Re: Help with page breaking code

. -inf.0) and the page breaking code goes bonkers on that. \paper {annotate-spacing = ##t} indicates proper estimates for any scores after the \fill-line, and indirectly shows zero space allowed for the \fill-line, so the height estimations seem reasonable. The problem appears only when \fill

Re: Help with page breaking code

David Kastrup d...@gnu.org writes: And another one: #(define-markup-command (ugly layout props) () (ly:make-stencil (ly:stencil-expr (interpret-markup layout props x)) '(0 . 0) '(0 . -100))) \markup \ugly \markup * \markup * \markup * \markup * This puts everything right after another on

Re: Help with page breaking code

2013/5/22 David Kastrup d...@gnu.org: David Kastrup d...@gnu.org writes: And another one: #(define-markup-command (ugly layout props) () (ly:make-stencil (ly:stencil-expr (interpret-markup layout props x)) '(0 . 0) '(0 . -100))) \markup \ugly \markup * \markup * \markup * \markup

Re: Help with page breaking code

David Kastrup dak at gnu.org writes: #(define-markup-command (ugly layout props) () (ly:make-stencil (ly:stencil-expr (interpret-markup layout props x)) '(0 . 0) '(0 . -100))) \markup \ugly \markup * The page-breaker seems to be allowing for a markup that has something 100

Help with page breaking code

an empty stencil with extents (+inf.0 . -inf.0) and the page breaking code goes bonkers on that. Since the current spacing code in issue 3330 requires this representation for empty stencil extents, I can't really commit in this state. As a corollary: if extent (+inf.0 . -inf.0) throws the page breaking

Re: Help with page breaking code

{ } Basically, the first \markup produces an empty stencil with extents (+inf.0 . -inf.0) and the page breaking code goes bonkers on that. Since the current spacing code in issue 3330 requires this representation for empty stencil extents, I can't really commit in this state. As a corollary

Re: Help with page breaking code

David Kastrup dak at gnu.org writes: #(set! empty-stencil (ly:make-stencil '() empty-interval empty-interval)) \markup \fill-line { } Basically, the first \markup produces an empty stencil with extents (+inf.0 . -inf.0) and the page breaking code goes bonkers on that. \paper {annotate

Re: Help with page breaking code

Keith OHara k-ohara5...@oco.net writes: David Kastrup dak at gnu.org writes: #(set! empty-stencil (ly:make-stencil '() empty-interval empty-interval)) \markup \fill-line { } Basically, the first \markup produces an empty stencil with extents (+inf.0 . -inf.0) and the page breaking code

metronome/tempo marks: accurate initial placment, for page breaking (issue 9073043)

https://codereview.appspot.com/9073043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/9073043/diff/1/scm/output-lib.scm#newcode861 scm/output-lib.scm:861: (ly:grob-property grob 'outside-staff-padding 0.0)) It would be interesting to know why 1.0 was

  1   2   >