Re: metronome/tempo marks: accurate initial placment, for page breaking (issue 9073043)

2013-05-01 Thread k-ohara5a5a
onome/tempo marks: accurate initial placment, for page breaking Please review this at https://codereview.appspot.com/9073043/ Affected files: M scm/output-lib.scm Index: scm/output-lib.scm diff --git a/scm/output-lib.scm b/scm/output-lib.scm index caa7032c70b9a5879f3a4adb05f899d1b31

metronome/tempo marks: accurate initial placment, for page breaking (issue 9073043)

2013-05-01 Thread lemzwerg
https://codereview.appspot.com/9073043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/9073043/diff/1/scm/output-lib.scm#newcode861 scm/output-lib.scm:861: (ly:grob-property grob 'outside-staff-padding 0.0)) It would be interesting to know why 1.0 was ad

Re: Error tracking through the log files [was: Re: Compilation errorwith page-breaking-page-count3.ly]

2012-09-29 Thread Marc Hohl
Am 28.09.2012 12:24, schrieb Phil Holmes: - Original Message - From: "Marc Hohl" To: Sent: Friday, September 28, 2012 11:00 AM Subject: Re: Error tracking through the log files [was: Re: Compilation errorwith page-breaking-page-count3.ly] [...] A brute force method

Re: Error tracking through the log files [was: Re: Compilation errorwith page-breaking-page-count3.ly]

2012-09-28 Thread Phil Holmes
- Original Message - From: "Marc Hohl" To: Sent: Friday, September 28, 2012 11:00 AM Subject: Re: Error tracking through the log files [was: Re: Compilation errorwith page-breaking-page-count3.ly] Am 28.09.2012 11:38, schrieb David Kastrup: Marc Hohl writes: Well, i

Re: Error tracking through the log files [was: Re: Compilation error with page-breaking-page-count3.ly]

2012-09-28 Thread Marc Hohl
Am 28.09.2012 11:38, schrieb David Kastrup: Marc Hohl writes: Well, it seems to be not as simple as that. I did a 'make test' on my patch. This fails, obviously. The console says: Dissecting... Writing snippets... Processing... Processing /home/marc/git/lilypond/out/lybook-testdb/snippet-nam

Re: Error tracking through the log files [was: Re: Compilation errorwith page-breaking-page-count3.ly]

2012-09-28 Thread Marc Hohl
Am 28.09.2012 11:45, schrieb Phil Holmes: - Original Message - From: "Marc Hohl" To: Sent: Friday, September 28, 2012 10:30 AM Subject: Error tracking through the log files [was: Re: Compilation errorwith page-breaking-page-count3.ly] I did a 'make test' on

Re: Error tracking through the log files [was: Re: Compilation errorwith page-breaking-page-count3.ly]

2012-09-28 Thread Phil Holmes
- Original Message - From: "Marc Hohl" To: Sent: Friday, September 28, 2012 10:30 AM Subject: Error tracking through the log files [was: Re: Compilation errorwith page-breaking-page-count3.ly] I did a 'make test' on my patch. This fails, obviously. The console

Re: Error tracking through the log files [was: Re: Compilation error with page-breaking-page-count3.ly]

2012-09-28 Thread David Kastrup
Marc Hohl writes: > Well, it seems to be not as simple as that. > > I did a 'make test' on my patch. This fails, obviously. > The console says: > > Dissecting... > Writing snippets... > Processing... > Processing > /home/marc/git/lilypond/out/lybook-testdb/snippet-names-3552501373601762147.ly >

Error tracking through the log files [was: Re: Compilation error with page-breaking-page-count3.ly]

2012-09-28 Thread Marc Hohl
of pages /lilypond-git/input/regression/page-breaking-page-count3.ly I tried to compile this file both with my patch and with current master and get this error in *both* cases. Can anyone compile the snippet and confirm that? It seems to be a bug totally unrelated to my work ;-) Well, it

Re: Compilation error with page-breaking-page-count3.ly

2012-09-28 Thread Phil Holmes
- Original Message - From: "Marc Hohl" To: Sent: Friday, September 28, 2012 9:16 AM Subject: Compilation error with page-breaking-page-count3.ly Am 28.09.2012 01:38, schrieb lilyp...@googlecode.com: Updates: Labels: -Patch-new Patch-needs_work Comment #33 on issue 27

Compilation error with page-breaking-page-count3.ly

2012-09-28 Thread Marc Hohl
of pages is out of bounds lily-7dccbf09.log:programming error: tried to space systems on a bad number of pages lily-7dccbf09.log:programming error: number of pages is out of bounds lily-7dccbf09.log:programming error: tried to space systems on a bad number of pages /lilypond-git/input/regr

Re: Doc: clarify page-breaking variables (2735) (issue 6453137)

2012-08-20 Thread graham
LGTM http://codereview.appspot.com/6453137/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: clarify page-breaking variables (2735) (issue 6453137)

2012-08-17 Thread joeneeman
lgtm http://codereview.appspot.com/6453137/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Cleanups in one-line-page-breaking. (issue 6248056)

2012-05-31 Thread n . puttock
LGTM. http://codereview.appspot.com/6248056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: what's up with optimal-page-breaking-hstretch.ly

2011-01-04 Thread Joe Neeman
t lilypond will use two on the first page because it strikes a better balance between vertical and horizontal spacing. The remark about the raggedness of the second page is important because ragged spacing affects the page breaking as well as the final page layout. Were the last page not ragged

Re: what's up with optimal-page-breaking-hstretch.ly

2011-01-04 Thread Jan Warchoł
2011/1/4 Phil Holmes : > - Original Message - From: "Jan Warchoł" > >> >> I see no attachment nor any code in e-mail. >> Janek > > It's one of the regtests. Silly me... Sorry about that. Janek ___ lilypond-devel mailing list lilypond-devel@gnu.

Re: what's up with optimal-page-breaking-hstretch.ly

2011-01-04 Thread Phil Holmes
- Original Message - From: "Jan Warchoł" To: "James Bailey" Cc: Sent: Tuesday, January 04, 2011 10:33 AM Subject: Re: what's up with optimal-page-breaking-hstretch.ly 2011/1/4 James Bailey : Compiling this (...) I see no attachment nor

Re: what's up with optimal-page-breaking-hstretch.ly

2011-01-04 Thread Jan Warchoł
2011/1/4 James Bailey : > Compiling this (...) I see no attachment nor any code in e-mail. Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

what's up with optimal-page-breaking-hstretch.ly

2011-01-03 Thread James Bailey
Compiling this with 2.12.3 and 2.13.45 yields (to my eye) rather different results. I personally cannot tell if the systems are horizontally stretched or not. They appear to be centered. Or should this illustrate that only the systems on the first page are vertically stretched? Regardless, in 2.

Re: `#(define page-breaking foo)' vs. `page-breaking = #foo'

2010-12-01 Thread David Kastrup
Mark Polesky writes: > Any reason why the 'page-breaking \paper variable tends to > be declared with a scheme definition? I typically see it > like this in the docs: > > #(define page-breaking ly:minimal-breaking) > > I prefer to use this form though: > &g

Re: `#(define page-breaking foo)' vs. `page-breaking = #foo'

2010-12-01 Thread Valentin Villenave
On Tue, Nov 30, 2010 at 5:49 AM, Mark Polesky wrote: > In my commit b0a027f, I changed the standard setting for > this in paper-defaults-init.ly, and nothing broke as far as > I can tell.  Any opposition to changing the other > scheme-style declarations in the docs? Seems a lot nicer to me :) Pl

`#(define page-breaking foo)' vs. `page-breaking = #foo'

2010-12-01 Thread Mark Polesky
Any reason why the 'page-breaking \paper variable tends to be declared with a scheme definition? I typically see it like this in the docs: #(define page-breaking ly:minimal-breaking) I prefer to use this form though: page-breaking = #ly:minimal-breaking In my commit b0a027f, I change

Re: Page breaking fails for multiline embedded scorelocalhost/

2010-05-03 Thread Carl Sorensen
Boris wrote: > Right now, we start from the list of markups, and for-each markup, > apply the markup function and destructively append! the resulting > stencil to the result list under construction. > > The procedural nature of this design, is somewhat limiting in terms of > expressive power. For

Re: Enhancement: Page breaking to avoid widow lines

2010-01-21 Thread Joe Neeman
On Thu, 2010-01-21 at 13:51 -0500, Boris Shingarov wrote: > Quoting Joe Neeman : > > > Again, I'd suggest uploading patches to codereview.appspot.com, which > > provides nice formatting and makes it easy to have multiple reviewers. > > Ok, I've created Issue 190102 for this. > > One inconvenie

Re: Enhancement: Page breaking to avoid widow lines

2010-01-21 Thread Boris Shingarov
Quoting Joe Neeman : Again, I'd suggest uploading patches to codereview.appspot.com, which provides nice formatting and makes it easy to have multiple reviewers. Ok, I've created Issue 190102 for this. One inconvenience that I see with the "upload.py" tool, is that I don't see a way to spe

Re: Enhancement: Page breaking to avoid widow lines

2010-01-20 Thread Joe Neeman
On Wed, 2010-01-20 at 10:36 -0500, Boris Shingarov wrote: > Quoting Joe Neeman : > > > Again, I'd suggest uploading patches to codereview.appspot.com, which > > provides nice formatting and makes it easy to have multiple reviewers. > > Are there lilypond patches discussed there already? I looke

Re: Enhancement: Page breaking to avoid widow lines

2010-01-20 Thread Boris Shingarov
Quoting Joe Neeman : Again, I'd suggest uploading patches to codereview.appspot.com, which provides nice formatting and makes it easy to have multiple reviewers. Are there lilypond patches discussed there already? I looked around the list of repositories, but I can't find Lilypond. Is ther

Re: Enhancement: Page breaking to avoid widow lines

2010-01-13 Thread Joe Neeman
> Here is the new code -- implementing all that's been discussed. (Ok, > not quite all -- the line length functionality is not implemented, > but > all the style remarks have been taken into account, the > markup-list-id > has been replaced with is-last-line, penalty made configurable, and > a

Re: Enhancement: Page breaking to avoid widow lines

2010-01-13 Thread Boris Shingarov
Here is the new code -- implementing all that's been discussed. (Ok, not quite all -- the line length functionality is not implemented, but all the style remarks have been taken into account, the markup-list-id has been replaced with is-last-line, penalty made configurable, and also, (new, was

Re: Enhancement: Page breaking to avoid widow lines

2010-01-13 Thread Joe Neeman
On Wed, 2010-01-13 at 09:11 -0500, Boris Shingarov wrote: > Joe, > > > Paper_book::get_system_specs then you wouldn't even need the > > markup-list-id property: you could add an avoid-orphan property that > > only gets set for the last line of a multi-line markup list if it is > > short. That migh

Re: Enhancement: Page breaking to avoid widow lines

2010-01-13 Thread Boris Shingarov
Joe, Paper_book::get_system_specs then you wouldn't even need the markup-list-id property: you could add an avoid-orphan property that only gets set for the last line of a multi-line markup list if it is short. That might also simplify Page_spacer::calc_subproblem. This is the first idea that

Re: Enhancement: Page breaking to avoid widow lines

2010-01-13 Thread Joe Neeman
e start of > another paragraph (markuplines or music). Case (2) is when there is nothing > after that lonely last line -- in other words, the last page of the book > consists of one line of markup. It's nice to see someone else touching the page-breaking code :) The ideas in your c

Enhancement: Page breaking to avoid widow lines

2010-01-12 Thread b1
Here is a proposed patch to add functionality to the Page Spacer. When typesetting large quantities of markup lines, Lilypond currently does not try to avoid widowed/orphaned lines. Some publishers will consider this an unacceptable typographical error. I have added a few lines to the Page Spa

Re: page breaking changed in 2.13 ???

2009-05-25 Thread ArnoWaschk
and i am >> >> observing - in comparison to a version from around 10th of April - >> >> that the page breaking strategy seems to have changed significantly. >> >> Which leads me in one case of a before 47page piano reduction score >> >> (1 to 4 staves

Re: page breaking changed in 2.13 ???

2009-05-25 Thread Graham Percival
On Sun, May 24, 2009 at 11:05:43AM -0700, ArnoWaschk wrote: > > i am using a 2.13 lilypond compiled from today's git repo, and i That sounds like a disaster. Please use GUB -- ideally 2.12.2. It's called the "stable branch" for a reason. :) Cheers, - Graham __

Re: page breaking changed in 2.13 ???

2009-05-24 Thread Joe Neeman
On Sun, 2009-05-24 at 11:53 -0700, ArnoWaschk wrote: > > > Werner LEMBERG wrote: > > > > > >> i am using a 2.13 lilypond compiled from today's git repo, and i am > >> observing - in comparison to a version from around 10th of April - > >>

Re: page breaking changed in 2.13 ???

2009-05-24 Thread ArnoWaschk
Arno Waschk wrote: > > > > Werner LEMBERG wrote: >> >> >>> i am using a 2.13 lilypond compiled from today's git repo, and i am >>> observing - in comparison to a version from around 10th of April - >>> that the page breaking strategy

Re: page breaking changed in 2.13 ???

2009-05-24 Thread ArnoWaschk
Werner LEMBERG wrote: > > >> i am using a 2.13 lilypond compiled from today's git repo, and i am >> observing - in comparison to a version from around 10th of April - >> that the page breaking strategy seems to have changed significantly. >> Which leads me i

Re: page breaking changed in 2.13 ???

2009-05-24 Thread Werner LEMBERG
> i am using a 2.13 lilypond compiled from today's git repo, and i am > observing - in comparison to a version from around 10th of April - > that the page breaking strategy seems to have changed significantly. > Which leads me in one case of a before 47page piano reduction score

page breaking changed in 2.13 ???

2009-05-24 Thread ArnoWaschk
Dear list, i am using a 2.13 lilypond compiled from today's git repo, and i am observing - in comparison to a version from around 10th of April - that the page breaking strategy seems to have changed significantly. Which leads me in one case of a before 47page piano reduction score (1

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-21 Thread Joe Neeman
On Thu, 2009-05-14 at 14:17 -0700, Joe Neeman wrote: > > To summarize: there are more fixes to come, but I think page-count=8, > ragged-bottom=##f, ragged-last-bottom=##f gives decent results now. After a couple more fixes, I get reasonable results with or without ragged and with or without page-

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-14 Thread Joe Neeman
On Tue, 2009-05-05 at 12:22 +0200, Reinhold Kainhofer wrote: > Hi all, > I already sent this to lilypond-user last week, but didn't get any hint for a > solution, so maybe the devel list is more helpful: > > > I'm currently trying to squeeze the choir part of a mass onto 8 pages. > Here is the

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-06 Thread Joe Neeman
ter email, the Y-extent-estimates are somewhat too > > large (this is probably because the treble clefs overlap the lyrics when > > they are spaced accurately using skylines, but not when the estimates > > are done). You can compensate for this by setting the > > page-bre

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-06 Thread Reinhold Kainhofer
are somewhat too > large (this is probably because the treble clefs overlap the lyrics when > they are spaced accurately using skylines, but not when the estimates > are done). You can compensate for this by setting the > page-breaking-between-system-padding to something small (or negative

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-06 Thread Joe Neeman
just to move the first system on each page back to the previous page. As you noted in a later email, the Y-extent-estimates are somewhat too large (this is probably because the treble clefs overlap the lyrics when they are spaced accurately using skylines, but not when the estimates are done). You c

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-06 Thread Reinhold Kainhofer
Am Mittwoch, 6. Mai 2009 08:28:51 schrieb Patrick McCarty: > On Tue, May 5, 2009 at 3:22 AM, Reinhold Kainhofer > > wrote: > > Hi all, > > I already sent this to lilypond-user last week, but didn't get any hint > > for a solution, so maybe the devel list is more helpful: > > > > > > I'm currently

Re: Page breaking and squeezing as many systems on a page as possible?

2009-05-05 Thread Patrick McCarty
On Tue, May 5, 2009 at 3:22 AM, Reinhold Kainhofer wrote: > Hi all, > I already sent this to lilypond-user last week, but didn't get any hint for a > solution, so maybe the devel list is more helpful: > > > I'm currently trying to squeeze the choir part of a mass onto 8 pages. > Here is the lilypo

Page breaking and squeezing as many systems on a page as possible?

2009-05-05 Thread Reinhold Kainhofer
Hi all, I already sent this to lilypond-user last week, but didn't get any hint for a solution, so maybe the devel list is more helpful: I'm currently trying to squeeze the choir part of a mass onto 8 pages. Here is the lilypond output with annotated spacing and skyline debugging enabled: http

Re: page-breaking favours last page?

2008-09-12 Thread Patrick McCarty
On Fri, Sep 12, 2008 at 3:00 AM, Reinhold Kainhofer <[EMAIL PROTECTED]> wrote: >> >> I didn't realize 2.11.58 was released, since Han-Wen hasn't pushed a >> tagged commit yet. :-) > > It's not released, but the current development version already has the next > version number, mainly because new f

Re: page-breaking favours last page?

2008-09-12 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Freitag, 12. September 2008 schrieb Patrick McCarty: > Hi Kieren, > > On Thu, Sep 11, 2008 at 04:49:56PM -0400, Kieren MacMillan wrote: > > [Lilypond 2.11.58] > > I didn't realize 2.11.58 was released, since Han-Wen hasn't pushed a > tagged commit y

document page breaking a bit?

2007-05-20 Thread Han-Wen Nienhuys
Hi Joe, I was looking at the brown-paper-bag bug in 11.24 (last page disappearing) and I found that I had a hard time figuring out what the code does. Could you add some comments explaining how the different classes fit together? eg., I'm missing the finer point of - Break_position - Line_di

Re: [patch] top level page breaking directives

2007-05-13 Thread Nicolas Sceaux
Joe Neeman <[EMAIL PROTECTED]> writes: >> However, an issue is remaining: Composite_music is not allowed inside a >> \book block, so the page breaking commands cannot be used between scores >> inside a \book block. Side question: are regression tests containing >> s

Re: [patch] top level page breaking directives

2007-05-09 Thread Nicolas Sceaux
an > even page, then an empty odd page, then the following music on the next > even page). But I did not manage to make "\pageBreak \noPageTurn" to > work (whatever the context, toplevel or inside music). It seems I did not tried enough. The following is working: #(set-defaul

Re: [patch] top level page breaking directives

2007-05-09 Thread Nicolas Sceaux
(music on an even page, then an empty odd page, then the following music on the next even page). But I did not manage to make "\pageBreak \noPageTurn" to work (whatever the context, toplevel or inside music). There does not seem to be a regression test for \noPageTurn. >> However, an iss

Re: [patch] top level page breaking directives

2007-05-09 Thread Mats Bengtsson
Quoting Joe Neeman <[EMAIL PROTECTED]>: Side question: are regression tests containing serveral \score blocks required to have a \book block? ... As for the regression tests, I don't see why they would require a book block. In older versions, lilypond-book only included the first score unless

Re: [patch] top level page breaking directives

2007-05-08 Thread Trevor Bača
On 5/5/07, Nicolas Sceaux <[EMAIL PROTECTED]> wrote: Han-Wen, Joe, Here is a patch which implements top-level page breaking directives, for instance: < snip > Way cool. I've been wanting something like this for sometime, especially for my notes files, which tend to be alte

Re: [patch] top level page breaking directives

2007-05-08 Thread Joe Neeman
a score. Does this mean they work? > However, an issue is remaining: Composite_music is not allowed inside a > \book block, so the page breaking commands cannot be used between scores > inside a \book block. Side question: are regression tests containing > serveral \score blocks r

Re: [patch] top level page breaking directives

2007-05-07 Thread Nicolas Sceaux
permission together. That means that >> something like \forbidPageTurn \forcePageBreak will never work because >> \forcePageBreak will set page-turn-permission, overriding everything that >> \forbidPageTurn does. > > Here is a corrected patch. > > \forbidPageBreak

Re: [patch] top level page breaking directives

2007-05-07 Thread Nicolas Sceaux
Mats Bengtsson <[EMAIL PROTECTED]> writes: > Great! Would it even be possible to use the same page breaking directives > everywhere, both at top-level and within scores? (I don't know anything > about the implementation, but it would be great if users didn't have > t

Re: [patch] top level page breaking directives

2007-05-06 Thread Mats Bengtsson
Great! Would it even be possible to use the same page breaking directives everywhere, both at top-level and within scores? (I don't know anything about the implementation, but it would be great if users didn't have to remember several different directives to use in different

Re: [patch] top level page breaking directives

2007-05-06 Thread Nicolas Sceaux
rn \forcePageBreak will never work because > \forcePageBreak will set page-turn-permission, overriding everything that > \forbidPageTurn does. Here is a corrected patch. \forbidPageBreak and \forcePageBreak incluence page breaking, although sometimes they are not, whereas \forbidPageTurn an

Re: [patch] top level page breaking directives

2007-05-06 Thread Nicolas Sceaux
Joe Neeman <[EMAIL PROTECTED]> writes: > It would be nice if this generalised to having \forcePageTurn and > \forbidPageTurn commands. The problem is that you always set > page-break-permission and page-turn-permission together. That means that > something like \forbidPageTurn \forcePageBreak w

Re: [patch] top level page breaking directives

2007-05-05 Thread Joe Neeman
On Sunday 06 May 2007 03:10, Nicolas Sceaux wrote: > Han-Wen, Joe, > > Here is a patch which implements top-level page breaking directives, for > instance: Great! I think this has been a needed feature for some time. I just have one comment with the implementation, th

[patch] top level page breaking directives

2007-05-05 Thread Nicolas Sceaux
Han-Wen, Joe, Here is a patch which implements top-level page breaking directives, for instance: %% these two markups must be on the same page \markup { ... } \forbidPageBreak \markup { ... } %% the markup and the score must be on the same new page %% that is, same as \header

Re: assert in page breaking

2007-01-24 Thread Han-Wen Nienhuys
Joe Neeman escreveu: > On 1/24/07, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: >> + if (chunks.size () != div.size () + 1) >> +{ >> + programming_error ("did not find a valid page breaking >> configuration"); >> + ignore_div = true; &

Re: assert in page breaking

2007-01-24 Thread Han-Wen Nienhuys
Joe Neeman escreveu: > On 1/24/07, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: >> Joe Neeman escreveu: >> > On 1/24/07, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: >> >> + if (chunks.size () != div.size () + 1) >> >> +{ >> >

Re: assert in page breaking

2007-01-24 Thread Joe Neeman
On 1/24/07, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: Joe Neeman escreveu: > On 1/24/07, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: >> + if (chunks.size () != div.size () + 1) >> +{ >> + programming_error ("did not find a valid page breaking &g

Re: assert in page breaking

2007-01-24 Thread Han-Wen Nienhuys
Joe Neeman escreveu: > On 1/24/07, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: >> + if (chunks.size () != div.size () + 1) >> +{ >> + programming_error ("did not find a valid page breaking >> configuration"); >> + ignore_div = true; &

Re: assert in page breaking

2007-01-24 Thread Han-Wen Nienhuys
Joe Neeman escreveu: > On 1/24/07, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: >> + if (chunks.size () != div.size () + 1) >> +{ >> + programming_error ("did not find a valid page breaking >> configuration"); >> + ignore_div = true; &

Re: assert in page breaking

2007-01-24 Thread Joe Neeman
On 1/24/07, Han-Wen Nienhuys <[EMAIL PROTECTED]> wrote: + if (chunks.size () != div.size () + 1) +{ + programming_error ("did not find a valid page breaking configuration"); + ignore_div = true; + assert (0); this is better, but can we skip the assert()?

assert in page breaking

2007-01-24 Thread Han-Wen Nienhuys
+ if (chunks.size () != div.size () + 1) +{ + programming_error ("did not find a valid page breaking configuration"); + ignore_div = true; + assert (0); this is better, but can we skip the assert()? The problem with assert is that it prevents people from getting

Re: page breaking and vector_sort cleanups

2006-09-17 Thread Han-Wen Nienhuys
Joe Neeman wrote: This patch STL-ifies vector_sort much like my previous patch for binary_search. It also includes my patch for rewriting the interpretation step for page turns. These changes touch a lot of files, so I'd like to get them committed before I mess up my working tree with grob graph

page breaking and vector_sort cleanups

2006-09-16 Thread Joe Neeman
This patch STL-ifies vector_sort much like my previous patch for binary_search. It also includes my patch for rewriting the interpretation step for page turns. These changes touch a lot of files, so I'd like to get them committed before I mess up my working tree with grob graphing stuff. 2006-09-

Re: page breaking documentation

2006-09-07 Thread Graham Percival
Joe Neeman wrote: How about: +sections without notes (either @code{r} or @code{R} rests or [EMAIL PROTECTED] skips). Rests or skips must be present in all contexts within the scope +of the engraver. That is, if the engraver in is a Staff with multiple +voices, then all the voices must have rests

Re: page breaking documentation

2006-09-06 Thread Joe Neeman
On Thu, 2006-09-07 at 08:10 +0200, Erik Sandberg wrote: > On Thursday 07 September 2006 02:25, Joe Neeman wrote: > > On Wed, 2006-09-06 at 15:08 -0700, Graham Percival wrote: > > > Joe Neeman wrote: > > > By "the absence of notes", do you mean "{r | R | s} in all parts", or do > > > you mean "{s} i

Re: page breaking documentation

2006-09-06 Thread Erik Sandberg
On Thursday 07 September 2006 02:25, Joe Neeman wrote: > On Wed, 2006-09-06 at 15:08 -0700, Graham Percival wrote: > > Joe Neeman wrote: > > By "the absence of notes", do you mean "{r | R | s} in all parts", or do > > you mean "{s} in all parts" ? That "does not scan for rests" is a bit > > confus

Re: page breaking documentation

2006-09-06 Thread Joe Neeman
On Wed, 2006-09-06 at 15:08 -0700, Graham Percival wrote: > Joe Neeman wrote: > > +If this is too tedious, you can add a @code{Page_turn_engraver} to a Staff > > or > > +Voice context. The @code{Page_turn_engraver} will scan the context for > > +sections without notes (note that it does not scan f

Re: page breaking documentation

2006-09-06 Thread Graham Percival
Joe Neeman wrote: I figured the new page breaking stuff might be more useful if people had some idea of how to use it. Writing documentation is not something I've had much practice with, so please point out any problems Looks fairly good; I've made a few comments below, but once

page breaking documentation

2006-09-04 Thread Joe Neeman
I figured the new page breaking stuff might be more useful if people had some idea of how to use it. Writing documentation is not something I've had much practice with, so please point out any problems 2006-09-05 Joe Neeman <[EMAIL PROTECTED]> * lily/page-turn-engraver.

Re: page breaking cleanups

2006-08-23 Thread Joe Neeman
. > Please double check OK, this is now just SCM list. (and the other 2 issues are fixed, too) In addition, I've added better support for ragged-bottom and ragged-last-bottom in both of the new page-breakers. 2006-08-23 Joe Neeman <[EMAIL PROTECTED]> * input/regression/o

Re: page breaking cleanups

2006-08-19 Thread Han-Wen Nienhuys
Joe Neeman wrote: +static bool +break_p (Grob *g) +{ + (void) g; /* shutup warning */ + return false; +} can we loose the _p suffixes? use is_break() for the function and Break_predicate for the type. -vector -Page_breaking::get_line_details (vsize start_break, vsize end_break, vector

page breaking cleanups

2006-08-16 Thread Joe Neeman
This introduces an algorithmic improvement and many cleanups in the page breaking code. The algorithmic improvement is that we are able to adjust line-counts on either side of a forced page break independently. This code is contained in the Page_breaking class and abstracted nicely so all

Re: page breaking (again)

2006-08-08 Thread Han-Wen Nienhuys
Joe Neeman wrote: So I run convert-ly -e ly/performer-init.ly input/test/* input/regression/* and I get as far as input/regression/figured-bass.ly which fails as reported on the bug list. Based on the fact that the page-breaking patch was regression-free a couple of weeks ago, can I commit

Re: page breaking (again)

2006-08-08 Thread Joe Neeman
ntName. So I run convert-ly -e ly/performer-init.ly input/test/* input/regression/* and I get as far as input/regression/figured-bass.ly which fails as reported on the bug list. Based on the fact that the page-breaking patch was regression-free a couple of weeks ago, can I commit anyway? Or should I wa

Re: page breaking (again)

2006-08-07 Thread Han-Wen Nienhuys
Joe Neeman wrote: The new files are attached in a tar archive (I cc to Han-Wen just in case the list strips it). There are 13 of them, so I thought it would be easier. Looks good. Please apply, after fixing the following issues. for (vsize k = 0; k < lines_per_page[i] && systems != SCM_

Re: page breaking (again)

2006-08-06 Thread Joe Neeman
On Mon, 2006-08-07 at 00:31 +0200, Han-Wen Nienhuys wrote: > Joe Neeman wrote: > > Here is my latest patch to add a new page-breaker. This actually adds 2 > > page breakers now: > > > Both page-breakers can be tuned with the (book-wide) paper block > > variables "page-spacing-weight" (default 1.0)

Re: page breaking (again)

2006-08-06 Thread Han-Wen Nienhuys
Joe Neeman wrote: Here is my latest patch to add a new page-breaker. This actually adds 2 page breakers now: Both page-breakers can be tuned with the (book-wide) paper block variables "page-spacing-weight" (default 1.0) which specifies the importance of good page spacing relative to line spaci

Re: Proposal: page breaking protocol

2006-08-05 Thread Joe Neeman
On Sat, 2006-08-05 at 12:07 +0200, Nicolas Sceaux wrote: > Joe Neeman <[EMAIL PROTECTED]> writes: > > > The problem is that the two page-breaking problems may not be > > independent. In the page-turn-page-breaker, a page break after an even > > page is different

Re: Proposal: page breaking protocol

2006-08-05 Thread Nicolas Sceaux
Joe Neeman <[EMAIL PROTECTED]> writes: > The problem is that the two page-breaking problems may not be > independent. In the page-turn-page-breaker, a page break after an even > page is different from a page break after an odd page. The wrapper > function wouldn't be able t

Re: Proposal: page breaking protocol

2006-08-02 Thread Joe Neeman
book but not in the other. IMHO, between-scores-or-markups > page breaks belong to the book (at top level), not to the score. You are quite right about this, but there is a problem with doing it transparently for all page-breaking functions. Basically, you want to split the full page-breaking p

Re: Proposal: page breaking protocol

2006-08-02 Thread Nicolas Sceaux
Nicolas Sceaux <[EMAIL PROTECTED]> writes: > Joe Neeman <[EMAIL PROTECTED]> writes: > >>> Today, the page breaking function (optimal-page-breaks) does the page >>> breaking + computes the page stencils + calls the page post process >>> function.

Re: Proposal: page breaking protocol

2006-07-29 Thread Nicolas Sceaux
Joe Neeman <[EMAIL PROTECTED]> writes: >> Today, the page breaking function (optimal-page-breaks) does the page >> breaking + computes the page stencils + calls the page post process >> function. This means that every alternate page breaking function has to >>

Re: Proposal: page breaking protocol

2006-07-28 Thread Joe Neeman
On Fri, 2006-07-28 at 16:59 +0200, Nicolas Sceaux wrote: > Hi, > > Today, the page breaking function (optimal-page-breaks) does the page > breaking + computes the page stencils + calls the page post process > function. This means that every alternate page breaking function has t

Proposal: page breaking protocol

2006-07-28 Thread Nicolas Sceaux
Hi, Today, the page breaking function (optimal-page-breaks) does the page breaking + computes the page stencils + calls the page post process function. This means that every alternate page breaking function has to do the same. I propose to define an umbrella function, which will call the actual

Re: page breaking (again)

2006-07-25 Thread Joe Neeman
On Tue, 2006-07-25 at 16:43 +0200, Nicolas Sceaux wrote: > Joe Neeman <[EMAIL PROTECTED]> writes: > > > Here is my latest patch to add a new page-breaker. > > May you not abbreviate that much variable names in scheme code? > It's usual to write full names, eg. paper-book and page-number, > iso. p

Re: page breaking (again)

2006-07-25 Thread Nicolas Sceaux
Joe Neeman <[EMAIL PROTECTED]> writes: > Here is my latest patch to add a new page-breaker. May you not abbreviate that much variable names in scheme code? It's usual to write full names, eg. paper-book and page-number, iso. p-book and p-num. nicolas ___

page breaking (again)

2006-07-24 Thread Joe Neeman
esp. from C++) * scm/layout-page-layout.scm (make-page-from-systems): new function (optimal-page-breaks): use the new page-breaking calling convention * scm/define-context-properties.scm (all-user-translation-properties): add revokePageTurns * lily/paper-column-eng

Re: page breaking

2006-06-09 Thread Joe Neeman
On Fri, 2006-06-09 at 13:37 +0200, Mats Bengtsson wrote: > > Joe Neeman wrote: > > >... > >(Note: this page-breaker doesn't support break-before. Use \pageBreak or > >\noPageBreak at the end of the previous score instead) > > > > > Great, since break-before was introduced because you previously

Re: page breaking

2006-06-09 Thread Mats Bengtsson
Graham Percival wrote: On 9-Jun-06, at 4:37 AM, Mats Bengtsson wrote: Joe Neeman wrote: ... (Note: this page-breaker doesn't support break-before. Use \pageBreak or \noPageBreak at the end of the previous score instead) Great, since break-before was introduced because you previously c

Re: page breaking

2006-06-09 Thread Joe Neeman
c] = spacer.force (); > > + > > + /* add a (convex) penalty for compression. We do this _only_ in > > get_line_forces, > > +not get_line_configuration. This is temporary, for backwards > > compatibility; > > +the old line/page-breaking stuff ign

<    1   2   3   >