Re: [frogs] Re: patch for bug 729

2009-03-14 Thread Graham Percival
On Sat, Feb 28, 2009 at 05:41:21PM -0700, Carl D. Sorensen wrote: > > On 2/28/09 3:43 PM, "John Mandereau" wrote: > > > Hi Carl, > > Carl D. Sorensen a écrit : > >> So, just for the record, I guess that the appropriate way to handle this > >> would be to: > >> > >> 1. Search through input/lsr

Re: [frogs] Re: patch for bug 729

2009-02-28 Thread Graham Percival
On Sun, Mar 01, 2009 at 12:13:52AM +0100, Valentin Villenave wrote: > how about considering an LSR upgrade now? I distinctly remember asking you to do this in January, > Like, before the whole 2.13 bloody mess starts... Too late for that. I suppose that we *could* backport everything to stable/

Re: [frogs] Re: patch for bug 729

2009-02-28 Thread Carl D. Sorensen
On 2/28/09 3:43 PM, "John Mandereau" wrote: > Hi Carl, > Carl D. Sorensen a écrit : >> So, just for the record, I guess that the appropriate way to handle this >> would be to: >> >> 1. Search through input/lsr for relevant files. >> 2. Fix the snippet to make sure it compiles properly. >> 3

Re: [frogs] Re: patch for bug 729

2009-02-28 Thread Neil Puttock
2009/2/28 Carl D. Sorensen : > I've applied the patch, but it did not include modifications to > input/lsr/demo-midiinstruments.ly. > > We can do that once we get the answer about how to properly handle it. I've just done an LSR update, so it's been amended automatically with Andrew's new convert

Re: [frogs] Re: patch for bug 729

2009-02-28 Thread Valentin Villenave
Neil, John, Graham, how about considering an LSR upgrade now? Like, before the whole 2.13 bloody mess starts... - How involved would it be? - Do we have to download the lsr archive, update the whole thing by ourselves and send the new tarball to Seba? - How do we update snippets that do not ha

Re: [frogs] Re: patch for bug 729

2009-02-28 Thread Neil Puttock
2009/2/28 John Mandereau : > Hi Carl, > Carl D. Sorensen a écrit : >> >> So, just for the record, I guess that the appropriate way to handle this >> would be to: >> >> 1.  Search through input/lsr for relevant files. >> 2.  Fix the snippet to make sure it compiles properly. >> 3.  Copy the snippet

Re: [frogs] Re: patch for bug 729

2009-02-28 Thread John Mandereau
Hi Carl, Carl D. Sorensen a écrit : So, just for the record, I guess that the appropriate way to handle this would be to: 1. Search through input/lsr for relevant files. 2. Fix the snippet to make sure it compiles properly. 3. Copy the snippet to input/new 4. Delete the snippet from input/ls

Re: [frogs] Re: patch for bug 729

2009-02-27 Thread Mats Bengtsson
Graham Percival wrote: On Fri, Feb 27, 2009 at 01:17:53PM -0700, Carl D. Sorensen wrote: You only need to modify text in the body of the documentation, including any examples that are inline in the docs. Erm, that's exactly opposite. - the NR tries to avoid overrides as much as possib

Re: patch for bug 729

2009-02-27 Thread Carl D. Sorensen
On 2/27/09 3:31 PM, "Andrew Hawryluk" wrote: > On Fri, Feb 27, 2009 at 1:17 PM, Carl D. Sorensen wrote: >> >> >> >> On 2/27/09 9:52 AM, "Mats Bengtsson" wrote: >> >>> Not to mention the following example: >>> input/lsr/demo-midiinstruments.ly >>> Hmm, there's some special procedure to up

Re: [frogs] Re: patch for bug 729

2009-02-27 Thread Carl D. Sorensen
On 2/27/09 5:35 PM, "Graham Percival" wrote: > On Fri, Feb 27, 2009 at 01:17:53PM -0700, Carl D. Sorensen wrote: >> >> On 2/27/09 9:52 AM, "Mats Bengtsson" wrote: >> >>> Not to mention the following example: >>> input/lsr/demo-midiinstruments.ly >> >> Don't modify the snippets. That's han

Re: [frogs] Re: patch for bug 729

2009-02-27 Thread Graham Percival
On Fri, Feb 27, 2009 at 01:17:53PM -0700, Carl D. Sorensen wrote: > > On 2/27/09 9:52 AM, "Mats Bengtsson" wrote: > > > Not to mention the following example: > > input/lsr/demo-midiinstruments.ly > > Don't modify the snippets. That's handled by running convert-ly on the > those files. That's

Re: patch for bug 729

2009-02-27 Thread Andrew Hawryluk
On Fri, Feb 27, 2009 at 1:17 PM, Carl D. Sorensen wrote: > > > > On 2/27/09 9:52 AM, "Mats Bengtsson" wrote: > >> Not to mention the following example: >> input/lsr/demo-midiinstruments.ly >> Hmm, there's some special procedure to update the LSR related stuff, so >> check out how to >> get this f

Re: patch for bug 729

2009-02-27 Thread Carl D. Sorensen
On 2/27/09 9:52 AM, "Mats Bengtsson" wrote: > Not to mention the following example: > input/lsr/demo-midiinstruments.ly > Hmm, there's some special procedure to update the LSR related stuff, so > check out how to > get this file updated the proper way. Don't modify the snippets. That's handl

Re: patch for bug 729

2009-02-27 Thread Mats Bengtsson
Not to mention the following example: input/lsr/demo-midiinstruments.ly Hmm, there's some special procedure to update the LSR related stuff, so check out how to get this file updated the proper way. /Mats Mats Bengtsson wrote: Don't forget to also update the documentation: Documentation/u

Re: patch for bug 729

2009-02-27 Thread Mats Bengtsson
Don't forget to also update the documentation: Documentation/user/notation-appendices.itely /Mats Andrew Hawryluk wrote: Attached is my fix for bug #729 and a convert-ly rule. http://code.google.com/p/lilypond/issues/detail?id=729 If I can keep finding bugs that simple, I'll be sending patch

patch for bug 729

2009-02-27 Thread Andrew Hawryluk
Attached is my fix for bug #729 and a convert-ly rule. http://code.google.com/p/lilypond/issues/detail?id=729 If I can keep finding bugs that simple, I'll be sending patches weekly! Andrew From 2311c16f64a21247017cd0dafca5a177f676e506 Mon Sep 17 00:00:00 2001 From: Andrew Hawryluk Date: Fri, 27