hi Pal,
On Tue, Oct 23, 2012 at 8:56 PM, benko@gmail.com wrote:
in C++ there should be a good reason to pass complex structures like
std::vectorGrob_info by value, not by reference to const; in this case
there's no such reason, pass-by-reference works perfectly.
Ah, so this is a
in C++ there should be a good reason to pass complex structures like
std::vectorGrob_info by value, not by reference to const; in this case
there's no such reason, pass-by-reference works perfectly.
Ah, so this is a by-the-way fix. Can it be in a separate commit, please?
it is; I meant to
On Wed, Oct 24, 2012 at 12:36 PM, Benkő Pál benko@gmail.com wrote:
in C++ there should be a good reason to pass complex structures like
std::vectorGrob_info by value, not by reference to const; in this case
there's no such reason, pass-by-reference works perfectly.
Ah, so this is a
On 2012/10/24 10:36:52, benko.pal wrote:
[...]
Ah, so this is a by-the-way fix. Can it be in a separate commit,
please?
it is; I meant to note it but forgot, sorry. is there interest in
pushing such
multi-commit patches to some dev branch?
If there is, people should ask.
Ah, so this is a by-the-way fix. Can it be in a separate commit, please?
it is; I meant to note it but forgot, sorry. is there interest in pushing
such
multi-commit patches to some dev branch?
If there is, people should ask. Substructuring an issue into several
logical commits is good
(as you may know, i dedicate all my code reviews to Graham the
Magnificent :D)
Pal, could you add some comments and a more descriptive commit message?
I see the code, and it seems to make sense, but i don't understand the
why's. For example, why the parameters should be passed in a
different
hi Janek,
Pal, could you add some comments and a more descriptive commit
message? I see
the code, and it seems to make sense, but i don't understand the
why's. For
example, why the parameters should be passed in a different way?
in C++ there should be a good reason to pass complex
Reviewers: ,
Message:
mensural-ligatures.ly is listed as changed - that is not surprising,
although I couldn't tell in advance _how_ it will change. what is a bit
more surprising that I can't tell even now, having seen the regtest
comparison.
Description:
prevent collision of ligatures and
