commit 2fc91caabe6adb61c89915f659e35f3ec8ba5c62 (py-install)
Author: Han-Wen Nienhuys
Date: Sun Apr 5 23:07:56 2020 +0200
https://codereview.appspot.com/549810043/
On Tue, Apr 7, 2020 at 9:44 PM wrote:
>
> LGTM. I think you should push this unblock 2.21.0
>
> https://codereview.appspot.com/549810043/
Ack. Pushed.
--
Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen
LGTM. I think you should push this unblock 2.21.0
https://codereview.appspot.com/549810043/
https://codereview.appspot.com/549810043/diff/567420043/python/GNUmakefile
File python/GNUmakefile (right):
https://codereview.appspot.com/549810043/diff/567420043/python/GNUmakefile#newcode20
python/GNUmakefile:20: INSTALLATION_OUT_SUFFIXES = 2
please drop entirely
I could probably be happy with the following:
diff --git a/make/lilypond-vars.make b/make/lilypond-vars.make
index 3f1e992626..3ac59f19a4 100644
--- a/make/lilypond-vars.make
+++ b/make/lilypond-vars.make
@@ -18,6 +18,8 @@ endif
LANGS=$(shell $(PYTHON) $(top-src-dir)/python/langdefs.py)
export
On 2020/04/06 19:51:11, hanwenn wrote:
> suppress __pycache__
The suppression only works for the test. Running a full build still
gives me python/__pycache__/ in the source directory because PYTHONPATH
points there.
https://codereview.appspot.com/549810043/
I think we should rather do https://codereview.appspot.com/575960043
https://codereview.appspot.com/549810043/