On 2013/03/23 16:38:21, t.daniels_treda.co.uk wrote:
A 'programming error' should be issued only when an internal
inconsistency
in LilyPond's code or data structures is detected. Any such message
should
always result in a bug being reported and tracked. If the problem is
due to
suspect
On Thu, Mar 21, 2013 at 1:21 PM, Janek Warchoł
janek.lilyp...@gmail.com wrote:
On Thu, Mar 21, 2013 at 9:14 AM, d...@gnu.org wrote:
I don't know the logic of the code and its uses, so this is basically
my
unqualified gut feeling and nothing else. [...]
It is telling that (presumably after
janek.lilyp...@gmail.com wrote Saturday, March 23, 2013 3:44 PM
If i got everything right, you'll see in that explanation that an empty
extent isn't harmful (at least in self-alignment) - it just results in
offset being 0.
So, the question is: in general, is it ok if a grob has empty extent?
https://codereview.appspot.com/7533046/diff/3001/lily/self-alignment-interface.cc
File lily/self-alignment-interface.cc (right):
https://codereview.appspot.com/7533046/diff/3001/lily/self-alignment-interface.cc#newcode63
lily/self-alignment-interface.cc:63: programming_error (cannot align on
Thanks for review!
https://codereview.appspot.com/7533046/diff/3001/lily/self-alignment-interface.cc
File lily/self-alignment-interface.cc (right):
https://codereview.appspot.com/7533046/diff/3001/lily/self-alignment-interface.cc#newcode63
lily/self-alignment-interface.cc:63: programming_error
On 2013/03/21 08:04:42, janek wrote:
So, you think that we shouldn't report any programming error in these
alignment
funcitons since an empty extent doesn't prevent us from doing our job
(i.e.
aligning)?
Well, with an empty extent it would appear our job of aligning _self_ is
already done
On Thu, Mar 21, 2013 at 9:14 AM, d...@gnu.org wrote:
On 2013/03/21 08:04:42, janek wrote:
So, you think that we shouldn't report any programming error in these
alignment funcitons since an empty extent doesn't prevent us from
doing our job i.e. aligning)?
Well, with an empty extent it
Janek Warchoł janek.lilyp...@gmail.com writes:
On Thu, Mar 21, 2013 at 9:14 AM, d...@gnu.org wrote:
I don't know the logic of the code and its uses, so this is basically
my unqualified gut feeling and nothing else. Flagging and reporting
a problem without any user-visible consequences does
LGTM
https://codereview.appspot.com/7533046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: dak, MikeSol, J_lowe,
Message:
This is the part of Issue 3239 that introduced additional programming
errors. I hope that the explanation is clear.
Of course there is one fundamental question: maybe we shouldn't complain
about grobs with empty extents, and just silently assume that
10 matches
Mail list logo
