Re: slurs avoid stafflines: move far enough; issue 3628 (issue 35310043)

2013-12-10 Thread k-ohara5a5a
https://codereview.appspot.com/35310043/diff/80001/lily/slur-configuration.cc File lily/slur-configuration.cc (right): https://codereview.appspot.com/35310043/diff/80001/lily/slur-configuration.cc#newcode66 lily/slur-configuration.cc:66: + state.line_thickness_ On 2013/12/08 10:10:11, janek wrot

Re: slurs avoid stafflines: move far enough; issue 3628 (issue 35310043)

2013-12-08 Thread janek . lilypond
One last question and it can bee pushed (as far as i'm concerned). Janek https://codereview.appspot.com/35310043/diff/80001/lily/slur-configuration.cc File lily/slur-configuration.cc (right): https://codereview.appspot.com/35310043/diff/80001/lily/slur-configuration.cc#newcode66 lily/slur-conf

Re: slurs avoid stafflines: move far enough; issue 3628 (issue 35310043)

2013-12-07 Thread k-ohara5a5a
Reviewers: janek, https://codereview.appspot.com/35310043/diff/1/lily/slur-configuration.cc File lily/slur-configuration.cc (right): https://codereview.appspot.com/35310043/diff/1/lily/slur-configuration.cc#newcode64 lily/slur-configuration.cc:64: : state.parameters_.gap_to_staffline_outside_);

Re: slurs avoid stafflines: move far enough; issue 3628 (issue 35310043)

2013-12-07 Thread janek . lilypond
There's one nitpick, other than that it can go. There are some things i would do in another way, but there's no sense wasting time discussing them. I'll just make a new patch if i'll have the time. thanks, and i'm sorry that it took so long! Janek https://codereview.appspot.com/35310043/diff/

slurs avoid stafflines: move far enough; issue 3628 (issue 35310043)

2013-12-06 Thread janek . lilypond
Hi, i'm very busy with other LilyPond stuff, but would like to give this patch a closer look. May i ask to prolong the contdown for it until tomorrow 12:00? Janek https://codereview.appspot.com/35310043/ ___ lilypond-devel mailing list lilypond-deve