Mark, you wrote Saturday, November 13, 2010 12:50 AM
I think I made every suggestion except one. I didn't
change grob to layout object, just because grob
appears as a word so often in define-grob-properties.scm,
and layout doesn't appear once:
That may be so, but it's a standard term in
Apart from the placement of the descriptive text in the IR, which I
think is debatable, I agree with Carl's comments.
Thanks again Mark. Every iteration is an improvement. I think we're
nearly there!
Trevor
http://codereview.appspot.com/3031041/diff/40001/lily/axis-group-interface.cc
File
On 2010/11/12 09:06:06, Trevor Daniels wrote:
http://codereview.appspot.com/3031041/diff/40001/lily/axis-group-interface.cc#newcode780
lily/axis-group-interface.cc:780: The following keys may be set in
the spacing
alists:\n
I'm not sure. The current description is in the interface.
If
You're right, Carl. I'd misunderstood how this works.
Trevor
http://codereview.appspot.com/3031041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2010/11/12 02:46:18, Carl wrote:
Thanks again for your work on this, Mark.
Carl, I think that everything you wrote in this post is
agreeable, including changing the StaffGrouper property name
to default-staff-staff-spacing. I'm happy to implement
all of these changes, but this will have to
On 2010/11/12 17:19:17, Mark Polesky wrote:
Trevor, any objection to Carl's renaming? It's logical and
consistent in my mind, so I'd like to do it.
Sorry to keep changing my mind... In truth I'm still questioning it.
I might like to keep staff-staff-spacing for the StaffGrouper prop.
I'm
On 2010/11/12 21:53:41, Mark Polesky wrote:
I might like to keep staff-staff-spacing for the StaffGrouper
prop. I'm thinking it over, and I'll get back to you.
Guys, I'd rather not change StaffGrouper's
'staff-staff-spacing to 'default-staff-staff-spacing. The
big reason for me is that it is
On 2010/11/12 22:48:57, Mark Polesky wrote:
staff-staff-spacing
When applied to a staff-group's StaffGrouper grob, this
spacing alist controls the distance between consecutive
staves within the staff-group. When applied to a staff's
VerticalAxisGroup grob, it controls the distance between
On 2010/11/12 17:19:17, Mark Polesky wrote:
On 2010/11/12 02:46:18, Carl wrote:
One tiny modification I propose is to put the alist-key
descriptions into default-staff-staff- instead of
staff-staff- because otherwise the prop descriptions on
the IR staff-grouper-interface page would be referring
markpole...@gmail.com wrote Friday, November 12, 2010 10:48 PM
On 2010/11/12 21:53:41, Mark Polesky wrote:
I might like to keep staff-staff-spacing for the StaffGrouper
prop. I'm thinking it over, and I'll get back to you.
Guys, I'd rather not change StaffGrouper's
'staff-staff-spacing to
Here's the latest patch set.
I think I made every suggestion except one. I didn't
change grob to layout object, just because grob
appears as a word so often in define-grob-properties.scm,
and layout doesn't appear once:
$ git grep -c -e \grob\ --and --not -e [-:]grob \
On 2010/11/13 00:50:51, Mark Polesky wrote:
So, could it possibly be? Is this okay to push?
I like it a lot!
Just one more thing -- James has captured new default values from Keith
Ohara's work. Perhaps these new default values should be added as part
of this patch.
LGTM.
What happened to the description of reference points for various
objects? Has that disappeared, or did I just miss it?
Will it be coming back somewhere?
Thanks,
Carl
http://codereview.appspot.com/3031041/diff/64001/Documentation/learning/fundamental.itely
File
Carl and Trevor,
The patch is pushed. Thanks so much for your help!
On 2010/11/13 01:10:47, Carl wrote:
But this change will invalidate James's patch, so we ought
to at least be sure to handle that properly.
Yep. I emailed him on -devel.
What happened to the description of reference
On 11/12/10 6:56 PM, markpole...@gmail.com markpole...@gmail.com wrote:
Does this require a change here?
Yes. This was written in July with commit #6734448, and
Neil fixed the issue two weeks ago with commit #93c53eb.
Best to fix it now or make a note of it somewhere other than
this
In general I agree with Carl's comments. I've suggested in a couple of
places where I'd like to see the IR material truncated. The full
description of the properties should go in the NR, perhaps in an
appendix if you think it's too technical.
Carl and Trevor -
Thanks for looking this over. Here's a new patch set. I
decided to revert the revisions to the NR for the moment.
That's easy enough to revise later on. For now, I'd like to
push this version, and make any smaller changes later. The
basic differences from the previous patch
Thanks again for your work on this, Mark.
I think the spacing-alist description belongs in one of the grob
properties; it's the value of a property, not a property of an
interface.
I much prefer this to the previous patch.
I had an idea about the name of the StaffGrouper staff-staff-spacing
Reviewers: ,
Message:
Here's a new patch-set for renaming the vertical spacing
grob properties. But...
I'm kind of going in circles trying to decide where to put
some things:
1) individual alist-key descriptions
2) individual grob-property descriptions
3) non-staff line reference-points
I
On 2010/11/11 03:53:44, Mark Polesky wrote:
Here's a new patch-set for renaming the vertical spacing
grob properties. But...
I'm kind of going in circles trying to decide where to put
some things:
1) individual alist-key descriptions
2) individual grob-property descriptions
3) non-staff
Many of my general comments were in my reply to your message. There are
some specifics in the files here.
Thanks,
Carl
http://codereview.appspot.com/3031041/diff/30001/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
21 matches
Mail list logo
