Re: bug in magnetic snapping lyrics engraver

2022-04-14 Thread Werner LEMBERG
>> How did you do that? Sorry to rain on your parade, but I would not >> want you to put a lot of work in it if it will not be of mergeable >> quality. > > Attached. In the end the necessary modifications were surprisingly > minor. Please comment, there is certainly room for improvements. Att

Re: bug in magnetic snapping lyrics engraver

2022-04-14 Thread Werner LEMBERG
>> Attached. In the end the necessary modifications were surprisingly >> minor. Please comment, there is certainly room for improvements. > > Thanks. This is a bit what I feared: in this state, there is > potential for things going wrong with other after-line-breaking > callbacks. Those are th

Re: bug in magnetic snapping lyrics engraver

2022-04-14 Thread Jean Abou Samra
Le 14/04/2022 à 18:18, Werner LEMBERG a écrit : How did you do that? Sorry to rain on your parade, but I would not want you to put a lot of work in it if it will not be of mergeable quality. Attached. In the end the necessary modifications were surprisingly minor. Please comment, there is cer

Re: bug in magnetic snapping lyrics engraver

2022-04-14 Thread Alexander Kobel
Hi all, On 4/6/22 20:17, Jean Abou Samra wrote: > Le 06/04/2022 à 14:33, Werner LEMBERG a écrit : >> Is someone taking care of bugs in the magnetic snapping lyrics >> engraver?  Here is an example where it fails to position lyrics >> correctly (see last system in the image). >> >> >> Werner >

Re: bug in magnetic snapping lyrics engraver

2022-04-14 Thread Werner LEMBERG
> How did you do that? Sorry to rain on your parade, but I would not > want you to put a lot of work in it if it will not be of mergeable > quality. Attached. In the end the necessary modifications were surprisingly minor. Please comment, there is certainly room for improvements. Werner

Re: bug in magnetic snapping lyrics engraver

2022-04-14 Thread Jean Abou Samra
Le 14/04/2022 à 17:39, Werner LEMBERG a écrit : There is a problem with ligatures at the syllable boundaries (and kerning). [...] it is not sufficient to shift the right syllable in a syllable pair to the left. Instead, the following should be done. [...] Meanwhile I could implement this :-)

Re: bug in magnetic snapping lyrics engraver

2022-04-14 Thread Werner LEMBERG
> There is a problem with ligatures at the syllable boundaries (and > kerning). [...] it is not sufficient to shift the right syllable > in a syllable pair to the left. Instead, the following should be > done. [...] Meanwhile I could implement this :-) I will submit a MR soon. Werner

Re: bug in magnetic snapping lyrics engraver

2022-04-13 Thread Werner LEMBERG
>> This is ingenious :-) Thanks *a lot* for this solution. In my >> tests it seems to work fine > > You're welcome. I spoke too soon :-) There is a problem with ligatures at the syllable boundaries (and kerning). While this can be considered an ugliness in languages based on the latin script,

Re: bug in magnetic snapping lyrics engraver

2022-04-07 Thread Carl Sorensen
On Thu, Apr 7, 2022 at 10:04 AM Kieren MacMillan < kie...@kierenmacmillan.info> wrote: > Hi Werner (et al.), > > > This is ingenious :-) Thanks *a lot* for this solution. > > +1 (x2) > > > * I *strongly* vote for polishing and documenting this so that it can > > be added to LilyPond. It's an inv

Re: bug in magnetic snapping lyrics engraver

2022-04-07 Thread Kieren MacMillan
Hi Werner (et al.), > This is ingenious :-) Thanks *a lot* for this solution. +1 (x2) > * I *strongly* vote for polishing and documenting this so that it can > be added to LilyPond. It's an invaluable feature IMHO, greatly > enhancing Lyrics. YES PLEASE!! If anyone is interested in discussi

Re: bug in magnetic snapping lyrics engraver

2022-04-07 Thread Jean Abou Samra
Le 07/04/2022 à 11:44, Werner LEMBERG a écrit : Did I miss something? Whoops, big problem at line breaks ... This is ingenious :-) Thanks *a lot* for this solution. In my tests it seems to work fine You're welcome. Two comments. * I *strongly* vote for polishing and documenting this so

Re: bug in magnetic snapping lyrics engraver

2022-04-07 Thread Werner LEMBERG
>> Did I miss something? > > Whoops, big problem at line breaks ... This is ingenious :-) Thanks *a lot* for this solution. In my tests it seems to work fine. Two comments. * I *strongly* vote for polishing and documenting this so that it can be added to LilyPond. It's an invaluable feature

Re: bug in magnetic snapping lyrics engraver

2022-04-07 Thread Werner LEMBERG
> The second bug is super hard to fix: when you tell LilyPond about > spacing constraints between lyrics, before line breaking, you need > to assume a lyric syllable won't be moved to the left by > 'magnetism', because if you do, the spacer might think it can space > its right neighbor more to th

Re: bug in magnetic snapping lyrics engraver

2022-04-06 Thread Jean Abou Samra
Le 06/04/2022 à 20:17, Jean Abou Samra a écrit : Did I miss something? Whoops, big problem at line breaks ... \version "2.23.7" #(define (Left_hyphen_pointer_engraver context)    (let ((hyphen #f) (text #f)) (make-engraver   (acknowledgers    ((lyric-syllable-interface e

Re: bug in magnetic snapping lyrics engraver

2022-04-06 Thread Kieren MacMillan
Hi Jean, > To be honest, I don't know why the snippet is so complicated. Perhaps a corollary to Clarke's Law? “Every sufficiently primitive technology is indistinguishable from garbage.” ;) [No offence to the wonderful coders who wrote the existing snippet! Just a funny observation re: Clarke.]

Re: bug in magnetic snapping lyrics engraver

2022-04-06 Thread Jean Abou Samra
Le 06/04/2022 à 14:33, Werner LEMBERG a écrit : Is someone taking care of bugs in the magnetic snapping lyrics engraver? Here is an example where it fails to position lyrics correctly (see last system in the image). Werner PS: I've attached a version of `magnetic-lyrics.ily` that actual

Re: bug in magnetic snapping lyrics engraver

2022-04-06 Thread Werner LEMBERG
> Here is an example where it fails to position lyrics correctly (see > last system in the image). And while we are at it: Here is another bug, already reported in https://lists.gnu.org/archive/html/lilypond-user/2020-03/msg00289.html I've slightly sharpened the test to exclude the possibilit

bug in magnetic snapping lyrics engraver

2022-04-06 Thread Werner LEMBERG
Is someone taking care of bugs in the magnetic snapping lyrics engraver? Here is an example where it fails to position lyrics correctly (see last system in the image). Werner PS: I've attached a version of `magnetic-lyrics.ily` that actually works with the current development version