Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Shawn Guo
Hi Dave, On Thu, Dec 29, 2011 at 02:21:03PM +0800, Richard Zhao wrote: > There's still a bug that, after rmmod module, cpu0 still has cpufreq > sysfs entry. > > cpufreq_unregister_driver can not clean up everything. > Is this an known issue to cpufreq core? -- Regards, Shawn

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Richard Zhao
There's still a bug that, after rmmod module, cpu0 still has cpufreq sysfs entry. cpufreq_unregister_driver can not clean up everything. unfortunately, I don't have much time to debug cpufreq core. Log: root@ubuntu:~# insmod /clk-reg-cpufreq.ko clk_reg_cpufreq: regulator cpu get failed. trying

RE: [PATCH 3/3] ARM: EXYNOS: Invert VCLK polarity for framebuffer on Origen board

2011-12-28 Thread Kukjin Kim
Tushar Behera wrote: > > Framebuffer driver needs to fetch the video data during the rising > edge of the VCLK. Otherwise, there are some glitches in the LCD > display. > > Signed-off-by: Tushar Behera > --- > arch/arm/mach-exynos/mach-origen.c |3 ++- > 1 files changed, 2 insertions(+), 1

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Shawn Guo
On Wed, Dec 28, 2011 at 12:54:21PM +, Mark Brown wrote: > On Wed, Dec 28, 2011 at 09:06:20PM +0800, Shawn Guo wrote: > > On Wed, Dec 28, 2011 at 12:47:40PM +, Mark Brown wrote: > > > > > One word. You mean I have to always depends on REGULATOR config, right? > > > > Yes. > > > I do not c

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Mark Brown
On Wed, Dec 28, 2011 at 09:06:20PM +0800, Shawn Guo wrote: > On Wed, Dec 28, 2011 at 12:47:40PM +, Mark Brown wrote: > > > One word. You mean I have to always depends on REGULATOR config, right? > > Yes. > I do not care too much. But it puts the driver on an interesting > position, that is

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Shawn Guo
On Wed, Dec 28, 2011 at 12:47:40PM +, Mark Brown wrote: > > One word. You mean I have to always depends on REGULATOR config, right? > > Yes. I do not care too much. But it puts the driver on an interesting position, that is it can work without a regulator driver backing the cpu voltage but i

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Mark Brown
On Wed, Dec 28, 2011 at 08:40:56PM +0800, Richard Zhao wrote: > On Wed, Dec 28, 2011 at 12:14:04PM +, Mark Brown wrote: > > On Wed, Dec 28, 2011 at 08:05:20PM +0800, Richard Zhao wrote: > > > > Looks like the problem with your mail client is that it's wrapping at > > exactly 80 characters whic

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Richard Zhao
On Wed, Dec 28, 2011 at 12:14:04PM +, Mark Brown wrote: > On Wed, Dec 28, 2011 at 08:05:20PM +0800, Richard Zhao wrote: > > Looks like the problem with your mail client is that it's wrapping at > exactly 80 characters which is too little - you need to leave space for > being quoted. I'm using

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Mark Brown
On Wed, Dec 28, 2011 at 08:05:20PM +0800, Richard Zhao wrote: Looks like the problem with your mail client is that it's wrapping at exactly 80 characters which is too little - you need to leave space for being quoted. > On Wed, Dec 28, 2011 at 11:42:37AM +, Mark Brown wrote: > > You can't us

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Richard Zhao
On Wed, Dec 28, 2011 at 11:42:37AM +, Mark Brown wrote: > On Wed, Dec 28, 2011 at 11:31:29AM +0800, Richard Zhao wrote: > > On Wed, Dec 28, 2011 at 11:14:10AM +0800, Richard Zhao wrote: > > > > > + if (cpu_reg) { > > > > + ret = regulator_is_supported_voltag

Re: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver

2011-12-28 Thread Mark Brown
On Wed, Dec 28, 2011 at 11:31:29AM +0800, Richard Zhao wrote: > On Wed, Dec 28, 2011 at 11:14:10AM +0800, Richard Zhao wrote: > > > + if (cpu_reg) { > > > + ret = regulator_is_supported_voltage(cpu_reg, > > > + cpu_volts[i * 2], cpu_volts[i *

RE: [PATCH] ARM: EXYNOS4: Enable Bluetooth on ORIGEN

2011-12-28 Thread Kukjin Kim
Sangwook Lee wrote: > > This patch enables Bluetooth support on ORIGEN board. > > Signed-off-by: Sangwook Maybe should be 'Signed-off-by: Sangwook Lee '? Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ___