2011/9/14 Per Forlin :
> Akinobu Mita reported that the boot option for mmc fault injection is never
> compiled in due to a fauly "ifdef KERNEL" that is never set.
> A correct ifdef would be "ifndef MODULE". This patch set adds a
> module_param_cb() and thereby no
2011/9/14 Per Forlin :
+static int fail_mmc_request_param_set(const char *val,
+ const struct kernel_param *kp)
+{
+ setup_fault_attr(&fail_default_attr, (char *) val);
> I am thinking of returning failure here if setup_fault_attr() fai
2011/9/14 Per Forlin :
> +#ifdef CONFIG_FAIL_MMC_REQUEST
> +
> +static DECLARE_FAULT_ATTR(fail_default_attr);
> +static char *fail_request;
This is not used anymore and ...
> +static int fail_mmc_request_param_set(const char *val,
> + const struct kernel_param
2011/9/14 Per Forlin :
> It's simple and the patch would be just two lines.
> The reason for changing my mind is that it may be useful to be able to
> pass the fault injection attributes even when mmc_core is a module.
>
>> module_param is more complicated than this. Also the parameter is only
>>
2011/9/14 Per Forlin :
> Hi Akinobu,
>
> On 13 September 2011 16:19, Per Forlin wrote:
>> On 13 September 2011 15:12, Akinobu Mita wrote:
>>> 2011/8/19 Per Forlin :
>>>
>>>> +#ifdef KERNEL
>>>> +/*
>>>> + * Internal funct
2011/8/19 Per Forlin :
> +#ifdef KERNEL
> +/*
> + * Internal function. Pass the boot param fail_mmc_request to
> + * the setup fault injection attributes routine.
> + */
> +static int __init setup_fail_mmc_request(char *str)
> +{
> + return setup_fault_attr(&fail_mmc_request, str);
> +}
> +_
2011/8/9 Per Forlin :
> Do you think it would be possible to get only the export
> fault-injection patch in 3.1? I know it's not a bugfix so I guess it
> wont be accepted.
No modules except mmc plan to use those symbols. So I think there is
no reason to merge them separately.
__
2011/8/9 Per Forlin :
> Patch #1 "fault-injection: export fault injection functions" is merged
Maybe you are looking at wrong tree. I can't find it in Linus' tree or
mmotm patches.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.l
All three patches look good.
Acked-by: Akinobu Mita
2011/8/9 Per Forlin :
> This patchset is sent to the mm-tree because it depends on Akinobu's patch
> "fault-injection: add ability to export fault_attr in..."
That patch has already be
_create_debugfs_attr) is not likely to change for a time. You can
add Acked-by: Akinobu Mita
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
2011/7/27 Per Forlin :
> This adds support to inject data errors after a completed host transfer.
> The mmc core will return error even though the host transfer is successful.
> This simple fault injection proved to be very useful to test the
> non-blocking error handling in the mmc_blk_issue_rw_rq
2011/7/26 Per Forlin :
>>> And I know that init_fault_attr_dentries() can only create a
>>> subdirectory in debugfs root directory. But I have a patch which
>>> support for creating it in arbitrary directory. Could you take a look
>>> at this? (Note that this patch is based on mmotm and not yet t
y create a
subdirectory in debugfs root directory. But I have a patch which
support for creating it in arbitrary directory. Could you take a look
at this? (Note that this patch is based on mmotm and not yet tested)
From 79fdd83b2af932d6fd155ae918e20572e6784bb8 Mon Sep 17 00:00:00 2001
From: Akinobu Mita
13 matches
Mail list logo
