Re: [PATCH V2 4/6] Thermal: Remove the cooling_cpufreq_list.

2012-10-30 Thread Amit Kachhap
On 26 October 2012 12:39, hongbo.zhang wrote: > From: "hongbo.zhang" > > Problem of using this list is that the cpufreq_get_max_state callback will be > called when register cooling device by thermal_cooling_device_register, but > this list isn't ready at this moment. What's more, there is no nee

Re: [PATCH V2 3/6] Thermal: fix bug of counting cpu frequencies.

2012-10-29 Thread Amit Kachhap
On 24 October 2012 19:04, Viresh Kumar wrote: > On 24 October 2012 17:28, hongbo.zhang wrote: >> From: "hongbo.zhang" >> >> In the while loop for counting cpu frequencies, if table[i].frequency equals >> CPUFREQ_ENTRY_INVALID, index i won't be increased, so this leads to an >> endless >> loop,

Re: [PATCH V2 2/6] Thermal: make sure cpufreq cooling register after cpufreq driver

2012-10-29 Thread Amit Kachhap
On 24 October 2012 17:28, hongbo.zhang wrote: > From: "hongbo.zhang" > > The cpufreq works as a cooling device, so the cooling layer should check if > the > cpufreq driver is initialized or not. > > Signed-off-by: hongbo.zhang > --- > drivers/thermal/cpu_cooling.c | 4 > 1 file changed, 4

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-13 Thread amit kachhap
On Fri, Jul 13, 2012 at 3:39 PM, Hongbo Zhang wrote: > > > On 12 May 2012 17:40, Amit Daniel Kachhap wrote: >> >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling up/down based on the registration >> parameters. Different cpu related coo

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-11 Thread amit kachhap
On Tue, Jul 10, 2012 at 12:31 PM, Hongbo Zhang wrote: > > > On 12 May 2012 17:40, Amit Daniel Kachhap wrote: >> >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling up/down based on the registration >> parameters. Different cpu related co

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-09 Thread amit kachhap
Hi Rob/Eduardo, As these patches have still not made into mainline. I will rebase the whole set along with your suggestion and send them shortly. Sorry for late reply. Thanks, Amit Daniel On Tue, Jun 26, 2012 at 1:12 PM, Valentin, Eduardo wrote: > Hey Rob and Amit, > > On Tue, Jun 26, 2012 at 6

Re: [PATCH v3 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-05-09 Thread Amit Kachhap
On 9 May 2012 01:36, Zhang, Rui wrote: > Hi, Amit, > > Sorry for the late response as I'm in a travel recently. > > I think the generic cpufreq cooling patches are good. > > But about the THERMAL_TRIP_STATE_INSTANCE patch, what I'd like to see is that > 1. from thermal zone point of view, when the

Re: [PATCH v3 5/6] thermal: exynos: Register the tmu sensor with the kernel thermal layer

2012-05-09 Thread Amit Kachhap
On 9 May 2012 01:46, Andrew Morton wrote: > On Tue,  8 May 2012 21:48:17 +0530 > Amit Daniel Kachhap wrote: > >> This code added creates a link between temperature sensors, linux thermal >> framework and cooling devices for samsung exynos platform. This layer >> monitors the temperature from the

Re: [PATCH v3 2/6] thermal: Add generic cpufreq cooling implementation

2012-05-09 Thread Amit Kachhap
On 9 May 2012 01:46, Andrew Morton wrote: > On Tue,  8 May 2012 21:48:14 +0530 > Amit Daniel Kachhap wrote: > >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling up/down based on the registration >> parameters. Different cpu related cool

Re: [PATCH] ARM: exynos: Adapt to cpuidle core time keeping and irq enable

2012-05-08 Thread amit kachhap
Hi Mr Kukjin, Any comment or update about this patch? Regards, Amit Daniel On Mon, Apr 30, 2012 at 10:13 PM, Rob Lee wrote: > On Wed, Apr 25, 2012 at 9:44 AM, Daniel Lezcano > wrote: >> On 04/25/2012 02:11 PM, Amit Daniel Kachhap wrote: >>> >>> This patch enables core cpuidle timekeeping and i

Re: [PATCH V2 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-04-24 Thread Amit Kachhap
On 16 April 2012 07:37, Zhang Rui wrote: > On 三, 2012-04-11 at 18:17 +0530, Amit Kachhap wrote: >> Hi Rui, >> >> Thanks for looking into the patches. >> >> On 10 April 2012 06:28, Zhang Rui wrote: >> > Hi, Amit, >> > >> > On 三, 201

Re: [PATCH V2 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-04-11 Thread Amit Kachhap
Hi Rui, Thanks for looking into the patches. On 10 April 2012 06:28, Zhang Rui wrote: > Hi, Amit, > > On 三, 2012-04-04 at 10:02 +0530, Amit Kachhap wrote: >> Hi Len/Rui, >> >> Any comment or feedback from your side about the status of this patch? >> Is it merg

Re: [PATCH V2 0/6] thermal: exynos: Add kernel thermal support for exynos platform

2012-04-03 Thread Amit Kachhap
Hi Len/Rui, Any comment or feedback from your side about the status of this patch? Is it merge-able or major re-work is needed? I have fixed most of the comments in this patchset and currently working on some of the minor comments received and will submit them shortly. Regards, Amit Daniel On 19

Re: [linux-pm] [PATCH 1/4] thermal: Add a new trip type to use cooling device instance number

2012-04-03 Thread Amit Kachhap
Hi Eduardo, On 3 April 2012 19:45, Eduardo Valentin wrote: > Hello, > > On Thu, Feb 23, 2012 at 04:50:14PM +0530, Amit Kachhap wrote: >> On 23 February 2012 12:16, R, Durgadoss wrote: >> > Hi Amit, >> > >> >> -Original Message- >> >

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Amit Kachhap
On 21 March 2012 19:43, Jean Delvare wrote: > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: >> Basically without this patch changing the mode of thermal zone >> is not possible as wrong string size is passed to strncmp. > > Actually it is possible, > $ echo -n disabled > mode > wo

Re: [PATCH V2 3/6] thermal: Add generic cpuhotplug cooling implementation

2012-03-19 Thread Amit Kachhap
On 19 March 2012 17:15, Srivatsa S. Bhat wrote: > On 03/19/2012 11:47 AM, Amit Daniel Kachhap wrote: > >> This patch adds support for generic cpu thermal cooling low level >> implementations using cpuhotplug based on the thermal level requested >> from user. Different cpu related cooling devices c

Re: [linux-pm] [PATCH 2/4] thermal: Add generic cpufreq cooling implementation

2012-03-13 Thread Amit Kachhap
On 13 March 2012 15:44, Sundar wrote: > On Tue, Mar 13, 2012 at 3:30 PM, Amit Kucheria > wrote: >> Sundar, > > Hi Amit, > >> At the moment it doesn't. But there was some discussion around >> creating something that will work with devfreq. This would allow >> peripheral drivers to be plugged in a

Re: [linux-pm] [PATCH 2/4] thermal: Add generic cpufreq cooling implementation

2012-03-12 Thread Amit Kachhap
On 11 March 2012 09:41, Sundar wrote: > Hi Amit, > > I am new here; so please bear with my questions/doubts :) > > On Wed, Feb 22, 2012 at 3:44 PM, Amit Daniel Kachhap > wrote: >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling up/down

Re: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread Amit Kachhap
On 13 March 2012 09:24, Tushar Behera wrote: > On 03/03/2012 04:36 PM, Amit Daniel Kachhap wrote: >> This codes uses the generic linux thermal layer and creates a bridge >> between temperature sensors, linux thermal framework and cooling devices >> for samsung exynos platform. This layer recieves

Re: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread Amit Kachhap
Hi Durgadoss, Thanks for the detailed review. On 12 March 2012 16:21, R, Durgadoss wrote: > Hi Amit, > > Thanks for keeping this up. And Sorry for late reply. > >> -Original Message----- >> From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit D

Re: [lm-sensors] [linux-pm] [PATCH 2/4] hwmon: exynos4: Move thermal sensor driver to driver/mfd directory

2012-03-05 Thread Amit Kachhap
On 3 March 2012 23:34, Guenter Roeck wrote: > On Sat, Mar 03, 2012 at 11:44:10AM -0500, Mark Brown wrote: >> On Sat, Mar 03, 2012 at 04:36:05PM +0530, Amit Daniel Kachhap wrote: >> > This movement is needed because the hwmon entries and corresponding >> > sysfs interface is a duplicate of utilitie

Re: [PATCH 2/4] hwmon: exynos4: Move thermal sensor driver to driver/mfd directory

2012-03-05 Thread Amit Kachhap
On 3 March 2012 17:51, Sylwester Nawrocki wrote: > On 03/03/2012 12:06 PM, Amit Daniel Kachhap wrote: >> >> This movement is needed because the hwmon entries and corresponding >> sysfs interface is a duplicate of utilities already provided by >> driver/thermal/thermal_sys.c. The goal is to place i

Re: [PATCH v6 3/9] ARM: exynos: Consolidate time keeping and irq enable

2012-02-29 Thread Amit Kachhap
Hi, I verified this patch on exynos4 based origen board. Tested-by: Amit Daniel Thanks, Amit D On 29 February 2012 08:41, Robert Lee wrote: > Enable core cpuidle timekeeping and irq enabling and remove that > handling from this code. > > Signed-off-by: Robert Lee > --- >  arch/arm/mach-exyno

Re: [PATCH 2/4] thermal: Add generic cpufreq cooling implementation

2012-02-26 Thread Amit Kachhap
Hi Durgadoss, Thanks for the detailed review comments. On 24 February 2012 16:34, R, Durgadoss wrote: > Hi Amit, > >> -Original Message----- >> From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel >> Kachhap >> Sent: Wednesday, February

Re: [PATCH 1/4] thermal: Add a new trip type to use cooling device instance number

2012-02-23 Thread Amit Kachhap
On 23 February 2012 12:16, R, Durgadoss wrote: > Hi Amit, > >> -Original Message----- >> From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel >> Kachhap >> Sent: Wednesday, February 22, 2012 3:44 PM >> To: linux...@lists.l

Re: February 2012 Kernel Release

2012-02-21 Thread Amit Kachhap
On 21 February 2012 16:37, Kukjin Kim wrote: > Amit Kachhap wrote: >> >> Hi kukjin Kim, >> > Hi, > >> I was on travel for elc and linaro conferences so little late for >> replying. Thanks for testing these patches. >> I just submitted the V6 series of

Re: February 2012 Kernel Release

2012-02-20 Thread Amit Kachhap
they are working fine. Some modification was done for CHECK_FLAG. Thanks, Amit Daniel On 18 February 2012 07:29, Kukjin Kim wrote: > Amit Kachhap wrote: >> >> Hi Amit Kucheria, >> > Hi all, > > (Cc'ed Jaecheol Lee and Jongpill Lee) > >> I have asked

Re: February 2012 Kernel Release

2012-02-17 Thread Amit Kachhap
Hi Amit Kucheria, I have asked the samsung maintainer(Kukjin Kim) to queue this patch set 1 month back. But seems like it is not present. Hi Mr Kim, Can you please queue this patchset in your tree for next merge window? The V5 version submitted fixes all the known issues. http://lists.infradead

Re: Last call for patches for the 12.02 release of linux-linaro kernel

2012-02-15 Thread Amit Kachhap
Hi Andrey, Please pull my latest thermal changes from git://git.linaro.org/people/amitdanielk/linux.gitexynos_thermal_latest The configs option which needed to be turn on is defined below, https://wiki.linaro.org/WorkingGroups/PowerManagement/Doc/Kconfig#Arch-independent-1 https://wiki.linaro

Re: [linux-pm] [RFC PATCH] thermal: Add support to report cooling statistics achieved by cooling devices

2012-02-07 Thread Amit Kachhap
On 6 February 2012 16:18, Greg KH wrote: > On Mon, Feb 06, 2012 at 03:16:17PM -0800, Amit Kachhap wrote: >> On 6 February 2012 09:03, Greg KH wrote: >> > On Mon, Feb 06, 2012 at 05:56:58PM +0100, Pavel Machek wrote: >> >> Hi! >> >> >> >> >

Re: [linux-pm] [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-02-07 Thread Amit Kachhap
Hi eduardo, Again thanks for the review. On 7 February 2012 00:25, Eduardo Valentin wrote: > Hello Amit, > > On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote: >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling and cp

Re: [linux-pm] [RFC PATCH] thermal: Add support to report cooling statistics achieved by cooling devices

2012-02-07 Thread Amit Kachhap
Hi eduardo, Thanks for the detail review. On 6 February 2012 23:09, Eduardo Valentin wrote: > Hello Amit, > > some comments embedded. > > On Wed, Jan 18, 2012 at 02:51:07PM +0530, Amit Daniel Kachhap wrote: >> Add a sysfs node code to report effective cooling of all cooling devices >> attached t

Re: [linux-pm] [RFC PATCH] thermal: Add support to report cooling statistics achieved by cooling devices

2012-02-06 Thread Amit Kachhap
On 6 February 2012 09:03, Greg KH wrote: > On Mon, Feb 06, 2012 at 05:56:58PM +0100, Pavel Machek wrote: >> Hi! >> >> > Add a sysfs node code to report effective cooling of all cooling devices >> > attached to each trip points of a thermal zone. The cooling data reported >> > will be absolute if t

Re: [RFC PATCH 0/2] thermal: Add generic cpu cooling devices according to thermal framework

2012-02-03 Thread Amit Kachhap
On 3 February 2012 12:42, Zhang Rui wrote: > Hi, sorry for the late response. > > On 四, 2012-01-19 at 14:47 +0530, Amit Kachhap wrote: >> On 13 December 2011 20:43, Amit Daniel Kachhap >> wrote: >> > PATCH 1)  [thermal: Add a new trip type to use cooling device in

Re: [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-02-02 Thread Amit Kachhap
On 1 February 2012 20:27, Matthew Garrett wrote: > On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote: >> This patch adds support for generic cpu thermal cooling low level >> implementations using frequency scaling and cpuhotplugg currently. > > We've been over this kind of thing

Re: [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2012-02-01 Thread Amit Kachhap
On 1 February 2012 20:19, Matthew Garrett wrote: > > I'm not really a fan of this as it stands - the name isn't very > intuitive and the code's pretty difficult to read. Would the following > (incomplete and obviously untested) not have the effect you want? Then > you register multiple trip points

Re: [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2012-02-01 Thread Amit Kachhap
On 1 February 2012 20:19, Matthew Garrett wrote: > I'm not really a fan of this as it stands - the name isn't very > intuitive and the code's pretty difficult to read. Would the following > (incomplete and obviously untested) not have the effect you want? Then > you register multiple trip points

Re: [RFC PATCH 0/2] thermal: Add generic cpu cooling devices according to thermal framework

2012-01-19 Thread Amit Kachhap
On 13 December 2011 20:43, Amit Daniel Kachhap wrote: > PATCH 1)  [thermal: Add a new trip type to use cooling device instance number] > This patch adds a new trip type THERMAL_TRIP_STATE_ACTIVE which passes > cooling device instance number and may be helpful for cpufreq cooling devices > to take

Re: [linux-pm] [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2012-01-12 Thread Amit Kachhap
each STATE_ACTIVE trip point with its corresponding cooling data. > > BR, > Rob > > On Tue, Dec 20, 2011 at 11:11 PM, Amit Kachhap > wrote: >>  Hi Vincent, >> >> Thanks for the review. >> Well actually your are correct that current temperature and las

Re: [RFC PATCH 2/2] thermal: Add generic cpu cooling implementation

2012-01-12 Thread Amit Kachhap
On 11 January 2012 13:32, Rob Lee wrote: > Hey Amit, I was able to use your code on an i.MX6Q thermal > implementation and it seemed to work pretty well.  Thanks for adding > this.  A couple of comments below. Thanks for testing and reviewing the code. > > On Tue, Dec 13, 2011 at 9:13 AM, Amit Dan

Re: linaro powertop doesn't work during initialization of ncurse

2012-01-12 Thread Amit Kachhap
Hi Chanwoo Choi, I remember I found some of those issues when making cross-compiled static powertop binaries due to incompatible ncurses database files. Then I moved to native compilation of powertop binaries for ARM boards. May be this will give you some pointers. Anyway I will test with new libc

Re: [RFC PATCH 0/2] thermal: Add generic cpu cooling devices according to thermal framework

2012-01-10 Thread Amit Kachhap
gt; https://wiki.linaro.org/WorkingGroups/PowerManagement/Doc/Kconfig > under Exynos->Thermal? > > Zach and Ricardo will then ensure that their kernels have those > Kconfig options enabled. > > /Amit > > On Wed, Dec 14, 2011 at 6:54 PM, Amit Kachhap > wrote: > > Hi Ni

Re: [PATCH V4 0/5] ARM: exynos: Add l2 retention mode cpuidle state

2012-01-04 Thread Amit Kachhap
On 3 January 2012 18:52, Kukjin Kim wrote: > amit kachhap wrote: >> >> Hi Mr kim, >> >> All the comments have been addressed for the Exynos cpu idle patchset. >> The updated patchset was posted about one month back and there have >> been no further commen

Re: [lm-sensors] [RFC PATCH 2/3] thermal: exynos4: Register the tmu sensor with the thermal interface layer

2012-01-04 Thread Amit Kachhap
Hi Guenter, The main idea of this work is to leave the current userspace based notification scheme and add the kernel based cooling scheme on top of it. Anyway, It is a good idea to move the file hwmon/exynos4_tmu.c as this creates 2 hwmon entries. Adding CC: Donggeun Kim to know his opinion. Tha

Re: [PATCH V4 0/5] ARM: exynos: Add l2 retention mode cpuidle state

2012-01-02 Thread amit kachhap
Hi Mr kim, All the comments have been addressed for the Exynos cpu idle patchset. The updated patchset was posted about one month back and there have been no further comments on the patchset since then. As this patchset seems to be stable now, do you think these these patches can merged in this 3

Re: [linux-pm] [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2011-12-20 Thread Amit Kachhap
Hi Vincent, Thanks for the review. Well actually your are correct that current temperature and last temperature can be used to increase or decrease the cpu frequency. But this has to be done again in cooling devices so to make the cooling devices generic and to avoid the temperature comparison ag

Re: [linux-pm] [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2011-12-20 Thread Amit Kachhap
Hi Vincent, Thanks for the review. Well actually your are correct that current temperature and last temperature can be used to increase or decrease the cufreq. But this has to be done again in cooling devices so to make the cooling devices generic and to avoid the temperature comparision again thi

Re: [RFC PATCH 0/2] thermal: Add generic cpu cooling devices according to thermal framework

2011-12-14 Thread Amit Kachhap
added since commit id 971be11492b1e248798f7078592b1fa0dfbf3534 Thanks, Amit Daniel On 14 December 2011 20:11, Amit Kachhap wrote: > Hi Nicolas, > > Is it possible for you to add these 2 patches for this month release? I am > not able to give you the git link as there is seems some

Re: [RFC PATCH 0/2] thermal: Add generic cpu cooling devices according to thermal framework

2011-12-14 Thread Amit Kachhap
Hi Nicolas, Is it possible for you to add these 2 patches for this month release? I am not able to give you the git link as there is seems some problem with the linaro git server. Also I attached the patches in case required. Thanks, Amit Daniel On 13 December 2011 20:43, Amit Daniel Kachhap wr

Re: linaro powertop doesn't work well on a single core ARM SoC

2011-12-12 Thread Amit Kachhap
Hi Barry, You fix for invalid cpu id looks fine. As for the P states this new powertop combines with the cpuidle numbers. so if the system is highly idle it means processor is idle and hence P states is shown as 0. Thanks, Amit Daniel On 12 December 2011 15:55, Barry Song <21cn...@gmail.com> wr

Re: [PATCH 1/4] ARM: exynos4: Add support for AFTR mode cpuidle state

2011-11-17 Thread Amit Kachhap
On 11 November 2011 13:03, MyungJoo Ham wrote: > On Sat, Nov 5, 2011 at 2:03 AM,   wrote: >> From: Amit Daniel Kachhap >> >> This patch adds support for AFTR(ARM OFF TOP RUNNING) mode in >> cpuidle driver for EXYNOS4210. L2 cache keeps their data in this mode. >> This patch ports the code to the

Re: Freeze date for the Linaro 11.11 kernel release

2011-11-11 Thread Amit Kachhap
Hi Nicolas, Please pull the samsung cpuidle code from, (git://git.linaro.org/people/amitdanielk/linux.git branch: samsung_cpuidle_l2_retention). The above branch is rebased on top of your tree and contains some necessary patches already in mainline. All these patches are submitted and under re

Re: [PATCH 4/4] ARM: exynos4: remove useless code to save/restore L2 and GIC state

2011-11-10 Thread Amit Kachhap
On 4 November 2011 23:03, Sylwester Nawrocki wrote: > On 11/04/2011 06:03 PM, amit.kach...@linaro.org wrote: >> From: Amit Daniel Kachhap >> >> Following the merge of CPU PM notifiers and L2 resume code, this patch >> removes useless code to save and restore L2 and GIC registers. >> >> This is no

[PATCH 4/4] ARM: exynos4: remove useless code to save/restore L2 and GIC state

2011-11-04 Thread amit . kachhap
From: Amit Daniel Kachhap Following the merge of CPU PM notifiers and L2 resume code, this patch removes useless code to save and restore L2 and GIC registers. This is now automatically covered by suspend calls which integrated CPU PM notifiers and new sleep code that allows to resume L2 before

[PATCH 3/4] ARM: exynos4: add L2 early resume code

2011-11-04 Thread amit . kachhap
From: Amit Daniel Kachhap This patch adds code to save L2 register configuration at boot, and to resume L2 before MMU is enabled in suspend and cpuidle resume paths. Signed-off-by: Lorenzo Pieralisi Signed-off-by: Amit Daniel Kachhap --- arch/arm/mach-exynos4/cpu.c | 43 ++

[PATCH 1/4] ARM: exynos4: Add support for AFTR mode cpuidle state

2011-11-04 Thread amit . kachhap
From: Amit Daniel Kachhap This patch adds support for AFTR(ARM OFF TOP RUNNING) mode in cpuidle driver for EXYNOS4210. L2 cache keeps their data in this mode. This patch ports the code to the latest interfaces to save/restore CPU state inclusive of CPU PM notifiers, l2 resume and cpu_suspend/resu

[PATCH 2/4] ARM: exynos4: remove useless churn in sleep.S

2011-11-04 Thread amit . kachhap
From: Lorenzo Pieralisi This patch cleans up sleep code in preparation for L2 resume code and hotplug functions Signed-off-by: Lorenzo Pieralisi --- arch/arm/mach-exynos4/sleep.S |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-exynos4/sleep.S b/arch/arm

[PATCH 0/4]ARM: exynos4: Add l2 retention mode cpuidle state

2011-11-04 Thread amit . kachhap
From: Amit Daniel Kachhap This Patch series adds support for AFTR mode cpuidle state based on patch (http://www.spinics.net/lists/arm-kernel/msg132243.html) earlier submitted by Jaecheol Lee . This patch uses CPU PM notifiers , common l2 save/restore and new cpu_suspend/resume interfaces and i

Re: [RFC PATCH 1/4] ARM: Exynos4: Add thermal sensor driver for samsung exynos4 platform.

2011-10-31 Thread Amit Kachhap
On 27 October 2011 04:08, Kyungmin Park wrote: > Hi, > > exynos4 tmu is already merged 3.2-rc > you can find it at below message and latest git kernel > http://www.spinics.net/lists/lm-sensors/msg33872.html > > Thank you, > Kyungmin Park ok I will rebase my work on top of sensor Thanks for pointi

Re: samsung cpuidle pull request.

2011-10-21 Thread Amit Kachhap
/exynos4.h |1 + Thanks, Amit Daniel On 21 October 2011 02:19, Nicolas Pitre wrote: > On Thu, 20 Oct 2011, Amit Kachhap wrote: > >> Hi Nicolas, >> >> This is a request to pull L2 retention cpuidle implementation from >> git://git.linaro.org/people

Re: samsung cpuidle pull request.

2011-10-20 Thread Amit Kachhap
October 2011 14:33, Amit Kachhap wrote: > Hi Nicolas, > > This is a request to pull L2 retention cpuidle implementation from > git://git.linaro.org/people/amitdanielk/linux.git (branch- > samsung_cpuidle_l2_retention) > > The top 5 patches on this refers to the work and this

samsung cpuidle pull request.

2011-10-20 Thread Amit Kachhap
Hi Nicolas, This is a request to pull L2 retention cpuidle implementation from git://git.linaro.org/people/amitdanielk/linux.git (branch- samsung_cpuidle_l2_retention) The top 5 patches on this refers to the work and this is heavily based on Russell's rmk-next tree. So if it is possible to take t

Re: [RFC PATCH 2/4] ARM: EXYNOS4: Fix to work with origen boards.

2011-08-22 Thread Amit Kachhap
On 19 August 2011 19:29, Kyungmin Park wrote: > On Fri, Aug 19, 2011 at 10:09 PM, Amit Daniel Kachhap > wrote: >> This adds a function to get the revision id. >> >> Signed-off-by: Jaecheol Lee >> Signed-off-by: Changhwan Youn >> --- >>  arch/arm/mach-exynos4/cpu.c              |   10 ++

Re: [RFC PATCH 3/4] ARM: EXYNOS4: Add support AFTR mode cpuidle state on EXYNOS4210

2011-08-22 Thread Amit Kachhap
On 21 August 2011 22:48, Russell King - ARM Linux wrote: > On Fri, Aug 19, 2011 at 06:39:59PM +0530, Amit Daniel Kachhap wrote: >> +ENTRY(exynos4_enter_lp) >> +     stmfd   sp!, { r3 - r12, lr } >> + >> +     adr     r0, sleep_save_misc >> + >> +     mrc     p15, 0, r2, c15, c0, 0  @ read power co

Re: [RFC PATCH 06/17] ARM: kernel: save/restore generic infrastructure

2011-07-28 Thread Amit Kachhap
On 7 July 2011 21:20, Lorenzo Pieralisi wrote: > > This patch provides the code infrastructure needed to maintain > a generic per-cpu architecture implementation of idle code. > > sr_platform.c : >        - code manages patchset initialization and memory management > > sr_context.c: >        - cod

Re: [RFC PATCH 17/17] ARM: kernel: save/restore build infrastructure

2011-07-26 Thread Amit Kachhap
On 7 July 2011 21:20, Lorenzo Pieralisi wrote: > This patch adds the required Kconfig and Makefile entries to > enable and compile common idle code for ARM kernel. > > Common idle code depends on CPU_PM platform notifiers to trigger > save/restore of kernel subsystems like PMU, VFP, GIC. > > Signe

Re: [PATCH 3/3] powertop: ncurses: Enable ncurses for android and miscellaneous changes

2011-07-18 Thread Amit Kachhap
On 15 July 2011 23:05, Kok, Auke-jan H wrote: > On Thu, Jul 14, 2011 at 11:35 PM, Amit Daniel Kachhap > wrote: >> This patch enables ncurses for android. NCURSES_NOMACRO flag is enabled >> as there is some conflict with stl libraries. >> >> Signed-off-by:  Amit Daniel Kachhap >> --- >>  Android.

Re: [PATCH 1/3] powertop: Disable pci bus measurement for arm platforms

2011-07-18 Thread Amit Kachhap
On 15 July 2011 22:56, Kok, Auke-jan H wrote: > On Thu, Jul 14, 2011 at 11:35 PM, Amit Daniel Kachhap > wrote: >> This patch disables pci related measurement which is not needed >> for ARM platforms and also library libpci is not needed. >> >> Signed-off-by:  Amit Daniel Kachhap >> --- >>  Andro

Re: [PATCH powertop2.0] Modification to fix the removal of lock_depth field

2011-06-22 Thread Amit Kachhap
On 23 June 2011 10:41, Arjan van de Ven wrote: > On 6/22/2011 10:12 PM, Amit Daniel Kachhap wrote: >> >> lock_depth field is removed from the power frequency events in the >> new linux kernel(2.6.38 onwards). So this creates issue to retrieve >> the lower members of the trace data. To fix this pro

Re: [RFC] Add Arm cpu topology definition

2011-06-16 Thread Amit Kachhap
I have some doubts about the bit fields of the MPIDR register. Comments added below. On 16 June 2011 14:19, Vincent Guittot wrote: > The affinity between Arm processors is defined in the MPIDR register. > We can identify which processors are in the same cluster, > and which ones have performance i

[PATCH 1/2] Modified Powertop to support ARM processor

2011-04-18 Thread amit . kachhap
From: Amit Daniel Kachhap Added a compulsory field bogomips for each processor in case other fields like model is missing. Error handling code added in case of package id remains uninitialised. Signed-off-by: Amit Daniel Kachhap --- cpu/cpu.cpp |6 ++ 1 files changed, 6 insertions(+),

[PATCH 0/2] Modified Powertop2.0 to support ARM processor

2011-04-18 Thread amit . kachhap
The following set of patches modify the powertop version 2.0 to work for ARM platform. The C states and P states was measured after doing these changes in powertop. Amit Daniel Kachhap (2): Modified Powertop to support ARM processor Added an arm compiler flag cpu/cpu.cpp |8 +++- 1

[PATCH 2/2] Added an arm compiler flag

2011-04-18 Thread amit . kachhap
From: Amit Daniel Kachhap Modified to extract correct elements of power_entry structure. Signed-off-by: Amit Daniel Kachhap --- cpu/cpu.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cpu/cpu.cpp b/cpu/cpu.cpp index 451c120..f9995be 100644 --- a/cpu/cpu.cpp +++ b

Re: Samsung: CPUIDLE Support

2011-04-12 Thread Amit Kachhap
CONFIG_PM_OPS=y CONFIG_ARCH_SUSPEND_POSSIBLE=y Regards, Amit Daniel On 12 April 2011 10:54, John Rigby wrote: > On Tue, Apr 12, 2011 at 2:39 AM, Amit Kachhap > wrote: > > Hi John, > > > > Following macros can be enabled, > > CONFIG_CPU_IDLE, > > CONFIG_PM, >

Re: Samsung: CPUIDLE Support

2011-04-12 Thread Amit Kachhap
wrote: > > On Mon, 11 Apr 2011, Amit Kachhap wrote: > > > >> Hi Nicolas, > >> > >> I could not find this changes in the latest 2.6.38 Linaro kernel. Please > >> merge the patch from the below > >> mentioned samsung maintainers next link a

Samsung: CPUIDLE Support

2011-04-10 Thread Amit Kachhap
Hi Nicolas, I could not find this changes in the latest 2.6.38 Linaro kernel. Please merge the patch from the below mentioned samsung maintainers next link as this is required for the PM Linaro release. Thanks, Amit Daniel On 5 April 2011 01:36, Amit Kachhap wrote: > Hi Nicolas, > &g

Re: [PATCH V1] ARM: Samsung: Basic CPUIDLE Support

2011-04-04 Thread Amit Kachhap
Hi Nicolas, Please take this cpuidle commit from the samsung tree needed for Linaro new rebuilt tree. http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;a=commit;h=df7bf189d23ecd1c211c273de462b93d9e3e1fef Thanks, Amit Daniel On 18 March 2011 08:51, Amit Daniel Kachhap wrote:

Re: [PATCH] ARM: Samsung: Basic CPUIDLE Support

2011-03-14 Thread Amit Kachhap
Hi nicolas, Can you merge this patch for adding basic cpuidle support? This may be needed for the current linaro release cycle. Regards, Amit Daniel On 10 March 2011 10:41, Amit Daniel Kachhap wrote: > This patch supports cpuidle framework for samsung S5PV310. Currently, > Only one idle state is

Re: [PATCH] CPUFREQ : calculate delay after dbs_check_cpu

2011-02-21 Thread Amit Kachhap
Hi Vincent, I checked this patch and I can see some performance improvement in my arm platform also. So in your patch there are 2 changes. First one is for calculating delay after rate_mult is set, this can be tested with cpufreq-bench tool. For the second part which requires enabling power save b

Re: [PATCH] ARM: SAMSUNG: Removing dependency on CONFIG_PM_DEBUG for clock debugging

2011-02-11 Thread Amit Kachhap
yes this is a temporary patch untill all the PM components(sleep/resume) are mainlined. The exact compilation error is, CC arch/arm/plat-samsung/pm.o arch/arm/plat-samsung/pm.c:32: fatal error: mach/pm-core.h: No such file or directory compilation terminated. make[1]: *** [arch/arm/plat-sams