On 26 October 2012 12:39, hongbo.zhang hongbo.zh...@linaro.org wrote:
From: hongbo.zhang hongbo.zh...@linaro.com
Problem of using this list is that the cpufreq_get_max_state callback will be
called when register cooling device by thermal_cooling_device_register, but
this list isn't ready at
On 24 October 2012 17:28, hongbo.zhang hongbo.zh...@linaro.org wrote:
From: hongbo.zhang hongbo.zh...@linaro.com
The cpufreq works as a cooling device, so the cooling layer should check if
the
cpufreq driver is initialized or not.
Signed-off-by: hongbo.zhang hongbo.zh...@linaro.com
---
On 24 October 2012 19:04, Viresh Kumar viresh.ku...@linaro.org wrote:
On 24 October 2012 17:28, hongbo.zhang hongbo.zh...@linaro.org wrote:
From: hongbo.zhang hongbo.zh...@linaro.com
In the while loop for counting cpu frequencies, if table[i].frequency equals
CPUFREQ_ENTRY_INVALID, index i
On Fri, Jul 13, 2012 at 3:39 PM, Hongbo Zhang hongbo.zh...@linaro.org wrote:
On 12 May 2012 17:40, Amit Daniel Kachhap amit.kach...@linaro.org wrote:
This patch adds support for generic cpu thermal cooling low level
implementations using frequency scaling up/down based on the registration
On Tue, Jul 10, 2012 at 12:31 PM, Hongbo Zhang hongbo.zh...@linaro.org wrote:
On 12 May 2012 17:40, Amit Daniel Kachhap amit.kach...@linaro.org wrote:
This patch adds support for generic cpu thermal cooling low level
implementations using frequency scaling up/down based on the registration
On 9 May 2012 01:46, Andrew Morton a...@linux-foundation.org wrote:
On Tue, 8 May 2012 21:48:14 +0530
Amit Daniel Kachhap amit.kach...@linaro.org wrote:
This patch adds support for generic cpu thermal cooling low level
implementations using frequency scaling up/down based on the registration
On 9 May 2012 01:36, Zhang, Rui rui.zh...@intel.com wrote:
Hi, Amit,
Sorry for the late response as I'm in a travel recently.
I think the generic cpufreq cooling patches are good.
But about the THERMAL_TRIP_STATE_INSTANCE patch, what I'd like to see is that
1. from thermal zone point of
On 16 April 2012 07:37, Zhang Rui rui.zh...@intel.com wrote:
On 三, 2012-04-11 at 18:17 +0530, Amit Kachhap wrote:
Hi Rui,
Thanks for looking into the patches.
On 10 April 2012 06:28, Zhang Rui rui.zh...@intel.com wrote:
Hi, Amit,
On 三, 2012-04-04 at 10:02 +0530, Amit Kachhap wrote
Hi Rui,
Thanks for looking into the patches.
On 10 April 2012 06:28, Zhang Rui rui.zh...@intel.com wrote:
Hi, Amit,
On 三, 2012-04-04 at 10:02 +0530, Amit Kachhap wrote:
Hi Len/Rui,
Any comment or feedback from your side about the status of this patch?
Is it merge-able or major re-work
On 21 March 2012 19:43, Jean Delvare kh...@linux-fr.org wrote:
On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote:
Basically without this patch changing the mode of thermal zone
is not possible as wrong string size is passed to strncmp.
Actually it is possible,
$ echo -n disabled
On 19 March 2012 17:15, Srivatsa S. Bhat
srivatsa.b...@linux.vnet.ibm.com wrote:
On 03/19/2012 11:47 AM, Amit Daniel Kachhap wrote:
This patch adds support for generic cpu thermal cooling low level
implementations using cpuhotplug based on the thermal level requested
from user. Different cpu
On 13 March 2012 15:44, Sundar sunder.s...@gmail.com wrote:
On Tue, Mar 13, 2012 at 3:30 PM, Amit Kucheria amit.kuche...@linaro.org
wrote:
Sundar,
Hi Amit,
At the moment it doesn't. But there was some discussion around
creating something that will work with devfreq. This would allow
Hi Durgadoss,
Thanks for the detailed review.
On 12 March 2012 16:21, R, Durgadoss durgados...@intel.com wrote:
Hi Amit,
Thanks for keeping this up. And Sorry for late reply.
-Original Message-
From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel
Kachhap
On 13 March 2012 09:24, Tushar Behera tushar.beh...@linaro.org wrote:
On 03/03/2012 04:36 PM, Amit Daniel Kachhap wrote:
This codes uses the generic linux thermal layer and creates a bridge
between temperature sensors, linux thermal framework and cooling devices
for samsung exynos platform.
On 11 March 2012 09:41, Sundar sunder.s...@gmail.com wrote:
Hi Amit,
I am new here; so please bear with my questions/doubts :)
On Wed, Feb 22, 2012 at 3:44 PM, Amit Daniel Kachhap
amit.kach...@linaro.org wrote:
This patch adds support for generic cpu thermal cooling low level
On 3 March 2012 17:51, Sylwester Nawrocki snj...@gmail.com wrote:
On 03/03/2012 12:06 PM, Amit Daniel Kachhap wrote:
This movement is needed because the hwmon entries and corresponding
sysfs interface is a duplicate of utilities already provided by
driver/thermal/thermal_sys.c. The goal is to
On 3 March 2012 23:34, Guenter Roeck guenter.ro...@ericsson.com wrote:
On Sat, Mar 03, 2012 at 11:44:10AM -0500, Mark Brown wrote:
On Sat, Mar 03, 2012 at 04:36:05PM +0530, Amit Daniel Kachhap wrote:
This movement is needed because the hwmon entries and corresponding
sysfs interface is a
Hi,
I verified this patch on exynos4 based origen board.
Tested-by: Amit Daniel amit.kach...@linaro.org
Thanks,
Amit D
On 29 February 2012 08:41, Robert Lee rob@linaro.org wrote:
Enable core cpuidle timekeeping and irq enabling and remove that
handling from this code.
Signed-off-by:
Hi Durgadoss,
Thanks for the detailed review comments.
On 24 February 2012 16:34, R, Durgadoss durgados...@intel.com wrote:
Hi Amit,
-Original Message-
From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel
Kachhap
Sent: Wednesday, February 22, 2012 3:44 PM
On 23 February 2012 12:16, R, Durgadoss durgados...@intel.com wrote:
Hi Amit,
-Original Message-
From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel
Kachhap
Sent: Wednesday, February 22, 2012 3:44 PM
To: linux...@lists.linux-foundation.org
Cc: linux-ker
On 21 February 2012 16:37, Kukjin Kim kgene@samsung.com wrote:
Amit Kachhap wrote:
Hi kukjin Kim,
Hi,
I was on travel for elc and linaro conferences so little late for
replying. Thanks for testing these patches.
I just submitted the V6 series of the cpuidle patchset. I rebased
and they are working fine.
Some modification was done for CHECK_FLAG.
Thanks,
Amit Daniel
On 18 February 2012 07:29, Kukjin Kim kgene@samsung.com wrote:
Amit Kachhap wrote:
Hi Amit Kucheria,
Hi all,
(Cc'ed Jaecheol Lee and Jongpill Lee)
I have asked the samsung maintainer(Kukjin Kim
Hi Amit Kucheria,
I have asked the samsung maintainer(Kukjin Kim) to queue this patch
set 1 month back. But seems like it is not present.
Hi Mr Kim,
Can you please queue this patchset in your tree for next merge window?
The V5 version submitted fixes all the known issues.
Hi Andrey,
Please pull my latest thermal changes from
git://git.linaro.org/people/amitdanielk/linux.gitexynos_thermal_latest
The configs option which needed to be turn on is defined below,
https://wiki.linaro.org/WorkingGroups/PowerManagement/Doc/Kconfig#Arch-independent-1
Hi eduardo,
Thanks for the detail review.
On 6 February 2012 23:09, Eduardo Valentin eduardo.valen...@ti.com wrote:
Hello Amit,
some comments embedded.
On Wed, Jan 18, 2012 at 02:51:07PM +0530, Amit Daniel Kachhap wrote:
Add a sysfs node code to report effective cooling of all cooling
Hi eduardo,
Again thanks for the review.
On 7 February 2012 00:25, Eduardo Valentin eduardo.valen...@ti.com wrote:
Hello Amit,
On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote:
This patch adds support for generic cpu thermal cooling low level
implementations using
On 3 February 2012 12:42, Zhang Rui rui.zh...@intel.com wrote:
Hi, sorry for the late response.
On 四, 2012-01-19 at 14:47 +0530, Amit Kachhap wrote:
On 13 December 2011 20:43, Amit Daniel Kachhap amit.kach...@linaro.org
wrote:
PATCH 1) [thermal: Add a new trip type to use cooling device
On 1 February 2012 20:27, Matthew Garrett m...@redhat.com wrote:
On Tue, Dec 13, 2011 at 08:43:16PM +0530, Amit Daniel Kachhap wrote:
This patch adds support for generic cpu thermal cooling low level
implementations using frequency scaling and cpuhotplugg currently.
We've been over this kind
On 1 February 2012 20:19, Matthew Garrett m...@redhat.com wrote:
I'm not really a fan of this as it stands - the name isn't very
intuitive and the code's pretty difficult to read. Would the following
(incomplete and obviously untested) not have the effect you want? Then
you register multiple
On 1 February 2012 20:19, Matthew Garrett m...@redhat.com wrote:
I'm not really a fan of this as it stands - the name isn't very
intuitive and the code's pretty difficult to read. Would the following
(incomplete and obviously untested) not have the effect you want? Then
you register multiple
On 13 December 2011 20:43, Amit Daniel Kachhap amit.kach...@linaro.org wrote:
PATCH 1) [thermal: Add a new trip type to use cooling device instance number]
This patch adds a new trip type THERMAL_TRIP_STATE_ACTIVE which passes
cooling device instance number and may be helpful for cpufreq
Hi Chanwoo Choi,
I remember I found some of those issues when making cross-compiled
static powertop binaries due to incompatible ncurses database files.
Then I moved to native compilation of powertop binaries for ARM
boards. May be this will give you some pointers.
Anyway I will test with new
On 11 January 2012 13:32, Rob Lee rob@linaro.org wrote:
Hey Amit, I was able to use your code on an i.MX6Q thermal
implementation and it seemed to work pretty well. Thanks for adding
this. A couple of comments below.
Thanks for testing and reviewing the code.
On Tue, Dec 13, 2011 at
STATE_ACTIVE trip point with its corresponding cooling data.
BR,
Rob
On Tue, Dec 20, 2011 at 11:11 PM, Amit Kachhap amit.kach...@linaro.org
wrote:
Hi Vincent,
Thanks for the review.
Well actually your are correct that current temperature and last
temperature can be used to increase
to
https://wiki.linaro.org/WorkingGroups/PowerManagement/Doc/Kconfig
under Exynos-Thermal?
Zach and Ricardo will then ensure that their kernels have those
Kconfig options enabled.
/Amit
On Wed, Dec 14, 2011 at 6:54 PM, Amit Kachhap amit.kach...@linaro.org
wrote:
Hi Nicolas,
Please
Hi Guenter,
The main idea of this work is to leave the current userspace based
notification scheme and add the kernel based cooling scheme on top of
it. Anyway, It is a good idea to move the file hwmon/exynos4_tmu.c as
this creates 2 hwmon entries.
Adding CC: Donggeun Kim to know his opinion.
On 3 January 2012 18:52, Kukjin Kim kgene@samsung.com wrote:
amit kachhap wrote:
Hi Mr kim,
All the comments have been addressed for the Exynos cpu idle patchset.
The updated patchset was posted about one month back and there have
been no further comments on the patchset since
Hi Mr kim,
All the comments have been addressed for the Exynos cpu idle patchset.
The updated patchset was posted about one month back and there have
been no further comments on the patchset since then.
As this patchset seems to be stable now, do you think these these
patches can merged in this
Hi Vincent,
Thanks for the review.
Well actually your are correct that current temperature and last
temperature can be used to increase or decrease the cufreq. But this has to
be done again in cooling devices so to make the cooling devices generic and
to avoid the temperature comparision again
Hi Vincent,
Thanks for the review.
Well actually your are correct that current temperature and last
temperature can be used to increase or decrease the cpu frequency. But
this has to be done again in cooling devices so to make the cooling
devices generic and to avoid the temperature comparison
Hi Nicolas,
Is it possible for you to add these 2 patches for this month release? I am
not able to give you the git link as there is seems some problem with the
linaro git server.
Also I attached the patches in case required.
Thanks,
Amit Daniel
On 13 December 2011 20:43, Amit Daniel Kachhap
are added since commit id
971be11492b1e248798f7078592b1fa0dfbf3534
Thanks,
Amit Daniel
On 14 December 2011 20:11, Amit Kachhap amit.kach...@linaro.org wrote:
Hi Nicolas,
Is it possible for you to add these 2 patches for this month release? I am
not able to give you the git link as there is seems
Hi Barry,
You fix for invalid cpu id looks fine. As for the P states this new
powertop combines with the cpuidle numbers. so if the system is highly
idle it means processor is idle and hence P states is shown as 0.
Thanks,
Amit Daniel
On 12 December 2011 15:55, Barry Song 21cn...@gmail.com
On 11 November 2011 13:03, MyungJoo Ham myungjoo@gmail.com wrote:
On Sat, Nov 5, 2011 at 2:03 AM, amit.kach...@linaro.org wrote:
From: Amit Daniel Kachhap amit.kach...@linaro.org
This patch adds support for AFTR(ARM OFF TOP RUNNING) mode in
cpuidle driver for EXYNOS4210. L2 cache keeps
Hi Nicolas,
Please pull the samsung cpuidle code from,
(git://git.linaro.org/people/amitdanielk/linux.git branch:
samsung_cpuidle_l2_retention).
The above branch is rebased on top of your tree and contains some
necessary patches already in mainline.
All these patches are submitted and under
On 4 November 2011 23:03, Sylwester Nawrocki s.nawro...@samsung.com wrote:
On 11/04/2011 06:03 PM, amit.kach...@linaro.org wrote:
From: Amit Daniel Kachhap amit.kach...@linaro.org
Following the merge of CPU PM notifiers and L2 resume code, this patch
removes useless code to save and restore
On 27 October 2011 04:08, Kyungmin Park kmp...@infradead.org wrote:
Hi,
exynos4 tmu is already merged 3.2-rc
you can find it at below message and latest git kernel
http://www.spinics.net/lists/lm-sensors/msg33872.html
Thank you,
Kyungmin Park
ok I will rebase my work on top of sensor
/exynos4.h |1 +
Thanks,
Amit Daniel
On 21 October 2011 02:19, Nicolas Pitre nicolas.pi...@linaro.org wrote:
On Thu, 20 Oct 2011, Amit Kachhap wrote:
Hi Nicolas,
This is a request to pull L2 retention cpuidle implementation from
git://git.linaro.org/people/amitdanielk/linux.git (branch
On 19 August 2011 19:29, Kyungmin Park kmp...@infradead.org wrote:
On Fri, Aug 19, 2011 at 10:09 PM, Amit Daniel Kachhap
amit.kach...@linaro.org wrote:
This adds a function to get the revision id.
Signed-off-by: Jaecheol Lee jc@samsung.com
Signed-off-by: Changhwan Youn
On 7 July 2011 21:20, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote:
This patch provides the code infrastructure needed to maintain
a generic per-cpu architecture implementation of idle code.
sr_platform.c :
- code manages patchset initialization and memory management
On 7 July 2011 21:20, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote:
This patch adds the required Kconfig and Makefile entries to
enable and compile common idle code for ARM kernel.
Common idle code depends on CPU_PM platform notifiers to trigger
save/restore of kernel subsystems like
On 15 July 2011 22:56, Kok, Auke-jan H auke-jan.h@intel.com wrote:
On Thu, Jul 14, 2011 at 11:35 PM, Amit Daniel Kachhap
amit.kach...@linaro.org wrote:
This patch disables pci related measurement which is not needed
for ARM platforms and also library libpci is not needed.
Signed-off-by:
On 15 July 2011 23:05, Kok, Auke-jan H auke-jan.h@intel.com wrote:
On Thu, Jul 14, 2011 at 11:35 PM, Amit Daniel Kachhap
amit.kach...@linaro.org wrote:
This patch enables ncurses for android. NCURSES_NOMACRO flag is enabled
as there is some conflict with stl libraries.
Signed-off-by:
On 23 June 2011 10:41, Arjan van de Ven ar...@linux.intel.com wrote:
On 6/22/2011 10:12 PM, Amit Daniel Kachhap wrote:
lock_depth field is removed from the power frequency events in the
new linux kernel(2.6.38 onwards). So this creates issue to retrieve
the lower members of the trace data. To
I have some doubts about the bit fields of the MPIDR register.
Comments added below.
On 16 June 2011 14:19, Vincent Guittot vincent.guit...@linaro.org wrote:
The affinity between Arm processors is defined in the MPIDR register.
We can identify which processors are in the same cluster,
and which
From: Amit Daniel Kachhap amit.kach...@linaro.org
Modified to extract correct elements of power_entry structure.
Signed-off-by: Amit Daniel Kachhap amit.kach...@linaro.org
---
cpu/cpu.cpp |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/cpu/cpu.cpp b/cpu/cpu.cpp
index
From: Amit Daniel Kachhap amit.kach...@linaro.org
Added a compulsory field bogomips for each processor in case other
fields like model is missing. Error handling code added in case
of package id remains uninitialised.
Signed-off-by: Amit Daniel Kachhap amit.kach...@linaro.org
---
cpu/cpu.cpp |
The following set of patches modify the powertop version 2.0 to work
for ARM platform. The C states and P states was measured after doing
these changes in powertop.
Amit Daniel Kachhap (2):
Modified Powertop to support ARM processor
Added an arm compiler flag
cpu/cpu.cpp |8 +++-
1
CONFIG_PM_OPS=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
Regards,
Amit Daniel
On 12 April 2011 10:54, John Rigby john.ri...@linaro.org wrote:
On Tue, Apr 12, 2011 at 2:39 AM, Amit Kachhap amit.kach...@linaro.org
wrote:
Hi John,
Following macros can be enabled,
CONFIG_CPU_IDLE,
CONFIG_PM
Hi Nicolas,
Please take this cpuidle commit from the samsung tree needed for Linaro new
rebuilt tree.
http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;a=commit;h=df7bf189d23ecd1c211c273de462b93d9e3e1fef
Thanks,
Amit Daniel
On 18 March 2011 08:51, Amit Daniel Kachhap
Hi nicolas,
Can you merge this patch for adding basic cpuidle support? This may be
needed
for the current linaro release cycle.
Regards,
Amit Daniel
On 10 March 2011 10:41, Amit Daniel Kachhap amit.kach...@linaro.org wrote:
This patch supports cpuidle framework for samsung S5PV310. Currently,
Hi Vincent,
I checked this patch and I can see some performance improvement in my
arm platform also. So in your patch there are 2 changes. First one is
for calculating delay after rate_mult is set, this can be tested with
cpufreq-bench tool. For the second part which requires enabling power
save
62 matches
Mail list logo
