Re: [PATCH 5/5][RFC] cpuidle : add cpuidle_register_states function

2012-07-26 Thread Deepthi Dharwar
ction overrides this pointer. > May be add some more explanation and pointers to previous discussions, as stated on the cover in the patch series. > Signed-off-by: Daniel Lezcano Acked-by: Deepthi Dharwar > --- > drivers/cpuidle/cpuidle.c | 17 + > in

Re: [PATCH 1/5] acpi : move the acpi_idle_driver variable declaration

2012-07-26 Thread Deepthi Dharwar
Hi Daniel, On 07/25/2012 04:15 PM, Daniel Lezcano wrote: > This variable is only used in the in processor_driver.c. > This patch reduces the scope of the variable by moving it > to this file. > This is true after applying your second patch . Maybe you can check the sequencing of patches in the

Re: cpuidle future and improvements

2012-06-18 Thread Deepthi Dharwar
On 06/18/2012 02:10 PM, Daniel Lezcano wrote: > > Dear all, > > A few weeks ago, Peter De Schrijver proposed a patch [1] to allow per > cpu latencies. We had a discussion about this patchset because it > reverse the modifications Deepthi did some months ago [2] and we may > want to provide a dif

Re: [linux-pm] [RFC 1/4] cpuidle: define the enter function in the driver structure

2012-06-08 Thread Deepthi Dharwar
Hi Daniel, On 06/08/2012 09:32 PM, Daniel Lezcano wrote: > We have the state index passed as parameter to the 'enter' function. > Most of the drivers assign their 'enter' functions several times in > the cpuidle_state structure, as we have the index, we can delegate > to the driver to handle thei

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Deepthi Dharwar
On 03/21/2012 05:31 AM, Rafael J. Wysocki wrote: > On Wednesday, March 21, 2012, Amit Kucheria wrote: >> On Wed, Mar 21, 2012 at 12:48 AM, Kevin Hilman wrote: >>> Arnd Bergmann writes: >>> On Tuesday 20 March 2012, Robert Lee wrote: > This patch series moves various functionality duplic

Re: [PATCH v7 1/9] cpuidle: Add common time keeping and irq enabling

2012-03-01 Thread Deepthi Dharwar
oid cpuidle_resume_and_unlock(void); > extern int cpuidle_enable_device(struct cpuidle_device *dev); > extern void cpuidle_disable_device(struct cpuidle_device *dev); > - > +extern int cpuidle_wrap_enter(struct cpuidle_device *dev, > + struct cpuidle_driver *drv, int index,

Re: [PATCH v6 1/9] cpuidle: Add common time keeping and irq enabling

2012-02-29 Thread Deepthi Dharwar
Hi Rob, On 02/29/2012 08:41 AM, Robert Lee wrote: > Make necessary changes to implement time keeping and irq enabling > in the core cpuidle code. This will allow the removal of these > functionalities from various platform cpuidle implementations whose > timekeeping and irq enabling follows the