Re: [PATCH 5/5] clk: add a fixed factor clock

2012-05-07 Thread Saravana Kannan
On 05/07/2012 01:14 PM, Turquette, Mike wrote: On Mon, May 7, 2012 at 12:54 PM, Saravana Kannan wrote: On 05/06/2012 10:08 PM, Mike Turquette wrote: From: Sascha Hauer +struct clk *clk_register_fixed_factor(struct device *dev, const char *name, + const char *parent_name

Re: [PATCH 5/5] clk: add a fixed factor clock

2012-05-07 Thread Saravana Kannan
On 05/06/2012 10:08 PM, Mike Turquette wrote: From: Sascha Hauer Having fixed factors/dividers in hardware is a common pattern, so add a basic clock type doing this. It basically describes a fixed factor clock using a nominator and a denominator. Signed-off-by: Sascha Hauer Reviewed-by: Viresh

Re: [PATCH 3/5] clk: remove COMMON_CLK_DISABLE_UNUSED

2012-05-07 Thread Saravana Kannan
On 05/06/2012 10:08 PM, Mike Turquette wrote: Exposing this option generates confusion and incorrect behavior for single-image builds across platforms. Enable this behavior permanently. Signed-off-by: Mike Turquette --- drivers/clk/Kconfig | 11 --- drivers/clk/clk.c |2 --

Re: [PATCH 13/13] clk: basic: improve parent_names & return errors

2012-04-25 Thread Saravana Kannan
On Tue, April 17, 2012 12:17 am, Shawn Guo wrote: > On 17 April 2012 11:50, Turquette, Mike wrote: >> That is a good question.  I think it is worth waiting on Saravana's >> patch which exposes non-private members of struct clk via struct >> clk_hw.  This will have an effect on both platform clock

Re: [PATCH 13/13] clk: basic: improve parent_names & return errors

2012-04-20 Thread Saravana Kannan
On 04/17/2012 12:17 AM, Shawn Guo wrote: On 17 April 2012 11:50, Turquette, Mike wrote: That is a good question. I think it is worth waiting on Saravana's patch which exposes non-private members of struct clk via struct clk_hw. This will have an effect on both platform clock data and code.

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-29 Thread Saravana Kannan
On 03/28/2012 10:08 AM, Turquette, Mike wrote: On Tue, Mar 27, 2012 at 8:06 PM, Saravana Kannan wrote: snip I think there is still a problem with not being able to differentiate between pre-change recalc and post-change recalc. This applies for any set parent and set rate on a clock that

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-28 Thread Saravana Kannan
On 03/23/2012 04:28 PM, Turquette, Mike wrote: On Fri, Mar 23, 2012 at 4:04 PM, Saravana Kannan wrote: On 03/23/2012 03:32 PM, Turquette, Mike wrote: .recalc_rate serves two purposes: first it recalculates the rate after the rate has changed and you pass in a new parent_rate argument. The

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-23 Thread Saravana Kannan
On 03/23/2012 03:32 PM, Turquette, Mike wrote: On Fri, Mar 23, 2012 at 3:12 PM, Saravana Kannan wrote: On 03/23/2012 02:39 PM, Turquette, Mike wrote: __clk_recalc_rates is called by __clk_reparent which is called by clk_set_parent. __clk_recalc_rates is also called by clk_set_rate. Does

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-23 Thread Saravana Kannan
On 03/23/2012 02:39 PM, Turquette, Mike wrote: On Fri, Mar 23, 2012 at 2:33 PM, Saravana Kannan wrote: On 03/20/2012 08:10 PM, Saravana Kannan wrote: On 03/20/2012 04:53 PM, Turquette, Mike wrote: It does make me wonder if it would be a good idea to pass in the parent rate for .set_parent

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-23 Thread Saravana Kannan
On 03/20/2012 08:10 PM, Saravana Kannan wrote: On 03/20/2012 04:53 PM, Turquette, Mike wrote: It does make me wonder if it would be a good idea to pass in the parent rate for .set_parent, which is analogous to .set_rate in many ways. I need to think a bit more about this. I was thinking

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-23 Thread Saravana Kannan
On 03/23/2012 02:39 PM, Turquette, Mike wrote: On Fri, Mar 23, 2012 at 2:33 PM, Saravana Kannan wrote: On 03/20/2012 08:10 PM, Saravana Kannan wrote: On 03/20/2012 04:53 PM, Turquette, Mike wrote: It does make me wonder if it would be a good idea to pass in the parent rate for .set_parent

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Saravana Kannan
On 03/21/2012 12:44 AM, Paul Walmsley wrote: Hello Saravana, On Tue, 20 Mar 2012, Saravana Kannan wrote: To add a few more thoughts, while I agree with Paul that there is room for improvement in the APIs, I think the difference in opinion comes when we ask the question: "When we event

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Saravana Kannan
On 03/21/2012 12:33 PM, Tony Lindgren wrote: * Mark Brown [120321 12:11]: On Wed, Mar 21, 2012 at 11:38:58AM -0700, Saravana Kannan wrote: So it would be interesting to know more about why you (or anyone else) perceive that the Kconfig changes would be harmful. But the enthusiasm of the

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Saravana Kannan
On 03/21/2012 12:56 PM, Mark Brown wrote: On Wed, Mar 21, 2012 at 12:41:41PM -0700, Saravana Kannan wrote: On 03/21/2012 12:33 PM, Tony Lindgren wrote: * Mark Brown [120321 12:11]: These aren't new APIs, the clock API has been around since forever. I disagree. When I say clock A

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Saravana Kannan
On 03/20/2012 08:15 PM, Nicolas Pitre wrote: On Tue, 20 Mar 2012, Paul Walmsley wrote: We need to indicate in some way that the existing code and API is very likely to change in ways that could involve quite a bit of work for adopters. [...] Anyway. It is okay if we want to have some start

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-21 Thread Saravana Kannan
On 03/20/2012 04:53 PM, Turquette, Mike wrote: On Tue, Mar 20, 2012 at 10:46 AM, Saravana Kannan wrote: On Tue, March 20, 2012 7:02 am, Shawn Guo wrote: On Thu, Mar 15, 2012 at 11:11:19PM -0700, Mike Turquette wrote: ... +struct clk_ops { +int (*prepare)(struct clk_hw *hw

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-21 Thread Saravana Kannan
On Tue, March 20, 2012 7:02 am, Shawn Guo wrote: > On Thu, Mar 15, 2012 at 11:11:19PM -0700, Mike Turquette wrote: > ... >> +struct clk_ops { >> +int (*prepare)(struct clk_hw *hw); >> +void(*unprepare)(struct clk_hw *hw); >> +int (*enable)(struct clk

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-19 Thread Saravana Kannan
On 03/19/2012 11:56 AM, Turquette, Mike wrote: On Fri, Mar 16, 2012 at 8:28 PM, Saravana Kannan wrote: On 03/15/2012 11:11 PM, Mike Turquette wrote: The common clock framework defines a common struct clk useful across most platforms as well as an implementation of the clk api that drivers

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-19 Thread Saravana Kannan
On 03/19/2012 12:33 PM, Turquette, Mike wrote: On Mon, Mar 19, 2012 at 12:13 PM, Saravana Kannan wrote: I saw some responses from you over the weekend but not to mine. So, I assumed you were busy with other stuff and I started working on a patch on top of v7. I only answer trivial emails on

Re: [PATCH v5 3/4] clk: introduce the common clock framework

2012-03-17 Thread Saravana Kannan
On 03/07/2012 01:20 PM, Turquette, Mike wrote: On Tue, Mar 6, 2012 at 11:00 AM, Sascha Hauer wrote: On Mon, Mar 05, 2012 at 12:03:15PM -0800, Turquette, Mike wrote: On Sun, Mar 4, 2012 at 11:38 PM, Sascha Hauer wrote: On Sun, Mar 04, 2012 at 04:12:21PM -0800, Turquette, Mike wrote: I belie

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-17 Thread Saravana Kannan
: Andrew Lunn Reviewed-by: Rob Herring calxeda.com> Cc: Russell King Cc: Jeremy Kerr Cc: Arnd Bergman Cc: Paul Walmsley Cc: Shawn Guo Cc: Sascha Hauer Cc: Richard Zhao Cc: Saravana Kannan Cc: Magnus Damm Cc: Mark Brown Cc: Linus Walleij Cc: Stephen Boyd Cc: Amit Kucheria Cc: Deepak Saxena Cc: Gr

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-17 Thread Saravana Kannan
On 03/16/2012 05:54 PM, Rob Herring wrote: On 03/16/2012 06:47 PM, Sascha Hauer wrote: Hi Paul, On Fri, Mar 16, 2012 at 04:21:17PM -0600, Paul Walmsley wrote: Hi On Fri, 16 Mar 2012, Arnd Bergmann wrote: If the common clock code is to go upstream now, it should be marked as experimental.

Re: [PATCH v4 3/6] clk: introduce the common clock framework

2012-01-15 Thread Saravana Kannan
On 12/17/2011 03:04 AM, Russell King - ARM Linux wrote: On Fri, Dec 16, 2011 at 04:45:48PM -0800, Turquette, Mike wrote: On Wed, Dec 14, 2011 at 5:18 AM, Thomas Gleixner wrote: On Tue, 13 Dec 2011, Mike Turquette wrote: +void __clk_unprepare(struct clk *clk) +{ + if (!clk) + r

Re: [PATCH v4 3/6] clk: introduce the common clock framework

2012-01-15 Thread Saravana Kannan
On 01/13/2012 08:39 PM, Turquette, Mike wrote: On Fri, Jan 13, 2012 at 8:18 PM, Saravana Kannan wrote: On 12/17/2011 03:04 AM, Russell King - ARM Linux wrote: On Fri, Dec 16, 2011 at 04:45:48PM -0800, Turquette, Mike wrote: On Wed, Dec 14, 2011 at 5:18 AM, Thomas Gleixner wrote: On Tue

Re: [PATCH v4 3/6] clk: introduce the common clock framework

2012-01-13 Thread Saravana Kannan
On 01/04/2012 08:07 PM, Turquette, Mike wrote: On Wed, Jan 4, 2012 at 6:11 PM, Rob Herring wrote: On 01/04/2012 07:01 PM, Turquette, Mike wrote: On Wed, Jan 4, 2012 at 6:32 AM, Rob Herring wrote: On 01/03/2012 08:15 PM, Richard Zhao wrote: On Fri, Dec 16, 2011 at 04:45:48PM -0800, Turquette

Re: [PATCH v4 3/6] clk: introduce the common clock framework

2012-01-13 Thread Saravana Kannan
On 01/12/2012 04:48 PM, Rob Herring wrote: On 01/12/2012 06:04 PM, Saravana Kannan wrote: On 01/04/2012 08:07 PM, Turquette, Mike wrote: On Wed, Jan 4, 2012 at 6:11 PM, Rob Herring wrote: On 01/04/2012 07:01 PM, Turquette, Mike wrote: On Wed, Jan 4, 2012 at 6:32 AM, Rob Herring wrote: On 01

Re: [PATCH v3 2/5] Documentation: common clk API

2011-11-23 Thread Saravana Kannan
On 11/21/2011 05:40 PM, Mike Turquette wrote: Provide documentation for the common clk structures and APIs. This code can be found in drivers/clk/ and include/linux/clk.h. Signed-off-by: Mike Turquette --- Documentation/clk.txt | 312 + 1 file

Re: [PATCH v3 3/5] clk: introduce the common clock framework

2011-11-23 Thread Saravana Kannan
On 11/21/2011 05:40 PM, Mike Turquette wrote: diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c new file mode 100644 index 000..12c9994 --- /dev/null +++ b/drivers/clk/clk.c @@ -0,0 +1,538 @@ +/* + * Copyright (C) 2010-2011 Canonical Ltd + * Copyright (C) 2011 Linaro Ltd + * + * This program

Re: [PATCH v3 5/5] clk: export tree topology and clk data via sysfs

2011-11-23 Thread Saravana Kannan
On 11/22/2011 11:13 AM, Greg KH wrote: On Tue, Nov 22, 2011 at 09:57:41AM -0800, Mike Turquette wrote: Ah, comments like this warm my heart. Come on, no abusing the kobject code please, if have problems with how the kernel core works, and it doesn't do things you want it to, then why not change

Re: [PATCH v2 1/7] clk: Add a generic clock infrastructure

2011-10-05 Thread Saravana Kannan
On 09/22/2011 03:26 PM, Mike Turquette wrote: diff --git a/include/linux/clk.h b/include/linux/clk.h index 1d37f42..d6ae10b 100644 --- a/include/linux/clk.h +++ b/include/linux/clk.h +#ifdef CONFIG_GENERIC_CLK + +struct clk_hw { + struct clk *clk; +}; + +/** + * struct clk_hw_ops - Callbac

Re: [PATCH v2 4/7] clk: Add simple gated clock

2011-10-05 Thread Saravana Kannan
On 09/26/2011 04:30 PM, Rob Herring wrote: On 09/26/2011 05:37 PM, Turquette, Mike wrote: On Mon, Sep 26, 2011 at 12:37 PM, Jamie Iles wrote: On Mon, Sep 26, 2011 at 02:10:32PM -0500, Rob Herring wrote: On 09/26/2011 01:40 PM, Jamie Iles wrote: On Mon, Sep 26, 2011 at 01:33:08PM -0500, Rob H