Re: [PATCH 3/3] cpufreq: Don't use cpu removed during cpufreq_driver_unregister

2013-01-03 Thread Srivatsa S. Bhat
) continue; per_cpu(cpufreq_cpu_data, j) = NULL; } } We are assigning NULL without freeing that memory. Regards, Srivatsa S. Bhat Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/cpufreq.c | 8 +++- 1 file changed

Re: [PATCH 3/3] cpufreq: Don't use cpu removed during cpufreq_driver_unregister

2013-01-03 Thread Srivatsa S. Bhat
On 01/04/2013 10:49 AM, Viresh Kumar wrote: On 3 January 2013 19:55, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: I took a quick look at the problem you described above, and the cpufreq code.. If we cannot avoid calling cpufreq_add_dev() from cpufreq_remove_dev(), then I can't

Re: [linux-pm] [PATCH] acpi: intel_idle : break dependency between modules

2012-06-28 Thread Srivatsa S. Bhat
On 06/28/2012 01:04 PM, Thomas Renninger wrote: On Wednesday, June 27, 2012 06:16:33 PM Srivatsa S. Bhat wrote: On 06/27/2012 02:37 PM, Daniel Lezcano wrote: When the system is booted with some cpus offline, the idle driver is not initialized. When a cpu is set online, the acpi code call

Re: [PATCH v2] acpi: intel_idle : break dependency between modules

2012-06-28 Thread Srivatsa S. Bhat
. This patch is intended to remove this dependency by using the notifier of intel_idle. This patch has the benefit of encapsulating the intel_idle driver and remove some exported functions. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Looks good to me. Regards, Srivatsa S. Bhat

Re: [PATCH v2] acpi: intel_idle : break dependency between modules

2012-06-28 Thread Srivatsa S. Bhat
On 06/28/2012 04:57 PM, Daniel Lezcano wrote: On 06/28/2012 01:24 PM, Srivatsa S. Bhat wrote: On 06/28/2012 02:16 PM, Daniel Lezcano wrote: When the system is booted with some cpus offline, the idle driver is not initialized. When a cpu is set online, the acpi code call the intel idle init

Re: [linux-pm] [PATCH] acpi: intel_idle : break dependency between modules

2012-06-27 Thread Srivatsa S. Bhat
on the existing timer related one (because you are handling a dependency here, which might not apply to timers, or even worse, cause unwanted side-effects, if any). I'll take a look at the rest of the patch tomorrow. I think Thomas has already pointed out the rest of the issues. Regards, Srivatsa S

Re: [PATCH][V2] cpuidle : use percpu cpuidle in the core code

2012-04-02 Thread Srivatsa S. Bhat
... + cpuidle_unregister_device(dev); + } + + cpuidle_unregister_driver(drv); + + goto out; +} +EXPORT_SYMBOL_GPL(cpuidle_register); + Regards, Srivatsa S. Bhat ___ linaro-dev mailing list linaro-dev@lists.linaro.org http

Re: [PATCH][V3] cpuidle : use percpu cpuidle in the core code

2012-04-02 Thread Srivatsa S. Bhat
'cpuidle_register_driver' and 'cpuidle_register_device' as low level initialization routines to do some specific operations on the cpuidle devices. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Looks good to me now. Acked-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com Regards, Srivatsa S. Bhat

Re: [linux-pm] [PATCH] cpuidle : use percpu cpuidle in the core code

2012-03-31 Thread Srivatsa S. Bhat
On 03/30/2012 09:48 PM, Daniel Lezcano wrote: On 03/30/2012 01:59 PM, Srivatsa S. Bhat wrote: On 03/30/2012 05:15 PM, Daniel Lezcano wrote: On 03/30/2012 01:25 PM, Srivatsa S. Bhat wrote: On 03/30/2012 04:18 PM, Daniel Lezcano wrote: The usual cpuidle initialization routines

Re: [linux-pm] [PATCH] cpuidle : use percpu cpuidle in the core code

2012-03-30 Thread Srivatsa S. Bhat
(struct cpuidle_driver *drv) {return -ENODEV; } static inline struct cpuidle_driver *cpuidle_get_driver(void) {return NULL; } Regards, Srivatsa S. Bhat ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo

Re: [PATCH V2 3/6] thermal: Add generic cpuhotplug cooling implementation

2012-03-19 Thread Srivatsa S. Bhat
On 03/19/2012 11:47 AM, Amit Daniel Kachhap wrote: This patch adds support for generic cpu thermal cooling low level implementations using cpuhotplug based on the thermal level requested from user. Different cpu related cooling devices can be registered by the user and the binding of these