Re: [patch] reduce namespace polloution from sys/ucontext.h on arm

2011-12-20 Thread peter green
Joseph S. Myers wrote: The most obvious users of these definitions would be (native) GDB and gdbserver - do those still build OK (i.e. include the correct headers to get the definitions they need and not rely on any definitions that were removed) after this patch? I have built the debian gdb

[patch] reduce namespace polloution from sys/ucontext.h on arm

2011-12-19 Thread peter green
On arm linux sys/ucontext.h heavilly polloutes the global namespace firstly by including sys/user.h (which defines among other things a type called "struct user" and secondly by defining symbols and #defines named R? to represent the processor registers. That issue in itself is nothing new but fa

Re: "struct user" conflicts on arm

2011-12-18 Thread peter green
ISO C99 says that WCHAR_MAX must be a constant expression and the above definition is such an expression. Technically the program needs fixing (see below though for the "standards matter but so do users"), there is nothing wrong with a type cast and a constant value e.g. signed -1 converted to u

Re: "struct user" conflicts on arm

2011-12-17 Thread peter green
Ulrich Weigand>Now, glibc also provides a file that defines Ulrich Weigand>layouts of register sets for use with signal handlers as well Ulrich Weigand>as the makecontext/setcontext/getcontext family of routines. Ulrich Weigand> Ulrich Weigand>Usually, those layouts tend to be in fact identical t

Re: "struct user" conflicts on arm

2011-12-17 Thread peter green
Konstantinos Margaritis wrote: Does anyone know what the impact of renaming these to use a REG_ prefix like i386, amd64 and sparc do* would be? at worst the packages that had to be workaround on arm* for this, can have the workaround removed. I have prepared a patch (attatched) that eliminates t