Re: [PATCH 1/2] drivers: create a pin control subsystem v7

2011-09-28 Thread Linus Walleij
On Tue, Sep 27, 2011 at 11:30 AM, Stijn Devriendt wrote: >> +       spin_unlock(&desc->lock); > > Now this is racing with... > (...) > ... this: > >> +       spin_lock(&desc->lock); >> +       desc->mux_requested = true; >> +       strncpy(desc->mux_function, function, sizeof(desc->mux_function));

RE: [PATCH 1/2] drivers: create a pin control subsystem v7

2011-09-27 Thread Stephen Warren
Linus Walleij wrote at Tuesday, September 27, 2011 1:51 AM: > On Wed, Sep 21, 2011 at 9:45 PM, Stephen Warren wrote: > > Linus Walleij wrote at Wednesday, September 21, 2011 3:17 AM: > >> To abstract things the stuff we can do with the group should be > >> something enumerated too. So: > >> > >> p

Re: [PATCH 1/2] drivers: create a pin control subsystem v7

2011-09-27 Thread Stijn Devriendt
> +static int pin_request(struct pinctrl_dev *pctldev, > +                      int pin, const char *function, bool gpio, > +                      struct pinctrl_gpio_range *gpio_range) > +{ > +       struct pin_desc *desc; > +       const struct pinmux_ops *ops = pctldev->desc->pmxops; > +       i

Re: [PATCH 1/2] drivers: create a pin control subsystem v7

2011-09-27 Thread Linus Walleij
On Wed, Sep 21, 2011 at 9:45 PM, Stephen Warren wrote: > Linus Walleij wrote at Wednesday, September 21, 2011 3:17 AM: >> To abstract things the stuff we can do with the group should be >> something enumerated too. So: >> >> pinctrl_config_group(const char *pinctrl_device, const char *group, >> co

Re: [PATCH 1/2] drivers: create a pin control subsystem v7

2011-09-27 Thread Linus Walleij
On Wed, Sep 21, 2011 at 9:45 PM, Stephen Warren wrote: > Linus Walleij wrote at Wednesday, September 21, 2011 3:17 AM: >> >> Great, I'm hunting your Acked-by/Reviewed-by ... > > Very close; I was just holding off until we resolved the discussion on > hog'd non-system mapping table entries, and I f

RE: [PATCH 1/2] drivers: create a pin control subsystem v7

2011-09-21 Thread Stephen Warren
Linus Walleij wrote at Wednesday, September 21, 2011 3:17 AM: > On Tue, Sep 20, 2011 at 11:58 PM, Stephen Warren wrote: > > Linus Walleij wrote at Friday, September 16, 2011 6:13 AM: > >> This creates a subsystem for handling of pin control devices. > >> These are devices that control different as

Re: [PATCH 1/2] drivers: create a pin control subsystem v7

2011-09-21 Thread Linus Walleij
On Tue, Sep 20, 2011 at 11:58 PM, Stephen Warren wrote: > Linus Walleij wrote at Friday, September 16, 2011 6:13 AM: >> This creates a subsystem for handling of pin control devices. >> These are devices that control different aspects of package >> pins. > > I've read through the documentation and

RE: [PATCH 1/2] drivers: create a pin control subsystem v7

2011-09-20 Thread Stephen Warren
Linus Walleij wrote at Friday, September 16, 2011 6:13 AM: > This creates a subsystem for handling of pin control devices. > These are devices that control different aspects of package > pins. I've read through the documentation and header files, but not the .c files, and this looks almost perfect