Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2012-01-18 Thread Grant Likely
On Wed, Jan 18, 2012 at 11:42:28AM +, Mark Brown wrote: > On Wed, Jan 18, 2012 at 11:39:50AM +, Mark Brown wrote: > > > This appears to reintroduce the setting of an exact voltage which I'm > > sure was fixed in previous versions of the patch. > > Erk, sorry - it looks like the device tre

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2012-01-18 Thread Mark Brown
On Wed, Jan 18, 2012 at 11:39:50AM +, Mark Brown wrote: > This appears to reintroduce the setting of an exact voltage which I'm > sure was fixed in previous versions of the patch. Erk, sorry - it looks like the device tree list has quite a bit of lag in moderation and sent out some old patche

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2012-01-18 Thread Mark Brown
On Fri, Dec 16, 2011 at 06:30:59PM +0800, Richard Zhao wrote: > + if (higher && cpu_reg) > + regulator_set_voltage(cpu_reg, > + cpu_volts[index], cpu_volts[index]); > + > + ret = clk_set_rate(cpu_clk, freq); > + if (ret != 0) { > + pr

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-20 Thread Mark Brown
On Fri, Dec 16, 2011 at 06:30:59PM +0800, Richard Zhao wrote: > + > + if (higher && cpu_reg) > + regulator_set_voltage(cpu_reg, > + cpu_volts[index], cpu_volts[index]); This is really bad, you're only supporting the configuration of a specific voltage w

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-19 Thread Stephen Boyd
On 12/18/11 17:03, Richard Zhao wrote: > > Do you have to patch to implement per-cpu udelay? In current code, udelay uses > global loops_per_jiffy. > > We've been carrying forward the timer based udelay patches. They're in the patch tracker as 6873/1, 6874/1, and 6875/1. -- Sent by an employee o

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-18 Thread Richard Zhao
Hi Bryan, On Fri, Dec 16, 2011 at 11:59:02AM -0800, Bryan Huntsman wrote: > On 12/16/2011 02:52 AM, Jamie Iles wrote: > > > >> +static DEFINE_PER_CPU(unsigned long, l_p_j_ref); > >> +static unsigned long l_p_j_ref_freq; > >> + > >> +static struct clk *cpu_clk; > > > > This assumes that all CPU's

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-18 Thread Richard Zhao
On Sat, Dec 17, 2011 at 10:29:29AM +0100, Arnd Bergmann wrote: > On Saturday 17 December 2011 16:00:03 Richard Zhao wrote: > > On Fri, Dec 16, 2011 at 08:32:35AM -0600, Rob Herring wrote: > > > On 12/16/2011 04:30 AM, Richard Zhao wrote: > > > > It support single core and multi-core ARM SoCs. But i

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-17 Thread Arnd Bergmann
On Saturday 17 December 2011 16:00:03 Richard Zhao wrote: > On Fri, Dec 16, 2011 at 08:32:35AM -0600, Rob Herring wrote: > > On 12/16/2011 04:30 AM, Richard Zhao wrote: > > > It support single core and multi-core ARM SoCs. But it assume > > > all cores share the same frequency and voltage. > > > >

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-17 Thread Richard Zhao
On Fri, Dec 16, 2011 at 11:59:02AM -0800, Bryan Huntsman wrote: > On 12/16/2011 02:52 AM, Jamie Iles wrote: > > > >> +static DEFINE_PER_CPU(unsigned long, l_p_j_ref); > >> +static unsigned long l_p_j_ref_freq; > >> + > >> +static struct clk *cpu_clk; > > > > This assumes that all CPU's share the s

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-17 Thread Richard Zhao
On Fri, Dec 16, 2011 at 10:52:29AM +, Jamie Iles wrote: > Hi Richard, > > A couple of questions inline, but otherwise looks nice! Thanks for your review. > > Jamie > > On Fri, Dec 16, 2011 at 06:30:59PM +0800, Richard Zhao wrote: > > It support single core and multi-core ARM SoCs. But it ass

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-17 Thread Richard Zhao
On Fri, Dec 16, 2011 at 08:32:35AM -0600, Rob Herring wrote: > On 12/16/2011 04:30 AM, Richard Zhao wrote: > > It support single core and multi-core ARM SoCs. But it assume > > all cores share the same frequency and voltage. > > > > Signed-off-by: Richard Zhao > > --- > > drivers/cpufreq/Kconfig

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-17 Thread Richard Zhao
On Fri, Dec 16, 2011 at 12:26:03PM +0100, Heiko Stübner wrote: > Am Freitag, 16. Dezember 2011, 11:30:59 schrieb Richard Zhao: > > It support single core and multi-core ARM SoCs. But it assume > > all cores share the same frequency and voltage. > > > > Signed-off-by: Richard Zhao > > --- > > dri

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-16 Thread Bryan Huntsman
On 12/16/2011 02:52 AM, Jamie Iles wrote: > >> +static DEFINE_PER_CPU(unsigned long, l_p_j_ref); >> +static unsigned long l_p_j_ref_freq; >> + >> +static struct clk *cpu_clk; > > This assumes that all CPU's share the same clk and run at the same rate. > Is that a fair/safe assumption? I honestl

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-16 Thread Jamie Iles
Hi Richard, A couple of questions inline, but otherwise looks nice! Jamie On Fri, Dec 16, 2011 at 06:30:59PM +0800, Richard Zhao wrote: > It support single core and multi-core ARM SoCs. But it assume > all cores share the same frequency and voltage. > > Signed-off-by: Richard Zhao > --- [...]

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-16 Thread Heiko Stübner
Am Freitag, 16. Dezember 2011, 11:30:59 schrieb Richard Zhao: > It support single core and multi-core ARM SoCs. But it assume > all cores share the same frequency and voltage. > > Signed-off-by: Richard Zhao > --- > drivers/cpufreq/Kconfig.arm |8 ++ > drivers/cpufreq/Makefile |1

Re: [PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-16 Thread Rob Herring
On 12/16/2011 04:30 AM, Richard Zhao wrote: > It support single core and multi-core ARM SoCs. But it assume > all cores share the same frequency and voltage. > > Signed-off-by: Richard Zhao > --- > drivers/cpufreq/Kconfig.arm |8 ++ > drivers/cpufreq/Makefile |1 + > drivers/cpufr

[PATCH V2 1/4] cpufreq: add arm soc generic cpufreq driver

2011-12-16 Thread Richard Zhao
It support single core and multi-core ARM SoCs. But it assume all cores share the same frequency and voltage. Signed-off-by: Richard Zhao --- drivers/cpufreq/Kconfig.arm |8 ++ drivers/cpufreq/Makefile |1 + drivers/cpufreq/arm-cpufreq.c | 269