Re: [PATCH V2 4/4] cpufreq: Get rid of "struct global_attr"

2013-02-21 Thread Viresh Kumar
On 22 February 2013 08:03, Rafael J. Wysocki wrote: > On Friday, February 22, 2013 07:47:44 AM Viresh Kumar wrote: >> On 22 February 2013 05:15, Rafael J. Wysocki wrote: >> > Why did you change all of the lines of this macro instead of changing just >> > the >> > one line you needed to change? >

Re: [PATCH V2 4/4] cpufreq: Get rid of "struct global_attr"

2013-02-21 Thread Rafael J. Wysocki
On Friday, February 22, 2013 07:47:44 AM Viresh Kumar wrote: > On 22 February 2013 05:15, Rafael J. Wysocki wrote: > > Why did you change all of the lines of this macro instead of changing just > > the > > one line you needed to change? > > I didn't like the indentation used within the macro. So

Re: [PATCH V2 4/4] cpufreq: Get rid of "struct global_attr"

2013-02-21 Thread Viresh Kumar
On 22 February 2013 05:15, Rafael J. Wysocki wrote: > Why did you change all of the lines of this macro instead of changing just the > one line you needed to change? I didn't like the indentation used within the macro. So did it. > Please don't do that. Okay. __

Re: [PATCH V2 4/4] cpufreq: Get rid of "struct global_attr"

2013-02-21 Thread Rafael J. Wysocki
On Monday, February 11, 2013 01:20:03 PM Viresh Kumar wrote: > We don't need to keep two structures for file attributes, global_attr and > freq_attr. Lets use freq_attr only for cpufreq core and drivers. > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/acpi-cpufreq.c | 9 - > dri

[PATCH V2 4/4] cpufreq: Get rid of "struct global_attr"

2013-02-10 Thread Viresh Kumar
We don't need to keep two structures for file attributes, global_attr and freq_attr. Lets use freq_attr only for cpufreq core and drivers. Signed-off-by: Viresh Kumar --- drivers/cpufreq/acpi-cpufreq.c | 9 - drivers/cpufreq/intel_pstate.c | 30 +++--- include/li