Re: [U-Boot] [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-08-10 Thread Chander Kashyap
Hi Detlev, On 10 August 2011 15:48, Detlev Zundel wrote: > Hi Chander, > > [...] > > >>> lease get rid of all these magic hard coded constants. Use symbolic > >>> names instead. If needed, auto-generate these from the respective C > >>> structs. If needed, create the C structs. > >>> > >> > >

Re: [U-Boot] [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-08-10 Thread Detlev Zundel
Hi Chander, [...] >>> lease get rid of all these magic hard coded constants. Use symbolic >>> names instead. If needed, auto-generate these from the respective C >>> structs. If needed, create the C structs. >>> >> >> I will change hard coded values to symbolic names >> > > While doing this, I

Re: [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-08-09 Thread Chander Kashyap
Dear Wolfgang Denk, On 3 August 2011 09:17, Chander Kashyap wrote: > Dear Wolfgang Denk, > > On 31 July 2011 15:30, Wolfgang Denk wrote: > >> Dear Chander Kashyap, >> >> In message <1311914519-10531-2-git-send-email-chander.kash...@linaro.org> >> you wrote: >> > Origen board is based upon S5PV3

Re: [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-08-03 Thread Chander Kashyap
On 3 August 2011 11:29, Wolfgang Denk wrote: > Dear Chander Kashyap, > > In message < > canuqghfvbv-b5ecrqkrkcppowx2umpbr_rfprx-c0fbvlmx...@mail.gmail.com> you > wrote: > > > > > > +void dram_init_banksize(void) > > > > +{ > > > > + gd->bd->bi_dram[0].start = PHYS_SDRAM_1; > > > > + gd->b

Re: [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-08-02 Thread Wolfgang Denk
Dear Chander Kashyap, In message you wrote: > > > > +void dram_init_banksize(void) > > > +{ > > > + gd->bd->bi_dram[0].start = PHYS_SDRAM_1; > > > + gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE; > > > + gd->bd->bi_dram[1].start = PHYS_SDRAM_2; > > > + gd->bd->bi_dram[1].size = PH

Re: [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-08-02 Thread Chander Kashyap
Dear Wolfgang Denk, On 31 July 2011 15:30, Wolfgang Denk wrote: > Dear Chander Kashyap, > > In message <1311914519-10531-2-git-send-email-chander.kash...@linaro.org> > you wrote: > > Origen board is based upon S5PV310 SoC which is similiar to > > S5PC210 SoC. > > > > Signed-off-by: Chander Kashy

Re: [PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-07-31 Thread Wolfgang Denk
Dear Chander Kashyap, In message <1311914519-10531-2-git-send-email-chander.kash...@linaro.org> you wrote: > Origen board is based upon S5PV310 SoC which is similiar to > S5PC210 SoC. > > Signed-off-by: Chander Kashyap ... > + /* APLL(1), MPLL(1), CORE(0), HPM(0) */ > + ldr r1, =0x0

[PATCH v4 1/2] ARMV7: Add support for Samsung ORIGEN board

2011-07-28 Thread Chander Kashyap
Origen board is based upon S5PV310 SoC which is similiar to S5PC210 SoC. Signed-off-by: Chander Kashyap --- Changes for v2: - None Changes for v3: - Board entry added Alphabetically in boards.cfg - Used get_Ram_size function to calculate ram size Changes for v4: -