Re: [PATCH v5] ARM: imx: Add basic imx6q cpu thermal management

2012-06-20 Thread Rob Lee
On Wed, Jun 20, 2012 at 9:20 AM, Sascha Hauer wrote: > On Wed, Jun 20, 2012 at 09:12:51AM -0500, Rob Lee wrote: >> Sascha, thanks for the review. >> >> >> + >> >> +static struct imx6q_thermal_zone     *th_zone; >> >> +static void __iomem                  *ocotp_base; >> > >> > This is a driver and

Re: [PATCH v5] ARM: imx: Add basic imx6q cpu thermal management

2012-06-20 Thread Sascha Hauer
On Wed, Jun 20, 2012 at 09:12:51AM -0500, Rob Lee wrote: > Sascha, thanks for the review. > > >> + > >> +static struct imx6q_thermal_zone     *th_zone; > >> +static void __iomem                  *ocotp_base; > > > > This is a driver and drivers should generally be multi instance safe. > > > > I d

Re: [PATCH v5] ARM: imx: Add basic imx6q cpu thermal management

2012-06-20 Thread Rob Lee
Sascha, thanks for the review. On Wed, Jun 20, 2012 at 5:11 AM, Sascha Hauer wrote: > On Wed, Jun 20, 2012 at 02:06:04AM -0500, Robert Lee wrote: >> Add imx6q cpu thermal management driver using the new cpu cooling >> interface which limits system performance via cpufreq to reduce >> the cpu temp

Re: [PATCH v5] ARM: imx: Add basic imx6q cpu thermal management

2012-06-20 Thread Sascha Hauer
On Wed, Jun 20, 2012 at 02:06:04AM -0500, Robert Lee wrote: > Add imx6q cpu thermal management driver using the new cpu cooling > interface which limits system performance via cpufreq to reduce > the cpu temperature. Temperature readings are taken using > the imx6q temperature sensor and this func

Re: [PATCH v5] ARM: imx: Add basic imx6q cpu thermal management

2012-06-20 Thread Rob Lee
On Wed, Jun 20, 2012 at 2:06 AM, Robert Lee wrote: > Add imx6q cpu thermal management driver using the new cpu cooling > interface which limits system performance via cpufreq to reduce > the cpu temperature.  Temperature readings are taken using > the imx6q temperature sensor and this functionalit

[PATCH v5] ARM: imx: Add basic imx6q cpu thermal management

2012-06-20 Thread Robert Lee
Add imx6q cpu thermal management driver using the new cpu cooling interface which limits system performance via cpufreq to reduce the cpu temperature. Temperature readings are taken using the imx6q temperature sensor and this functionality was added as part of this cpu thermal management driver.

[PATCH v5] ARM: imx: Add basic imx6q cpu thermal management

2012-06-20 Thread Robert Lee
Based on v3.5-rc3 plus recently submmited cpu_cooling functionality here: http://www.spinics.net/lists/kernel/msg1340221.html I am told this cpu cooling patch has been accepted and exists in len brown's next branch. link to previous submissions: v4: http://comments.gmane.org/gmane.linux.acpi.dev