Re: [PATCH v5 1/2] mfd: Add anatop mfd driver

2012-03-01 Thread Mark Brown
On Thu, Mar 01, 2012 at 05:10:51PM +0800, Ying-Chun Liu (PaulLiu) wrote: > + spin_lock(&adata->reglock); > + val = readl(adata->ioreg + addr); > + spin_unlock(&adata->reglock); Do you really need to take a lock for a single read operation from a memory mapped register? I'd expect thi

[PATCH v5 1/2] mfd: Add anatop mfd driver

2012-03-01 Thread Ying-Chun Liu (PaulLiu)
From: "Ying-Chun Liu (PaulLiu)" Anatop is a mfd chip embedded in Freescale i.MX6Q SoC. Anatop provides regulators and thermal. This driver handles the address space and the operation of the mfd device. Signed-off-by: Ying-Chun Liu (PaulLiu) Cc: Samuel Ortiz Cc: Mark Brown Cc: Shawn Guo ---