Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-16 Thread Turquette, Mike
On Thu, Mar 15, 2012 at 2:43 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Wed, Mar 14, 2012 at 05:51:48PM -0700, Turquette, Mike wrote: @@ -84,9 +78,9 @@ static int clk_divider_bestdiv(struct clk_hw *hw, unsigned long rate,       for (i = 1; i = maxdiv; i++) {               parent_rate

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-15 Thread Sascha Hauer
On Wed, Mar 14, 2012 at 05:51:48PM -0700, Turquette, Mike wrote: On Tue, Mar 13, 2012 at 5:05 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Mon, Mar 12, 2012 at 08:16:36PM -0700, Turquette, Mike wrote: On Mon, Mar 12, 2012 at 4:51 AM, Sascha Hauer s.ha...@pengutronix.de wrote: I

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-14 Thread Turquette, Mike
On Tue, Mar 13, 2012 at 5:05 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Mon, Mar 12, 2012 at 08:16:36PM -0700, Turquette, Mike wrote: On Mon, Mar 12, 2012 at 4:51 AM, Sascha Hauer s.ha...@pengutronix.de wrote: I tried another approach on the weekend which basically does not try to do

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-13 Thread Sascha Hauer
Hi Mike, On Mon, Mar 12, 2012 at 08:16:36PM -0700, Turquette, Mike wrote: On Mon, Mar 12, 2012 at 4:51 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Sun, Mar 11, 2012 at 02:24:46PM -0700, Turquette, Mike wrote: On Sun, Mar 11, 2012 at 4:34 AM, Sascha Hauer s.ha...@pengutronix.de

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-13 Thread Rob Herring
Mike, On 03/10/2012 01:54 AM, Mike Turquette wrote: The common clock framework defines a common struct clk useful across most platforms as well as an implementation of the clk api that drivers can use safely for managing clocks. The net result is consolidation of many different struct clk

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-13 Thread Turquette, Mike
On Tue, Mar 13, 2012 at 2:48 PM, Rob Herring robherri...@gmail.com wrote: Mike, On 03/10/2012 01:54 AM, Mike Turquette wrote: The common clock framework defines a common struct clk useful across most platforms as well as an implementation of the clk api that drivers can use safely for

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-12 Thread Sascha Hauer
On Sun, Mar 11, 2012 at 02:24:46PM -0700, Turquette, Mike wrote: On Sun, Mar 11, 2012 at 4:34 AM, Sascha Hauer s.ha...@pengutronix.de wrote: Hi Mike, I was about to give my tested-by when I decided to test the set_rate function. Unfortunately this is broken for several reasons. I'll try

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-12 Thread Turquette, Mike
On Mon, Mar 12, 2012 at 4:51 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Sun, Mar 11, 2012 at 02:24:46PM -0700, Turquette, Mike wrote: On Sun, Mar 11, 2012 at 4:34 AM, Sascha Hauer s.ha...@pengutronix.de wrote: Hi Mike, I was about to give my tested-by when I decided to test the

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-11 Thread Sascha Hauer
Hi Mike, I was about to give my tested-by when I decided to test the set_rate function. Unfortunately this is broken for several reasons. I'll try to come up with a fixup series later the day. On Fri, Mar 09, 2012 at 11:54:23PM -0800, Mike Turquette wrote: + +/** + * DOC: Using the

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-11 Thread Turquette, Mike
On Sun, Mar 11, 2012 at 4:34 AM, Sascha Hauer s.ha...@pengutronix.de wrote: Hi Mike, I was about to give my tested-by when I decided to test the set_rate function. Unfortunately this is broken for several reasons. I'll try to come up with a fixup series later the day. I haven't tested

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-10 Thread Andrew Lunn
On Fri, Mar 09, 2012 at 11:54:23PM -0800, Mike Turquette wrote: The common clock framework defines a common struct clk useful across most platforms as well as an implementation of the clk api that drivers can use safely for managing clocks. Hi Mike Please feel free to add: Tested-by: Andrew

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-10 Thread Thomas Gleixner
On Fri, 9 Mar 2012, Mike Turquette wrote: +inline unsigned long __clk_get_enable_count(struct clk *clk) +{ + return !clk ? -EINVAL : clk-enable_count; Returning negative error codes in a function with a return value unsigned long is a bit strange at least. Shouldn't that be long ?

Re: [PATCH v6 2/3] clk: introduce the common clock framework

2012-03-10 Thread Richard Zhao
Looks like you didn't take my comments for v5. http://www.spinics.net/lists/arm-kernel/msg162903.html Regards Richard ___ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev

[PATCH v6 2/3] clk: introduce the common clock framework

2012-03-09 Thread Mike Turquette
The common clock framework defines a common struct clk useful across most platforms as well as an implementation of the clk api that drivers can use safely for managing clocks. The net result is consolidation of many different struct clk definitions and platform-specific clock framework