Re: [PATCHv2] cpufreq for freescale mx51

2010-10-19 Thread Yong Shen
+struct cpu_wp *(*get_cpu_wp)(int *wp); + This is not needed. This is needed, otherwise it does not pass compile. This hunk is the only change to arch/arm/mach-mx5/cpu.c and get_cpu_wp is introduced with this patch, so how can this break compilation?

Re: [PATCHv2] cpufreq for freescale mx51

2010-10-18 Thread Yong Shen
Hi Sascha, On Mon, Oct 18, 2010 at 4:31 PM, Sascha Hauer s.ha...@pengutronix.dewrote: Hi Yong, On Mon, Oct 18, 2010 at 01:43:43PM +0800, Yong Shen wrote: Hi Sascha, Thanks for your thorough review. I have two feedbacks to your commends. Sorry for delayed response, cause I had a hard

Re: [PATCHv2] cpufreq for freescale mx51

2010-10-18 Thread Sascha Hauer
Hi Yong, On Mon, Oct 18, 2010 at 01:43:43PM +0800, Yong Shen wrote: Hi Sascha, Thanks for your thorough review. I have two feedbacks to your commends. Sorry for delayed response, cause I had a hard time due to my computer crash and data loss. diff --git a/arch/arm/mach-mx5/cpu.c

Re: [PATCHv2] cpufreq for freescale mx51

2010-10-18 Thread Sascha Hauer
On Mon, Oct 18, 2010 at 05:08:14PM +0800, Yong Shen wrote: Hi Sascha, On Mon, Oct 18, 2010 at 4:31 PM, Sascha Hauer s.ha...@pengutronix.dewrote: Hi Yong, On Mon, Oct 18, 2010 at 01:43:43PM +0800, Yong Shen wrote: Hi Sascha, Thanks for your thorough review. I have two

Re: [PATCHv2] cpufreq for freescale mx51

2010-10-17 Thread Yong Shen
Hi Amit, I agree about all the comments. New patch is coming. Yong On Wed, Oct 13, 2010 at 6:38 PM, Amit Kucheria amit.kuche...@linaro.orgwrote: Yong, Some more comments. But the patch is looking good now. On Fri, Oct 8, 2010 at 11:08 AM, yong.s...@linaro.org wrote: From: Yong Shen

Re: [PATCHv2] cpufreq for freescale mx51

2010-10-13 Thread Amit Kucheria
Yong, Some more comments. But the patch is looking good now. On Fri, Oct 8, 2010 at 11:08 AM, yong.s...@linaro.org wrote: From: Yong Shen yong.s...@linaro.org it is tested on babbage 3.0 Change to Cpufreq driver for imx51. The operating points are currently tested on babbage 3.0.

Re: [PATCHv2] cpufreq for freescale mx51

2010-10-12 Thread Yong Shen
Does anybody have more comments on [PATCHv2] ? On Thu, Oct 7, 2010 at 8:00 PM, Yong Shen yong.s...@linaro.org wrote: Using wp_tbl is because that it also contains information like regulator voltage. The clock code does not handle the regulators, not even in the fsl kernel. I did not

[PATCHv2] cpufreq for freescale mx51

2010-10-08 Thread yong . shen
From: Yong Shen yong.s...@linaro.org it is tested on babbage 3.0 Signed-off-by: Yong Shen yong.s...@linaro.org --- arch/arm/Kconfig |6 + arch/arm/mach-mx5/Kconfig |1 + arch/arm/mach-mx5/Makefile |1 +