Re: [RFC V6 PATCH 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-23 Thread Alan Stern
On Thu, 23 May 2013, Manjunath Goudar wrote: > This patch splits the PCI portion of ohci-hcd out into its > own separate driver module, called ohci-pci. > > The major point of difficulty lies in ohci-pci's many vendor- and > device-specific workarounds. Some of them have to be applied before > c

Re: [RFC V6 PATCH 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-23 Thread Alan Stern
On Thu, 23 May 2013, Arnd Bergmann wrote: > On Thursday 23 May 2013, Alan Stern wrote: > > On Thu, 23 May 2013, Manjunath Goudar wrote: > > > Also, you left out one thing that should still be here. What happened > > to the part about changing > > > > #if !defined(PCI_DRIVER) && \ > >

Re: [RFC V6 PATCH 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-23 Thread Arnd Bergmann
On Thursday 23 May 2013, Alan Stern wrote: > > > > > > > This section of the driver is gone now since 86510bb248 "USB: OHCI: > > clarify Kconfig dependencies", so the change is no longer needed. > > I don't know what tree you're referring to. That commit is not present > in Greg's usb-linus or

Re: [RFC V6 PATCH 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-23 Thread Arnd Bergmann
On Thursday 23 May 2013, Alan Stern wrote: > On Thu, 23 May 2013, Manjunath Goudar wrote: > Also, you left out one thing that should still be here. What happened > to the part about changing > > #if !defined(PCI_DRIVER) && \ > > to > > #if !ENABLED(CONFIG_USB_OHCI_HCD_PCI) &&\

[RFC V6 PATCH 3/3] USB: OHCI: make ohci-pci a separate driver

2013-05-23 Thread Manjunath Goudar
This patch splits the PCI portion of ohci-hcd out into its own separate driver module, called ohci-pci. The major point of difficulty lies in ohci-pci's many vendor- and device-specific workarounds. Some of them have to be applied before calling ohci_start() some after, which necessitates a fair