Re: [U-Boot] [PATCH v2 1/2] ARMV7: Add support for Samsung SMDKV310 Board

2011-05-18 Thread Minkyu Kang
Dear Chander Kashyap, On 21 April 2011 16:02, Chander Kashyap wrote: > SMDKV310 board is based on Samsung S5PV310 SOC. This SOC is very much > similar to S5PC210. > > Signed-off-by: Chander Kashyap > Signed-off-by: Tushar Behera > --- > Changes for v2: >        - Coding Style Cleanup >        -

Re: [U-Boot] [PATCH v2 1/2] ARMV7: Add support for Samsung SMDKV310 Board

2011-05-18 Thread Minkyu Kang
Dear Wolfgang Denk, On 18 May 2011 16:49, Wolfgang Denk wrote: > Dear Minkyu Kang, > > In message you wrote: >> >> > diff --git a/boards.cfg b/boards.cfg >> > index 554e06c..01edb79 100644 >> > --- a/boards.cfg >> > +++ b/boards.cfg > ... >> Please use space instead of tab. > > No! > > Indentati

Re: [U-Boot] [PATCH v2 1/2] ARMV7: Add support for Samsung SMDKV310 Board

2011-05-18 Thread Wolfgang Denk
Dear Minkyu Kang, In message you wrote: > > Hm, but everyone is using the space on "boards.cfg". I will eventually run "unexpand -a" on the file again... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenst

Re: [U-Boot] [PATCH v2 1/2] ARMV7: Add support for Samsung SMDKV310 Board

2011-05-18 Thread Wolfgang Denk
Dear Minkyu Kang, In message you wrote: > > > diff --git a/boards.cfg b/boards.cfg > > index 554e06c..01edb79 100644 > > --- a/boards.cfg > > +++ b/boards.cfg ... > Please use space instead of tab. No! Indentation / vertical alignment SHALL be done using TABs! Best regards, Wolfgang Denk --