Re: [linux-pm] [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2012-01-12 Thread Amit Kachhap
Hi Rob, I got your point. The main idea of doing like this is to keep the cooling implementation independent from thermal zone algorithms(thermal_sys.c). But binding freq_tab index to the trip numbers may be not be bad idea. I will give more thought into it in the next patchset. Regards, Amit D

Re: [linux-pm] [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2012-01-11 Thread Rob Lee
Hey Amit/Vincent, It appears that with this implementation the STATE_ACTIVE trip number used will also be the index of the cool_freq_tab used. If that is true, then perhaps a common structure would be beneficial that links each STATE_ACTIVE trip point with its corresponding cooling data. BR, Rob

Re: [linux-pm] [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2011-12-20 Thread Amit Kachhap
Hi Vincent, Thanks for the review. Well actually your are correct that current temperature and last temperature can be used to increase or decrease the cpu frequency. But this has to be done again in cooling devices so to make the cooling devices generic and to avoid the temperature comparison ag

Re: [linux-pm] [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2011-12-20 Thread Amit Kachhap
Hi Vincent, Thanks for the review. Well actually your are correct that current temperature and last temperature can be used to increase or decrease the cufreq. But this has to be done again in cooling devices so to make the cooling devices generic and to avoid the temperature comparision again thi

Re: [linux-pm] [RFC PATCH 1/2] thermal: Add a new trip type to use cooling device instance number

2011-12-20 Thread Vincent Guittot
Hi Amit, I'm not sure that using the trip index for setting the state of a cooling device is a generic solution because you are adding a dependency between the trip index and the cooling device state that might be difficult to handle. This dependency implies that a cooling device like cpufreq_cool