Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Morten Rasmussen
On Fri, Oct 12, 2012 at 04:33:19PM +0100, Jon Medhurst (Tixy) wrote: > On Fri, 2012-10-12 at 16:11 +0100, Morten Rasmussen wrote: > > Hi Tixy, > > > > Thanks for the patch. I think this patch is the right way to solve this > > issue. > > > > There is still a problem with the priority filter in >

Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Jon Medhurst (Tixy)
On Fri, 2012-10-12 at 21:03 +0530, Viresh Kumar wrote: > On 12 October 2012 20:41, Morten Rasmussen wrote: > > Thanks for the patch. I think this patch is the right way to solve this > > issue. > > > > There is still a problem with the priority filter in > > hmp_down_migration() which Viresh point

Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Viresh Kumar
On 12 October 2012 20:41, Morten Rasmussen wrote: > Thanks for the patch. I think this patch is the right way to solve this > issue. > > There is still a problem with the priority filter in > hmp_down_migration() which Viresh pointed out earlier. There is no > checking of whether the task is actua

Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Jon Medhurst (Tixy)
On Fri, 2012-10-12 at 16:11 +0100, Morten Rasmussen wrote: > Hi Tixy, > > Thanks for the patch. I think this patch is the right way to solve this > issue. > > There is still a problem with the priority filter in > hmp_down_migration() which Viresh pointed out earlier. There is no > checking of wh

Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Morten Rasmussen
Hi Tixy, Thanks for the patch. I think this patch is the right way to solve this issue. There is still a problem with the priority filter in hmp_down_migration() which Viresh pointed out earlier. There is no checking of whether the task is actually allowed to run on any of the slower cpus. Solvin

Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Viresh Kumar
On 12 October 2012 19:30, Jon Medhurst (Tixy) wrote: > It will need fixing one way or the other, and it makes more sense to be > part of the MP branch. I was hoping for a second opinion from someone, > but if the fix looks OK to you, then yes, please add it to your branch. Ok I have applied this

Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Jon Medhurst (Tixy)
On Fri, 2012-10-12 at 19:11 +0530, Viresh Kumar wrote: > On 12 October 2012 19:03, Jon Medhurst (Tixy) wrote: > > On Fri, 2012-10-12 at 14:19 +0100, Jon Medhurst (Tixy) wrote: > >> The attached patch fixes the immediate problem by avoiding the empty > >> domain (which is probably a good thing anyw

Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Andrey Konovalov
On 10/12/2012 05:41 PM, Viresh Kumar wrote: On 12 October 2012 19:03, Jon Medhurst (Tixy) wrote: On Fri, 2012-10-12 at 14:19 +0100, Jon Medhurst (Tixy) wrote: The attached patch fixes the immediate problem by avoiding the empty domain (which is probably a good thing anyway) Oops, my last pat

Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Viresh Kumar
On 12 October 2012 19:03, Jon Medhurst (Tixy) wrote: > On Fri, 2012-10-12 at 14:19 +0100, Jon Medhurst (Tixy) wrote: >> The attached patch fixes the immediate problem by avoiding the empty >> domain (which is probably a good thing anyway) > > Oops, my last patch included some extra junk, the one a

Re: Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Jon Medhurst (Tixy)
On Fri, 2012-10-12 at 14:19 +0100, Jon Medhurst (Tixy) wrote: > The attached patch fixes the immediate problem by avoiding the empty > domain (which is probably a good thing anyway) Oops, my last patch included some extra junk, the one attached to this mail fixes this... >From 7365076675b851355d48

Fix for HMP scheduler crash [ Re: [GIT PULL]: big LITTLE MP v10]

2012-10-12 Thread Jon Medhurst (Tixy)
On Fri, 2012-10-12 at 10:35 +0100, Jon Medhurst (Tixy) wrote: > On Fri, 2012-10-12 at 14:46 +0530, Viresh Kumar wrote: > > Hi Andrey, > > > > Please PULL b.L MP V10 branch from my tree. > > I've been testing with the v10 branch and with "Enable HMP priority > filter by default" I have get a crash