RE: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-13 Thread R, Durgadoss
Hi Amit, [snip.] > >> + > >> +     kobject_uevent(&th_zone->therm_dev->device.kobj, KOBJ_CHANGE); > > > > Wouldn't it make more sense to pass the trip point id also as an 'env' > > parameter ? This way, the user space can easily figure out which trip > > point has been crossed. > Its a good sugge

Re: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread Amit Kachhap
On 13 March 2012 09:24, Tushar Behera wrote: > On 03/03/2012 04:36 PM, Amit Daniel Kachhap wrote: >> This codes uses the generic linux thermal layer and creates a bridge >> between temperature sensors, linux thermal framework and cooling devices >> for samsung exynos platform. This layer recieves

Re: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread Amit Kachhap
Hi Durgadoss, Thanks for the detailed review. On 12 March 2012 16:21, R, Durgadoss wrote: > Hi Amit, > > Thanks for keeping this up. And Sorry for late reply. > >> -Original Message- >> From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel >> Kachhap >> Sent: Saturda

Re: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread Tushar Behera
On 03/03/2012 04:36 PM, Amit Daniel Kachhap wrote: > This codes uses the generic linux thermal layer and creates a bridge > between temperature sensors, linux thermal framework and cooling devices > for samsung exynos platform. This layer recieves or monitor the > temperature from the sensor and in

RE: [PATCH 1/4] thermal: exynos: Add thermal interface support for linux thermal layer

2012-03-12 Thread R, Durgadoss
Hi Amit, Thanks for keeping this up. And Sorry for late reply. > -Original Message- > From: amit kachhap [mailto:amitdani...@gmail.com] On Behalf Of Amit Daniel > Kachhap > Sent: Saturday, March 03, 2012 4:36 PM > To: linux...@lists.linux-foundation.org; linux-samsung-...@vger.kernel.org