[Linphone-users] Bug: Invalid IPv6 address in SIP message parser (via attribute)

2020-04-06 Thread Waishon
Hey there, I'm currently trying to connect to a SIP server using IPv6, which fails. Linphone fails to decode the IPv6 address sent back in the Via header of the 401 Unauthorized reply (after first REGISTER request). The IPv6 is in the "URL encoded" format with squared brackets: [2000:abc::1]:50

Re: [Linphone-users] Bug: Invalid IPv6 address in SIP message parser (via attribute)

2020-04-06 Thread Stuart D Gathman
On Mon, 6 Apr 2020, Waishon wrote: I'm currently trying to connect to a SIP server using IPv6, which fails. Linphone fails to decode the IPv6 address sent back in the Via header of the 401 Unauthorized reply (after first REGISTER request). The IPv6 is in the "URL encoded" format with squared br

Re: [Linphone-users] Bug: Invalid IPv6 address in SIP message parser (via attribute)

2020-04-07 Thread Waishon
I just investigated the issue: Some providers tend to send the IPv6 address in the received parameter with square brackets some do not. Currently linphone only handles the event without having square brackets: https://github.com/BelledonneCommunications/belle-sip/blob/master/src/grammars/belle_sip_

Re: [Linphone-users] Bug: Invalid IPv6 address in SIP message parser (via attribute)

2020-04-08 Thread jehan.monnier
Hi, To « be liberal in accepting a "received" parameter with or without the delimiting "[" and "] » tokens » the best solution is to modify the via_address rule (https://github.com/BelledonneCommunications/belle-sip/blob/35d16dce74163abbb134b9006066fed4f547625e/src/grammars/belle_sip_message.g

Re: [Linphone-users] Bug: Invalid IPv6 address in SIP message parser (via attribute)

2020-04-08 Thread Waishon
I've created a patch which fixes the "issue" and sent an contributor agreement to your sales department. Where do you want me to create a merge request? In your gitlab instance? However as a new user you don't have the permissions to create a fork of a project. Am Di., 7. Apr. 2020 um 14:32 Uhr sc

Re: [Linphone-users] Bug: Invalid IPv6 address in SIP message parser (via attribute)

2020-04-09 Thread Peio Rigaux
Hello. As we will change our Gitlab rights soon, please submit your pull request on our Github mirror https://github.com/BelledonneCommunications/ Regards Peio Rigaux Junior Software Engineer Belledonne Communications, the company behind Linphone Linphone.org Le 08/04/20

Re: [Linphone-users] Bug: Invalid IPv6 address in SIP message parser (via attribute)

2020-04-09 Thread Waishon
I've created a pull request on github. https://github.com/BelledonneCommunications/belle-sip/pull/7 I would appreciate a review and merge. Am Mi., 8. Apr. 2020 um 22:13 Uhr schrieb Waishon : > I've created a patch which fixes the "issue" and sent an > contributor agreement to your sales departme