Re: [PATCH] cputime (1/6): move call to update_process_times.

2004-08-06 Thread Martin Schwidefsky
> > Wouldn't it be possible to move the #ifndef into sched.h? > > You can't simply define it to a nop in case of SMP, because > there it is called from a different place, but we could > have a separate version for UP and SMP in sched.h: > > void update_process_times(int user_tick); > static inline

Re: [PATCH] cputime (1/6): move call to update_process_times.

2004-08-05 Thread Alessandro Amici
Arnd, On Thursday 05 August 2004 22:54, Arnd Bergmann wrote: > void update_process_times(int user_tick); > static inline void update_process_times_nonsmp(int user_tick) > { > #ifndef CONFIG_SMP > update_process_times(user_tick); > #endif > } I'm sure you mean 'update_process_times_up' 8-)

Re: [PATCH] cputime (1/6): move call to update_process_times.

2004-08-05 Thread Arnd Bergmann
On Donnerstag, 5. August 2004 21:57, Alessandro Amici wrote: > I don't have enough knowledge to comment on the merit of the move to > architecture files, but the proliferation of #ifndef CONFIG_SMP looks really > ugly. Yes, it does. > Wouldn't it be possible to move the #ifndef into sched.h? Y

[PATCH] cputime (1/6): move call to update_process_times.

2004-08-05 Thread Martin Schwidefsky
[PATCH] cputime (1/6): move call to update_process_times. From: Martin Schwidefsky <[EMAIL PROTECTED]> For non-smp kernels the call to update_process_times is done in the do_timer function. It is more consistent with smp kernels to move this call to the architecture file which calls do