[PATCH] remove leftover documentation of acpi_generic_hotkey

2007-06-26 Thread Stephen Hemminger
This looks leftover text in the kernel parameter in documentation. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/Documentation/kernel-parameters.txt 2007-06-26 16:46:57.0 -0400 +++ b/Documentation/kernel-parameters.txt 2007-06-26 16:47:07.0 -0400 @@ -22

Re: [RFC/RFT][PATCH -mm 1/4] PM: Introduce set_target method in pm_ops

2007-06-26 Thread Pavel Machek
On Mon 2007-06-25 23:28:06, Johannes Berg wrote: > On Sun, 2007-06-24 at 22:40 +0200, Rafael J. Wysocki wrote: > > > + * @set_target: Tell the platform which system sleep state is going to be > > + * entered. The information passed to @set_target should be disregarded > > + * by the platform as s

Re: [RFC/RFT][PATCH -mm 8/8] PM: Rename hibernation_ops to platform_hibernation_operations

2007-06-26 Thread Pavel Machek
Hi! > Rename 'struct hibernation_ops' to 'struct platform_hibernation_operations' in > analogy with 'struct platform_suspend_operations'. Can I NAK it because it gets too long? platform_hibernation_ops / platform_suspend_ops is long but maybe acceptable, 'struct platform_hibernation_operations' i

Re: [RFC/RFT][PATCH -mm 6/8] PM: Rework struct platform_suspend_operations

2007-06-26 Thread Pavel Machek
Hi! > There is no reason why the .prepare() and .finish() methods in 'struct > platform_suspend_operations' should take any arguments, since architectures > don't use these methods' argument in any practically meaningful way (ie. > either > the target system sleep state is conveyed to the platfor

Re: [RFC/RFT][PATCH -mm 1/4] PM: Introduce set_target method in pm_ops

2007-06-26 Thread Rafael J. Wysocki
On Tuesday, 26 June 2007 19:19, David Brownell wrote: > On Tuesday 26 June 2007, Rafael J. Wysocki wrote: > > > Alternatively, I could write that the argument passed to .enter() etc. is > > guaranteed to be the same as the one passed to .set_target(), but I didn't > > want > > to say that. :-) >

Re: [RFC/RFT][PATCH -mm 1/4] PM: Introduce set_target method in pm_ops

2007-06-26 Thread David Brownell
On Tuesday 26 June 2007, Rafael J. Wysocki wrote: > Alternatively, I could write that the argument passed to .enter() etc. is > guaranteed to be the same as the one passed to .set_target(), but I didn't > want > to say that. :-) Why not? So long as enter() takes an argument, that seems to me ex

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-06-26 Thread Johannes Berg
On Tue, 2007-06-26 at 09:33 -0400, jamal wrote: > On Tue, 2007-26-06 at 00:40 +0200, Johannes Berg wrote: > > > I wonder if we should hold off on this API until we've worked out the > > multicast issue. > > I think we can fix all the code in one shot later. Yes, we could fix the code in the kern

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-06-26 Thread jamal
On Tue, 2007-26-06 at 00:40 +0200, Johannes Berg wrote: > I wonder if we should hold off on this API until we've worked out the > multicast issue. I think we can fix all the code in one shot later. I just glanced at your patch but i have to run out, i will stare at it later - seems to be in the r

[RFC/RFT][PATCH -mm 3/8] ACPI: Add acpi_pm_device_sleep_state helper routine (updated 2x)

2007-06-26 Thread Rafael J. Wysocki
[The previous version didn't compile. Sorry for the mess.] --- From: Shaohua Li <[EMAIL PROTECTED]>, Rafael J. Wysocki <[EMAIL PROTECTED]> Based on David Brownell's patch at http://marc.info/?l=linux-acpi&m=117873972806360&w=2 Add a helper routine returning the lowest power (highest number) ACPI

[RFC/RFT][PATCH -mm 3/8] ACPI: Add acpi_pm_device_sleep_state helper routine (updated)

2007-06-26 Thread Rafael J. Wysocki
[The previous version wouldn't work correctly.] --- From: Shaohua Li <[EMAIL PROTECTED]>, Rafael J. Wysocki <[EMAIL PROTECTED]> Based on the David Brownell's patch at http://marc.info/?l=linux-acpi&m=117873972806360&w=2 Add a helper routine returning the lowest power (highest number) ACPI device

Re: [RFC/RFT][PATCH -mm 1/4] PM: Introduce set_target method in pm_ops

2007-06-26 Thread Rafael J. Wysocki
On Monday, 25 June 2007 23:28, Johannes Berg wrote: > On Sun, 2007-06-24 at 22:40 +0200, Rafael J. Wysocki wrote: > > > + * @set_target: Tell the platform which system sleep state is going to be > > + * entered. The information passed to @set_target should be disregarded > > + * by the platform a

Re: Add INPUT support to toshiba_acpi

2007-06-26 Thread Richard Hughes
On Tue, 2007-06-26 at 07:03 +0200, Rolf Eike Beer wrote: > Richard Hughes wrote: > > On Sat, 2007-06-23 at 16:56 +0200, Rolf Eike Beer wrote: > > > None of the above keys generated a key event. Neither does > "Brightness > > > down", but it still works. "Brightness up" generates an event and > work

Re: [RFC/RFT][PATCH -mm 4/4] PM: Rework struct platform_suspend_operations

2007-06-26 Thread Johannes Berg
On Sun, 2007-06-24 at 22:44 +0200, Rafael J. Wysocki wrote: > There is no reason why the .prepare() and .finish() methods in 'struct > platform_suspend_operations' should take any arguments, since architectures > don't use these methods' argument in any practically meaningful way (ie. > either >

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-06-26 Thread Johannes Berg
On Tue, 2007-06-19 at 11:32 +0800, Zhang Rui wrote: > > Ok, by inspection (sorry, still dont have much time) - your kernel code > > is sending to group 1; i.e > > > > genlmsg_multicast(skb, 0, 1, GFP_ATOMIC); > > > > you need to change that to send to your assigned id, i.e: > > genlmsg_multicast

Re: [RFC/RFT][PATCH -mm 1/4] PM: Introduce set_target method in pm_ops

2007-06-26 Thread Johannes Berg
On Sun, 2007-06-24 at 22:40 +0200, Rafael J. Wysocki wrote: > + * @set_target: Tell the platform which system sleep state is going to be > + * entered. The information passed to @set_target should be disregarded > + * by the platform as soon as @finish() is executed and if @prepare() > + *