Andrew,
I can not contact with Len for several days, while the oops on battery
seems quite important.
It also seem to behave well in -mm tree (as part of Len's acpi-test).
Will you send this patch to Linus without approval from Len or should I?
Thanks,
Alex.
Andrew Morton wrote:
On Fri, 09
On Tue, 13 Nov 2007 11:35:18 +0300 Alexey Starikovskiy [EMAIL PROTECTED]
wrote:
I can not contact with Len for several days, while the oops on battery
seems quite important.
It also seem to behave well in -mm tree (as part of Len's acpi-test).
Will you send this patch to Linus without
get_property() should not call battery_update(),
it also should call get_status() only if battery is present to
avoid cycle and oops.
Signed-off-by: Alexey Starikovskiy [EMAIL PROTECTED]
Tested-by: Rolf Eike Beer [EMAIL PROTECTED]
Acked-by: Johannes Weiner [EMAIL PROTECTED]
---
Level GPE should not be enabled until all work caused by it is done,
e.g. all Notify() methods are completed.
This could be accomplished by appending enable_gpe function to the end
of notify queue.
Signed-off-by: Alexey Starikovskiy [EMAIL PROTECTED]
---
drivers/acpi/events/evgpe.c | 17
On Mon, Nov 12, 2007 at 05:08:53PM -0700, Alex Chiang wrote:
Hello,
[this patch series touches a few subsystems; hopefully I got all
the right maintainers]
Recently, Matthew Wilcox sent out the following mail about PCI
slots:
http://marc.info/?l=linux-pcim=119432330418980w=2
The
Alexey,
I'm considering writing a sysfs interface for the EC registers, and was
wondering if you would be ok with such a patch (before I start work on it)?
I'd like to expose the registers to userspace, as it is already possible to
access the EC registers in userspace via /dev/ports (and quite
On Tue, Nov 13, 2007 at 09:01:29AM -0800, Greg KH wrote:
I'm still not sold on this idea at all. I'm really betting that there
is a lot of incorrect acpi slot information floating around in machines
and odd things will show up in these slot entries.
Is that the end of the world? Instead of
Carlos Corbacho wrote:
Alexey,
I'm considering writing a sysfs interface for the EC registers, and was
wondering if you would be ok with such a patch (before I start work on it)?
What do you need that for?
I'd like to expose the registers to userspace, as it is already possible to
access
Alexey Starikovskiy wrote:
Carlos Corbacho wrote:
Alexey,
I'm considering writing a sysfs interface for the EC registers, and
was wondering if you would be ok with such a patch (before I start
work on it)?
What do you need that for?
I'd like to expose the registers to userspace, as it is
Alexey,
On Tuesday 13 November 2007 18:40:48 Alexey Starikovskiy wrote:
I think it is better to do it in file system that allows seek(). So you
could do with 1 file instead of 256 of them.
Fair enough.
Carlos, I don't like the idea of 256 files. This will consume too many
resources and will
On Tue, Nov 13, 2007 at 11:33:53AM -0700, Matthew Wilcox wrote:
On Tue, Nov 13, 2007 at 09:01:29AM -0800, Greg KH wrote:
I'm still not sold on this idea at all. I'm really betting that there
is a lot of incorrect acpi slot information floating around in machines
and odd things will show up
Carlos Corbacho wrote:
Alexey,
2) I'm toying with the idea of re-implementing acer_acpi as a userspace
application (which also requires EC access for certain functions - I don't
mind poking /dev/ports for the odd bit of reverse engineering, but for any
other kind of normal usage access to
Alexey,
How about character /dev/ec0?
Yes, that would be fine.
On Tuesday 13 November 2007 18:54:51 Alexey Starikovskiy wrote:
What is the benefit of having acer_acpi in userspace, rather than one more
*-laptop in /devices/misc?
A debate of would it be easier for me to maintain an in kernel
On Mon, Nov 12, 2007 at 05:13:36PM -0700, Alex Chiang wrote:
+ slot-name = kmalloc(8, GFP_KERNEL);
+ sprintf(slot-name, fake%d, count++);
Please use snprintf to avoid buffer overruns!
--linas
-
To unsubscribe from this list: send the line unsubscribe linux-acpi in
the body of a message
On Tue, Nov 13, 2007 at 01:48:15PM -0600, Linas Vepstas wrote:
On Mon, Nov 12, 2007 at 05:13:36PM -0700, Alex Chiang wrote:
+ slot-name = kmalloc(8, GFP_KERNEL);
+ sprintf(slot-name, fake%d, count++);
Please use snprintf to avoid buffer overruns!
Or, since kmalloc can return a 32-byte
On Mon, Nov 12, 2007 at 05:14:47PM -0700, Alex Chiang wrote:
+/* pci_slot represents a physical slot */
+struct pci_slot {
+ struct pci_bus *bus;/* The bus this slot is on */
+ struct pci_slot *next; /* Next slot on this bus */
+ struct hotplug_slot *hotplug;
On Tue, Nov 13, 2007 at 01:56:46PM -0600, Linas Vepstas wrote:
On Mon, Nov 12, 2007 at 05:14:47PM -0700, Alex Chiang wrote:
+/* pci_slot represents a physical slot */
+struct pci_slot {
+ struct pci_bus *bus;/* The bus this slot is on */
+ struct pci_slot *next;
On Tue, Nov 13, 2007 at 10:51:22AM -0800, Greg KH wrote:
Ok, again, I want to see the IBM people sign off on this, after testing
on all of their machines, before I'll consider this, as I know the IBM
acpi tables are odd.
That seems a little higher standard than patches are normally held to.
On Tue, Nov 13, 2007 at 01:11:02PM -0700, Matthew Wilcox wrote:
On Tue, Nov 13, 2007 at 10:51:22AM -0800, Greg KH wrote:
Ok, again, I want to see the IBM people sign off on this, after testing
on all of their machines, before I'll consider this, as I know the IBM
acpi tables are odd.
* Greg KH [EMAIL PROTECTED]:
On Mon, Nov 12, 2007 at 05:08:53PM -0700, Alex Chiang wrote:
Recently, Matthew Wilcox sent out the following mail about
PCI slots:
http://marc.info/?l=linux-pcim=119432330418980w=2
The following patch series is a rough first cut at
implementing
On Tue, Nov 13, 2007 at 09:01:29AM -0800, Greg KH wrote:
Also, some companies already provide userspace tools to get all of this
information about the different slots in a system and what is where,
from userspace, no kernel changes are needed. So, why add all this
extra complexity to the
On Tue, Nov 13, 2007 at 01:21:54PM -0700, Alex Chiang wrote:
* Greg KH [EMAIL PROTECTED]:
On Mon, Nov 12, 2007 at 05:08:53PM -0700, Alex Chiang wrote:
Recently, Matthew Wilcox sent out the following mail about
PCI slots:
http://marc.info/?l=linux-pcim=119432330418980w=2
* Greg KH [EMAIL PROTECTED]:
Ok, again, I want to see the IBM people sign off on this, after
testing on all of their machines, before I'll consider this, as
I know the IBM acpi tables are odd.
Who would be a good contact at IBM to get some eyes / machine
time on this?
Also, how about Dell
* Linas Vepstas [EMAIL PROTECTED]:
On Tue, Nov 13, 2007 at 09:01:29AM -0800, Greg KH wrote:
Also, some companies already provide userspace tools to get
all of this information about the different slots in a system
and what is where, from userspace, no kernel changes are
needed. So,
On Tue, Nov 13, 2007 at 10:51:22AM -0800, Greg KH wrote:
On Tue, Nov 13, 2007 at 11:33:53AM -0700, Matthew Wilcox wrote:
On Tue, Nov 13, 2007 at 09:01:29AM -0800, Greg KH wrote:
I'm still not sold on this idea at all. I'm really betting that there
is a lot of incorrect acpi slot
* Matt Domsch [EMAIL PROTECTED]:
The only reported _SUN problems on Dell systems were on the
PE6800 and PE6850 systems, which we've fixed with an updated
BIOS several months ago. IIRC the values weren't always unique
which kind of defeated the purpose.
FWIW, the ACPI 2.0 spec did not
On Tue, Nov 13, 2007 at 01:36:45PM -0700, Alex Chiang wrote:
* Greg KH [EMAIL PROTECTED]:
Ok, again, I want to see the IBM people sign off on this, after
testing on all of their machines, before I'll consider this, as
I know the IBM acpi tables are odd.
Who would be a good contact at
On Tue, Nov 13, 2007 at 03:15:09PM -0600, Matt Domsch wrote:
On Tue, Nov 13, 2007 at 10:51:22AM -0800, Greg KH wrote:
On Tue, Nov 13, 2007 at 11:33:53AM -0700, Matthew Wilcox wrote:
On Tue, Nov 13, 2007 at 09:01:29AM -0800, Greg KH wrote:
I'm still not sold on this idea at all. I'm
On Tue, Nov 13, 2007 at 02:31:08PM -0700, Alex Chiang wrote:
* Matt Domsch [EMAIL PROTECTED]:
The only reported _SUN problems on Dell systems were on the
PE6800 and PE6850 systems, which we've fixed with an updated
BIOS several months ago. IIRC the values weren't always unique
which
On Tue, Nov 13, 2007 at 01:59:39PM -0700, Alex Chiang wrote:
On pseries systems, I deal with something called the
partitionable endpoint, which I think probably usually
corresponds to physical slots, but I don't really know.
So, naively, the physical slot concept doesn't really map
On Tue, Nov 13, 2007 at 03:41:21PM -0600, Linas Vepstas wrote:
/sys/bus/pci/slots
/sys/bus/pci/slots/control
/sys/bus/pci/slots/control/remove_slot
/sys/bus/pci/slots/control/add_slot
/sys/bus/pci/slots/0001:00:02.0
/sys/bus/pci/slots/0001:00:02.0/phy_location
Ugh. Almost two years ago,
On Tuesday 13 November 2007 02:30:49 pm Greg KH wrote:
On Tue, Nov 13, 2007 at 01:36:45PM -0700, Alex Chiang wrote:
* Greg KH [EMAIL PROTECTED]:
IBM sells a program that does this for server rooms. It's
probably part of some Tivoli package somewhere, sorry I don't
remember the name.
On Tue, Nov 13, 2007 at 03:01:01PM -0700, Bjorn Helgaas wrote:
On Tuesday 13 November 2007 02:30:49 pm Greg KH wrote:
On Tue, Nov 13, 2007 at 01:36:45PM -0700, Alex Chiang wrote:
* Greg KH [EMAIL PROTECTED]:
IBM sells a program that does this for server rooms. It's
probably part of
Short answer: yes
Longer answer: yes, but I've been swamped, and will happily consider patches
Tim
On Nov 13, 2007 1:55 PM, Jung-Ik (John) Lee [EMAIL PROTECTED] wrote:
-- Forwarded message --
From: Tomas Carnecky [EMAIL PROTECTED]
Date: Nov 11, 2007 6:14 AM
Subject: acpid
Greg KH wrote:
Doesn't /sys/firmware/acpi give you raw access to the correct tables
already?
And isn't there some other tool that dumps the raw ACPI tables? I
thought the acpi developers used it all the time when debugging things
with users.
I'm neither an acpi developer (well I don't think
On Tue, Nov 13, 2007 at 02:51:13PM -0800, Rick Jones wrote:
Greg KH wrote:
Doesn't /sys/firmware/acpi give you raw access to the correct tables
already?
And isn't there some other tool that dumps the raw ACPI tables? I
thought the acpi developers used it all the time when debugging things
On Tue, 13 Nov 2007 12:26:32 -0800
Greg KH [EMAIL PROTECTED] wrote:
On Tue, Nov 13, 2007 at 01:21:54PM -0700, Alex Chiang wrote:
* Greg KH [EMAIL PROTECTED]:
On Mon, Nov 12, 2007 at 05:08:53PM -0700, Alex Chiang wrote:
Recently, Matthew Wilcox sent out the following mail about
On Tue, Nov 13, 2007 at 02:56:05PM -0800, Greg KH wrote:
Why not just use the code in the linux firmware kit that does this
already today from userspace (thanks to Kristen for pointing this out to
me on irc.)?
So then we have something that works on ACPI-based machines. Who will
add support
On Tue, Nov 13, 2007 at 04:04:00PM -0700, Matthew Wilcox wrote:
On Tue, Nov 13, 2007 at 02:56:05PM -0800, Greg KH wrote:
Why not just use the code in the linux firmware kit that does this
already today from userspace (thanks to Kristen for pointing this out to
me on irc.)?
So then we
On Tue, Nov 13, 2007 at 01:11:02PM -0700, Matthew Wilcox wrote:
On Tue, Nov 13, 2007 at 10:51:22AM -0800, Greg KH wrote:
Ok, again, I want to see the IBM people sign off on this, after testing
on all of their machines, before I'll consider this, as I know the IBM
acpi tables are odd.
Hi Greg,
* Greg KH [EMAIL PROTECTED]:
On Tue, Nov 13, 2007 at 02:31:08PM -0700, Alex Chiang wrote:
FWIW, the ACPI 2.0 spec did not require uniqueness for _SUN.
(although there is a strange table that refers to _SUN as the
slot-unique ID (table 6-1 in spec v2.0b), the actual definition
On Tue, Nov 13, 2007 at 03:33:14PM -0800, Kristen Carlson Accardi wrote:
As far as being able to retrieve the slot number (which it seemed from
the HP manageablity application perspective is the goal here), that
information is available from userspace as well for at least standard PCI
and pcie
Fix presentation of the slot number in the /sys/bus/pci/slots
directory to match that used in the majority of other drivers.
--
On Tue, Nov 13, 2007 at 02:58:30PM -0700, Matthew Wilcox wrote:
On Tue, Nov 13, 2007 at 03:41:21PM -0600, Linas Vepstas wrote:
/sys/bus/pci/slots
Greg KH [EMAIL PROTECTED] writes:
Also, some companies already provide userspace tools to get all of this
information about the different slots in a system and what is where,
from userspace, no kernel changes are needed. So, why add all this
extra complexity to the kernel if it is not
Hi Gary,
* Gary Hade [EMAIL PROTECTED]:
On Tue, Nov 13, 2007 at 01:11:02PM -0700, Matthew Wilcox wrote:
On Tue, Nov 13, 2007 at 10:51:22AM -0800, Greg KH wrote:
Ok, again, I want to see the IBM people sign off on this, after testing
on all of their machines, before I'll consider this, as
On Tue, 13 Nov 2007, Carlos Corbacho wrote:
I'm considering writing a sysfs interface for the EC registers, and was
wondering if you would be ok with such a patch (before I start work on it)?
I have exactly such a beast in thinkpad-acpi (using /proc, though),
inherited from ibm-acpi who has
On Tue, Nov 13, 2007 at 06:34:55PM -0600, Linas Vepstas wrote:
Fix presentation of the slot number in the /sys/bus/pci/slots
directory to match that used in the majority of other drivers.
We need a signed-off-by: to be able to apply this...
thanks,
greg k-h
-
To unsubscribe from this
On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote:
Hi Len, Rui,
Here is a group of cleanups and patches to the acpi video driver.
Originally I just wanted to fix sysfs placement of input devices
created by the driver, but then I saw some more potential issues.
The patches are
On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote:
ACPI: video - add missing input_free_device()
If input_register_device() fails input_free_device() must
be called to release memory allocated for the device.
Also consolidate error handling in acpi_bus_video_add()
and handle
On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote:
ACPI: video - convert semaphore to a mutex
Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED]
Acked-by: Zhang Rui [EMAIL PROTECTED]
---
drivers/acpi/video.c | 21 +++--
1 file changed, 11 insertions(+), 10
On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote:
ACPI: video - more cleanups
Remove unneeded checks and initializations, implement proper
unwinding after errors in initialization code, get rid of
unneeded casts, adjust formatting.
A big patch with a large number of minor
On Tue, 2007-11-06 at 00:43 +0800, Dmitry Torokhov wrote:
ACPI: video - fix permissions on some proc entries
POST and DOS are supposed to be writable but permissions
did not allow it.
The same reason as patch 6. :)
Signed-off-by: Dmitry Torokhov [EMAIL PROTECTED]
---
drivers/acpi/video.c
On Tue, 13 Nov 2007, Greg KH wrote:
On Tue, Nov 13, 2007 at 04:04:00PM -0700, Matthew Wilcox wrote:
On Tue, Nov 13, 2007 at 02:56:05PM -0800, Greg KH wrote:
Why not just use the code in the linux firmware kit that does this
already today from userspace (thanks to Kristen for pointing
53 matches
Mail list logo
