Re: Lenovo ThinkPads need acpi_osi="Linux"

2008-01-12 Thread Alan Cox
> Now, what should we do about it? Add a quirk to always define the Linux OSI > string on ThinkPads (based on DMI information)? All IBM ones (which won't > have BIOS revisions anymore, anyway) deal well with it, and Lenovo ones > seem to benefit from it. If Lenovo systems do the right thing then

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-11-01 Thread Alan Cox
> + max_devices = ata_link_max_devices(&ap->link); > + > + for (i = 0; i < max_devices; ++i) { > + struct ata_device *dev = &ap->link.device[i]; Better to use: ata_link_for_each_dev(dev, &ap->link) { > + > + if (dev->acpi_handle) > +

Re: [git patches] libata update

2007-10-14 Thread Alan Cox
> ACPI Exception (exoparg2-0442): AE_AML_PACKAGE_LIMIT, Index > (0) is beyond end of object [20070126] > ACPI Error (psparse-0537): Method parse/execution failed > [\_SB_.PCI0.IDE0.GTM_] (Node 810100318a20), AE_AML_PACKAGE_LIMIT > ACPI Error (psparse-0537): Method parse/execution failed

Re: Documentation - How to debug ACPI Problems

2007-08-14 Thread Alan Cox
On Tue, 14 Aug 2007 11:40:01 -0400 Len Brown <[EMAIL PROTECTED]> wrote: > > > +Thomas Renninger <[EMAIL PROTECTED]>, 2007 > > +Copyright (C) 2007 SUSE Linux GmbH > > While it seems to be generally customary to identify the authors of > Documentation > files, it doesn't seem to be customary for

Re: [PATCH] [22/2many] MAINTAINERS - ACPI

2007-08-13 Thread Alan Cox
On Sun, 12 Aug 2007 23:22:05 -0700 [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1162fb7..93a100b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -251,6 +251,9 @@ L:

Re: [2.6 patch] the scheduled ACPI_PROCFS removal

2007-07-09 Thread Alan Cox
On Mon, 9 Jul 2007 20:46:20 +0200 (CEST) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Jul 9 2007 17:45, Alan Cox wrote: > > > >> This patch contains the scheduled removal of the ACPI procfs interface. > > > >What part of "we do not gratuitously br

Re: [2.6 patch] the scheduled ACPI_PROCFS removal

2007-07-09 Thread Alan Cox
On Mon, 9 Jul 2007 16:57:56 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch contains the scheduled removal of the ACPI procfs interface. NAK What part of "we do not gratuitously break user space interfaces" is so hard for people to understand. - To unsubscribe from this list: send the

Re: [PATCHSET] libata: improve ATA ACPI support, take#3

2007-05-14 Thread Alan Cox
On Tue, 15 May 2007 03:28:15 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, > > This is the third take of improve-ata-acpi. Except for regeneration > to fit the current libata-dev#upstream[U], there's no change from > the last take[L]. Looks good to me within the constraints of the actual

Re: [PATCHSET] libata: improve ATA ACPI support

2007-04-22 Thread Alan Cox
> * after successfully executing _GTF taskfiles, IDENTIFY page is > reloaded Interesting question we should sort out: What is our identify page as supplied to the user meant to be ? The old IDE one started off as the "identify data at boot" (which is useful) and mutated through a million "kind

Re: [PATCH 07/13] libata-acpi: add ATA_FLAG_ACPI_SATA port flag

2007-04-22 Thread Alan Cox
> > Take the ACPI handle, go look for _GTF, _SDD etc and believe the > > firmware. Nothing else works. > > Actually, that's dangerous. For example, you must not do _STM/_GTM on > ahci becuase _STM/_GTM access PCI config registers which must not be > accessed in achi modes and some BIOSen supply t

Re: [PATCH 07/13] libata-acpi: add ATA_FLAG_ACPI_SATA port flag

2007-04-22 Thread Alan Cox
> The ACPI interface to use can only be safely determined one way - and > that is to see what methods the BIOS has attached to the device and use > those. > > Take the ACPI handle, go look for _GTF, _SDD etc and believe the > firmware. Nothing else works. Actually its even worse a mess than I tho

Re: [PATCH 07/13] libata-acpi: add ATA_FLAG_ACPI_SATA port flag

2007-04-22 Thread Alan Cox
On Mon, 23 Apr 2007 02:41:06 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Whether a controller needs IDE or SATA ACPI hierarchy is determined by > the programming interface of the controller not by whether the > controller is SATA or PATA NAK I keep trying to point out that this is not true. Th

Re: [PATCH 02/13] libata: separate ATA_EHI_DID_RESET into DID_SOFTRESET and DID_HARDRESET

2007-04-22 Thread Alan Cox
; will be used later to determine whether _SDD is necessary or not. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PRO

Re: [PATCH 01/13] ahci: consolidate common port flags

2007-04-22 Thread Alan Cox
On Mon, 23 Apr 2007 02:41:05 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Consolidate common port flags into AHCI_FLAG_COMMON. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> > Acked-by: Alan Cox <[EMAIL PROTECTED]> - To unsubscribe from this list: send the li

Re: [PATCH] Add _GTM and _STM support to libata

2007-03-26 Thread Alan Cox
On Mon, 26 Mar 2007 22:48:00 +0100 Matthew Garrett <[EMAIL PROTECTED]> wrote: > Ok. How about this? Couple of cleanups, and leaves the possibility for > drivers to pass in their own gtf structure. Looks better, I can work with that for pata_acpi nicely > + acpidata = kzalloc(sizeof(struct

Re: [PATCH] Add _GTM and _STM support to libata

2007-03-26 Thread Alan Cox
> Ok, missed that. How about something like the following? I've changed > some of the interfaces slightly, so the pata_acpi driver would need to > be altered to match. This gets rid of the CABLE_SATA checking in Close but no cigar. The pata_acpi driver needs to be able to pass its own pointer f

Re: [PATCH] Add _GTM and _STM support to libata

2007-03-26 Thread Alan Cox
> should they be attached to the scsi code rather than the ata host code? > Anyway, this fixes suspend/resume on nc6220, which is what I was aiming > for... > > Signed-off-by: Matthew Garrett <[EMAIL PROTECTED]> NAK - there is code to do the _gtm/_stm parts in the -mm tree already used by pata_

Re: [PATCH] Add _GTM and _STM support to libata

2007-03-26 Thread Alan Cox
On Mon, 26 Mar 2007 04:22:23 +0100 Matthew Garrett <[EMAIL PROTECTED]> wrote: > I've ported the drivers/ide code for handling _GTM and _STM to libata. > I'm not utterly convinced that I'm doing the calls in the right place - Please see the various patches I've posted or the -mm tree. I did that

Re: [3/6] 2.6.21-rc3: known regressions

2007-03-13 Thread Alan Cox
> Subject: libata: PATA UDMA/100 configured as UDMA/33 > References : http://lkml.org/lkml/2007/2/20/294 > > http://www.mail-archive.com/linux-ide@vger.kernel.org/msg04115.html > http://bugzilla.kernel.org/show_bug.cgi?id=8133 > http://bugzilla.kernel.org

Re: regarding ACPI support in 2.6.21

2007-03-12 Thread Alan Cox
> It sounds like your tree is out-of-date. Your patch to fix that went in > days ago, applied by Linus directly: Its purposefully not tracking every Linus update so I can build a replicable environment. I missed the list mail it went in tho. > I lean towards disabling it by default in 2.6.21 an

Re: regarding ACPI support in 2.6.21

2007-03-12 Thread Alan Cox
> I think it might be better to give up ACPI support in 2.6.21 and target > 2.6.22. What do you think? I removed it from my tree already so that I can actually use libata and do real work. The "crash every non PCI controller" feature in the current ACPI hacks means PCMCIA and ISAPnP do not work a

Re: [3/6] 2.6.21-rc2: known regressions

2007-03-06 Thread Alan Cox
> Subject: libata: PATA UDMA/100 configured as UDMA/33 > References : http://lkml.org/lkml/2007/2/20/294 > > http://www.mail-archive.com/linux-ide@vger.kernel.org/msg04115.html > Submitter : Fabio Comolli <[EMAIL PROTECTED]> > Handled-By : Tejun Heo <[EMAIL PROTECTED]> > Status

Re: SMP broken on pre-ACPI machine.

2006-10-19 Thread Alan Cox
Ar Iau, 2006-10-19 am 16:11 -0400, ysgrifennodd Dave Jones: > On Thu, Oct 19, 2006 at 03:16:44PM -0400, Dave Jones wrote: > > > Why smp_found_config isn't set in that guys configuration is a mystery to > me, > > as his MPS tables look sane.. > > > > MP Table: > > # APIC ID Version State

Re: patch [0/2]: acpi: add generic removable drive bay support

2006-09-09 Thread Alan Cox
Ar Iau, 2006-09-07 am 16:13 -0700, ysgrifennodd Kristen Carlson Accardi: > the exact same event for either insertion or removal (i.e. the Dell M65 for > example). Same scripts for using these events and udev can be found on the > thinkwiki website: > > http://www.thinkwiki.org/wiki/How_to_hotswap

Re: [OLPC-devel] Re: [RFC][PATCH 1/2] ACPI: Idle Processor PM Improvements

2006-09-01 Thread Alan Cox
Ar Gwe, 2006-09-01 am 23:52 +0200, ysgrifennodd Andi Kleen: > What are these gaping holes? SATA seems to work at least on many > drivers with an out of tree patch (that will hopefully be merged soon) SATA ought to be pretty good now. > And IDE mostly works too except for HPA on thinkpads (which

Re: 2.6.18-rc1-mm1

2006-07-09 Thread Alan Cox
Ar Sul, 2006-07-09 am 05:22 -0700, ysgrifennodd Andrew Morton: > > ata5: PATA max UDMA/133 cmd 0x1F0 ctl 0x3F6 bmdma 0x30B0 irq 14 > > scsi4 : ata_piix > > ata5.00: ATAPI, max UDMA/66 > > ata5.00: configured for UDMA/66 More ATAPI devices getting uppity about mode setting. > John stuff. I suspec

RE: [PATCH] amd76x_pm: C3 powersaving for AMD K7

2006-02-01 Thread Alan Cox
On Mer, 2006-02-01 at 20:35 -0500, Brown, Len wrote: > This endeavor is full of risk, and I would be extremely careful > about enabling features that the BIOS explicitly disabled -- > unless the hardware manufacturer publicly publishes > support for the feature, or the errata that you're working ar