RE: [PATCH 9/10] introduce intel_menlow platform specific driver

2008-01-23 Thread Jan Engelhardt
On Jan 21 2008 19:49, Thomas, Sujith wrote: >>> >>> +MODULE_AUTHOR("Thomas Sujith"); >>> +MODULE_AUTHOR("Zhang Rui"); >> >> I've never seen a driver with two MODULE_AUTHOR statements before. >> Does this actually work? What does modinfo -F author say for your module? > >There is nothing wrong i

[PATCH] ACPI: constify function pointer tables

2008-01-22 Thread Jan Engelhardt
Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> --- drivers/acpi/battery.c |2 +- drivers/acpi/ec.c |2 +- drivers/acpi/processor_perflib.c|2 +- drivers/acpi/processor_thermal.c|2 +- drivers/acpi/processor_throttling.c |2 +- d

Re: libata not working for sis5533

2007-09-12 Thread Jan Engelhardt
On Sep 12 2007 20:49, Patrizio Bassi wrote: >>> Looks more like a platform irq routing issue than an ata issue. >>> >>> Perhaps an x86 or an acpi person can help out with this. >> >> Patrizio, have you tried with the old IDE? (And without suspend at that...) > >yes yes old IDE works ok

Re: libata not working for sis5533

2007-09-12 Thread Jan Engelhardt
On Sep 11 2007 15:46, Andrew Morton wrote: >Patrizio Bassi <[EMAIL PROTECTED]> wrote: >>Jan Engelhardt ha scritto: >>>On Sep 8 2007 11:38, Patrizio Bassi wrote: >>>>Jan Engelhardt wrote: >>>> >>>>> I shall give this a spin too, s

Re: [2.6 patch] the scheduled ACPI_PROCFS removal

2007-07-09 Thread Jan Engelhardt
On Jul 9 2007 17:45, Alan Cox wrote: > >> This patch contains the scheduled removal of the ACPI procfs interface. > >What part of "we do not gratuitously break user space interfaces" is so >hard for people to understand. Generally I am with you on that, but if everyone keeps on using /proc -- and

Re: [announce] Intel announces the PowerTOP utility for Linux

2007-05-14 Thread Jan Engelhardt
On May 12 2007 22:12, Alistair John Strachan wrote: >On Saturday 12 May 2007 00:07:18 Arjan van de Ven wrote: >> What's eating the battery life of my laptop? Why isn't it many more >> hours? Which software component causes the most power to be burned? >> These are important questions without a goo

Re: Fwd: Re: Linux 2.6.22-rc1

2007-05-13 Thread Jan Engelhardt
On May 14 2007 10:55, Mattia Dongili wrote: >On Sun, May 13, 2007 at 11:27:31AM +0200, Jan Engelhardt wrote: >> On May 12 2007 20:20, Linus Torvalds wrote: >> > >> >Ok, the merge window has closed, and 2.6.22-rc1 is out there. >> >> I have hit a randc

Fwd: Re: Linux 2.6.22-rc1

2007-05-13 Thread Jan Engelhardt
Cc'ing acpi & sony ppl. Jan -- -- Forwarded message -- Date: Sun, 13 May 2007 11:20:39 +0200 (MEST) From: Jan Engelhardt <[EMAIL PROTECTED]> To: Linus Torvalds <[EMAIL PROTECTED]> Cc: Linux Kernel Mailing List <[EMAIL PROTECTED]> Subject: Re:

Re: [announce] Intel announces the PowerTOP utility for Linux

2007-05-12 Thread Jan Engelhardt
On May 11 2007 16:07, Arjan van de Ven wrote: > > A typical Linux distribution has many components that wake the processor up > frequently for no good reason. In our testing with PowerTOP, we have seen many > cases where with some simple fixes, the battery life of typical laptops was > increased b

[PATCH 03/36] Use menuconfig objects II - battery

2007-04-30 Thread Jan Engelhardt
Change Kconfig objects from "menu, config" into "menuconfig" so that the user can disable the whole feature without having to enter the menu first. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> --- drivers/battery/Kconfig | 12 ++-- 1 file changed, 6

[PATCH 01/30] Use menuconfig objects - ACPI

2007-04-10 Thread Jan Engelhardt
Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Index: linux-2.6.21-rc5/drivers/acpi/Kconfig === --- linux-

Re: sonypc with Sony Vaio VGN-SZ1VP

2007-01-05 Thread Jan Engelhardt
On Jan 5 2007 13:13, Mattia Dongili wrote: > >> If you are interested by the job, it is all yours. :) > >Let's see if I can come up with something, I have also an ux50 that is >not very happy with current sonypi Feel free to contact me for testing on U3. FnKey is done through sonypi here, if I un

Re: sonypc with Sony Vaio VGN-SZ1VP

2007-01-04 Thread Jan Engelhardt
On Jan 5 2007 00:36, Stelian Pop wrote: >@@ -61,6 +61,7 @@ static struct acpi_driver sony_acpi_driv > > static acpi_handle sony_acpi_handle; > static struct proc_dir_entry *sony_acpi_dir; >+static struct acpi_device *sony_acpi_acpi_device = NULL; acpi_acpi? >@@ -310,7 +315,7 @@ static int sony_

Re: [PATCH] do not compile Sony Vaio extras as a module per default

2006-10-22 Thread Jan Engelhardt
>--- current/drivers/acpi/Kconfig.orig 2006-10-21 10:02:23.0 +0200 >+++ current/drivers/acpi/Kconfig 2006-10-21 10:02:30.0 +0200 >@@ -262,7 +262,6 @@ config ACPI_SONY > tristate "Sony Laptop Extras" > depends on X86 && ACPI > select BACKLIGHT_CLASS_DEVICE >

Re: [PATCH] Cast removal

2006-10-06 Thread Jan Engelhardt
>> -(void) kmem_cache_destroy(cache); >> +kmem_cache_destroy(cache); >> >> I believe that the point of the (void) is to prevent lint from >> squawking, and perhaps some picky ANSI-C compilers. What is the overall >> Linux policy on this? > >IMHO there's another reason to do this which is

Re: [PATCH] Cast removal

2006-10-05 Thread Jan Engelhardt
>> I find this one interesting, as we've put a number of them into the >> ACPICA core: >> >> -(void) kmem_cache_destroy(cache); >> +kmem_cache_destroy(cache); >> >> I believe that the point of the (void) is to prevent lint from >> squawking, and perhaps some picky ANSI-C compilers. What

Re: [PATCH] Cast removal

2006-10-05 Thread Jan Engelhardt
>> > > I'm okay applying this patch it touches the linux-specific >> > > drivers/acpi/* files only, no ACPICA files. >> > >> > Why? >> >> Why am I okay with it? > >No, I meant why not clean up ACPICA too? I was about to go through the whole kernel base for anti-casting. Sounds like a big task,

[PATCH] Cast removal

2006-09-30 Thread Jan Engelhardt
and probably by someone else. -- Remove unnecessary from/to-void* and to-void casts in drivers/acpi/. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Index: linux-2.6.18/drivers/acpi/ac.c === --- linux-2.6.18.orig/drivers/

Re: [PATCH 2.6.18-mm2] acpi: add backlight support to the sony_acpi driver

2006-09-30 Thread Jan Engelhardt
to be updated then. (Or maybe not if it does not use /proc) Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: sonypc with Sony Vaio VGN-SZ1VP

2006-09-26 Thread Jan Engelhardt
>> Will sony_acpi ever make it to the mainline? Its very useful for new Vaio >> models. > >I'm inclined to slip it in, but Len has good-sounding reasons for not >merging this sort of driver, and I always forget what they are? http://lkml.org/lkml/2006/1/5/57

Re: x60 - spontaneous thermal shutdown

2006-09-04 Thread Jan Engelhardt
n working at the time of shutdown, and machine was able to >boot immediately afterwards. That means that 128 celsius was sensor >error. If it was near 128 C for some time, the plastic case the mainboard is housed in would have been extremely hot and one would have probably burned his fin

Re: Sony ACPI extras mainline inclusion

2006-08-02 Thread Jan Engelhardt
ced anymore to patch >> the kernel by hand or to use the -mm patchset. >> Is there something that prevents this to happen? > >Wrong interface? > >Convert it to use /sys/class/backlight sysfs interface... FWIW, the patch works without having to apply all of -mm. Jan Engel

Re: [discuss] [RFC] make PC Speaker driver work on x86-64

2006-05-01 Thread Jan Engelhardt
>> Is there a better way to do this? ACPI? > >Maybe. ACPI folks, any opinion? > >-Andi (known to rip out the speaker cables in new machines) > Leave the cables, try this for ttyX: diff --fast -Ndpru linux-2.6.16-rc1-git3-SUSE20060124/drivers/char/vt.c linux-2.6-AS24/drivers/char/vt.c --- linux

Re: Suspend to disk (some PATCH)

2006-04-15 Thread Jan Engelhardt
>> > >> pnp: Device 00:08 does not supported activation. >> > >> pnp: Device 00:09 does not supported activation. >> > >> > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> >> >> ACK, but I guess you need to add an chang

Re: Suspend to disk (some PATCH)

2006-04-14 Thread Jan Engelhardt
>> >> pnp: Device 00:08 does not supported activation. >> pnp: Device 00:09 does not supported activation. Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> diff --fast -Ndpru linux-2.6.17-rc1~/drivers/pnp/manager.c linux-2.6.17-rc1-csc/drivers/pnp/manager.c --- linux

Re: [PATCH, RFC] [1/3] Generic in-kernel AC status

2006-02-12 Thread Jan Engelhardt
tell them from userspace. > >No, because battery will explode if you do not slow cpu down fast >enough. How is that? APC UPS don't explode either if they are switching to battery. Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-acpi&quo

Re: [PATCH] Add generic backlight support to toshiba_acpi driver

2006-02-09 Thread Jan Engelhardt
y with it - the /sys/class/backlight stuff is in mainstream) > Well, I am not. At least not-yet-officially. But since I happen to have that hardware, I use it. (And I even have to postpatch the SUSE KOTD ATM to get there, heh, heh.) Jan Engelhardt -- - To unsubscribe from this list: send th

Re: [PATCH] Add generic backlight support to toshiba_acpi driver

2006-02-09 Thread Jan Engelhardt
Is it worth me converting the other drivers over? > >Not sure if I'm ACPI folk but yes, consistent interface would be nice. > Note to self: Don't forget to change 2.6-sony-acpi?.diff from -mm to use this /sys/class/backlight instead of /proc/acpi/sony/brightness when it's ready