[PATCH] Fix segfault when printing battery status

2007-11-19 Thread Rolf Eike Beer
::power_supply_show_property(). I had a situation where the value was 4096 which caused a problem as the array only has 5 entries. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 192c244..2e8e790 100644 --- a/drivers/acpi/battery.c +++ b

Re: [PATCH] Fix segfault when printing battery status

2007-11-19 Thread Rolf Eike Beer
Alexey Starikovskiy wrote: Rolf Eike Beer wrote: cat /sys/devices/LNXSYSTM:00/device:00/PNP0A08:00/device:19/PNP0C0A:00/power_ supply/BAT1/status This leads to a stacktrace as acpi_battery_get_property() returns 0 for a case where it does not set val-intval. These value is used

Re: [Pcihpd-discuss] [PATCH 2/5] Construct one fakephp slot per pci slot

2007-11-14 Thread Rolf Eike Beer
Alex Chiang wrote: Register one slot per slot, rather than one slot per function. Change the name of the slot to fake%d instead of the pci address. Signed-off-by: Alex Chiang [EMAIL PROTECTED] Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] --- drivers/pci/hotplug/fakephp.c | 75

Re: [Pcihpd-discuss] [PATCH 2/5] Construct one fakephp slot per pci slot

2007-11-14 Thread Rolf Eike Beer
Am Mittwoch, 14. November 2007 schrieb Alex Chiang: Hi Eike, * Rolf Eike Beer [EMAIL PROTECTED]: Alex Chiang wrote: --- a/drivers/pci/hotplug/fakephp.c +++ b/drivers/pci/hotplug/fakephp.c @@ -93,6 +93,7 @@ static int add_slot(struct pci_dev *dev) struct dummy_slot *dslot

[2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Rolf Eike Beer
Hi, this happened while I removed my battery on bootup. Complete dmesg is attached. Kernel is 2.6.24-rc1-git of yesterday (last commit was d919fd433b5823d1cf9d0688eb2eec183de9b74c). Greetings, Eike BUG: unable to handle kernel NULL pointer dereference at virtual address 001c printing

Re: [2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Rolf Eike Beer
Rolf Eike Beer wrote: Hi, this happened while I removed my battery on bootup. Complete dmesg is attached. Kernel is 2.6.24-rc1-git of yesterday (last commit was d919fd433b5823d1cf9d0688eb2eec183de9b74c). Ok, I found out that it has nothing to do with the actual removal as it seems. When I

Re: [2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Rolf Eike Beer
Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Rolf Eike Beer wrote: Hi, this happened while I removed my battery on bootup. Complete dmesg is attached. Kernel is 2.6.24-rc1-git of yesterday (last commit was d919fd433b5823d1cf9d0688eb2eec183de9b74c). Ok, I found out that it has

Re: [2.6.24-rc1][BUG] Oops on battery removal

2007-11-02 Thread Rolf Eike Beer
Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Alexey Starikovskiy wrote: Rolf Eike Beer wrote: Rolf Eike Beer wrote: Hi, this happened while I removed my battery on bootup. Complete dmesg is attached. Kernel is 2.6.24-rc1-git

Re: Add INPUT support to toshiba_acpi

2007-07-02 Thread Rolf Eike Beer
Renato S. Yamane wrote: Rolf Eike Beer wrote: Richard Hughes wrote: Yes, although this is out of my area or expertise, sorry. I've looked a bit but can't find any driver interaction of those programs. Any further ideas welcome. Do you try omnibook driver? svn export https

Re: Add INPUT support to toshiba_acpi

2007-06-28 Thread Rolf Eike Beer
Richard Hughes wrote: On Tue, 2007-06-26 at 07:03 +0200, Rolf Eike Beer wrote: Richard Hughes wrote: On Sat, 2007-06-23 at 16:56 +0200, Rolf Eike Beer wrote: None of the above keys generated a key event. Neither does Brightness down, but it still works. Brightness up generates an event

Re: Add INPUT support to toshiba_acpi

2007-06-26 Thread Rolf Eike Beer
Richard Hughes wrote: On Sat, 2007-06-23 at 16:56 +0200, Rolf Eike Beer wrote: None of the above keys generated a key event. Neither does Brightness down, but it still works. Brightness up generates an event and works. Kpowersave tells me it can't do brightness switching in software (which

Re: Add INPUT support to toshiba_acpi

2007-06-25 Thread Rolf Eike Beer
Richard Hughes wrote: Attached patch adds a kernel thread to do polling on Toshiba hardware. Is there something similar available to support other Toshiba laptops? I own a A110-178 that is not supported by the driver but has a lot of keys that I can't use currently: Fn: -screen zoom (I

[BUG] Oops on boot (probably ACPI related)

2006-09-27 Thread Rolf Eike Beer
I get this on my machine. SMP kernel, linus git from this morning. .config and test available on request. Eike BUG: unable to handle kernel paging request at virtual address f0003504 printing eip: c102d804 *pde = Oops: [#1] SMP Modules linked in: CPU:0 EIP:0060:[c102d804]

Re: [Pcihpd-discuss] [PATCH 2/7] acpiphp - remove init_slots()

2006-01-20 Thread Rolf Eike Beer
MUNEDA Takahiro wrote: + slot = kmalloc(sizeof(struct slot), GFP_KERNEL); + if (!slot) + goto error; + memset(slot, 0, sizeof(struct slot)); Use kzalloc() instead of kmalloc() and memset(). Use sizeof(*slot). Eike pgpzqVvMqsrrv.pgp Description: PGP signature