Re: [PATCH] [-mm] ACPI: use GFP_KERNEL instead of GFP_ATOMIC

2007-08-16 Thread Mattia Dongili
On Thu, Aug 16, 2007 at 12:06:18PM +0800, Zhang Rui wrote: > On Thu, 2007-08-16 at 11:36 +0800, Len Brown wrote: > > On Tuesday 31 July 2007 19:00, Zhang Rui wrote: > > > Use GFP_KERNEL instead of GFP_ATOMIC. > > > > > > GFP_ATOMIC is still needed by the sonypi and sony-laptop driver. > > > > Why?

Re: [PATCH] [-mm] ACPI: use GFP_KERNEL instead of GFP_ATOMIC

2007-08-15 Thread Zhang Rui
On Thu, 2007-08-16 at 11:36 +0800, Len Brown wrote: > On Tuesday 31 July 2007 19:00, Zhang Rui wrote: > > Use GFP_KERNEL instead of GFP_ATOMIC. > > > > GFP_ATOMIC is still needed by the sonypi and sony-laptop driver. > > Why? > Sony can't events from user-context like everybody else does? Mattia h

Re: [PATCH] [-mm] ACPI: use GFP_KERNEL instead of GFP_ATOMIC

2007-08-15 Thread Len Brown
On Tuesday 31 July 2007 19:00, Zhang Rui wrote: > Use GFP_KERNEL instead of GFP_ATOMIC. > > GFP_ATOMIC is still needed by the sonypi and sony-laptop driver. Why? Sony can't events from user-context like everybody else does? I don't like adding this extra param to every caller. I'm looking forwa

Re: [PATCH] [-mm] ACPI: use GFP_KERNEL instead of GFP_ATOMIC

2007-07-31 Thread Rafael J. Wysocki
On Wednesday, 1 August 2007 01:00, Zhang Rui wrote: > Use GFP_KERNEL instead of GFP_ATOMIC. Hmm, if any of these things can happen during a suspend, GFP_NOFS would be safer (or even GFP_NOIO). Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscrib

[PATCH] [-mm] ACPI: use GFP_KERNEL instead of GFP_ATOMIC

2007-07-31 Thread Zhang Rui
Use GFP_KERNEL instead of GFP_ATOMIC. GFP_ATOMIC is still needed by the sonypi and sony-laptop driver. Signed-off-by: Zhang Rui <[EMAIL PROTECTED]> --- drivers/acpi/ac.c |3 ++- drivers/acpi/asus_acpi.c |2 +- drivers/acpi/battery.c|3 ++- drivers