Re: [PATCH] sony-laptop: allow complex per-value input/output validation

2007-02-13 Thread Henrique de Moraes Holschuh
On Tue, 13 Feb 2007, Mattia Dongili wrote: > On Tue, Feb 13, 2007 at 10:16:59AM -0200, Henrique de Moraes Holschuh wrote: > > On Tue, 13 Feb 2007, Mattia Dongili wrote: > > > well this is actually hardware driven, the brightness_default in > > > sony-laptop only exposes a DSDT method to set this va

Re: [PATCH] sony-laptop: allow complex per-value input/output validation

2007-02-13 Thread Mattia Dongili
On Tue, Feb 13, 2007 at 10:16:59AM -0200, Henrique de Moraes Holschuh wrote: > On Tue, 13 Feb 2007, Mattia Dongili wrote: > > well this is actually hardware driven, the brightness_default in > > sony-laptop only exposes a DSDT method to set this value. > > So it's actually one more feature, not a s

Re: [PATCH] sony-laptop: allow complex per-value input/output validation

2007-02-13 Thread Henrique de Moraes Holschuh
On Tue, 13 Feb 2007, Mattia Dongili wrote: > well this is actually hardware driven, the brightness_default in > sony-laptop only exposes a DSDT method to set this value. > So it's actually one more feature, not a software trick :) > I admit the attribute could be better named 'poweron_brightness'.

Re: [PATCH] sony-laptop: allow complex per-value input/output validation

2007-02-13 Thread Mattia Dongili
On Tue, February 13, 2007 9:59 am, Richard Purdie said: > On Tue, 2007-02-13 at 09:47 +0100, Mattia Dongili wrote: >> On Tue, February 13, 2007 5:55 am, Len Brown said: >> > On Monday 12 February 2007 16:01, Mattia Dongili wrote: >> >> allows consistency between the sony-laptop >> >> specific 'brig

Re: [PATCH] sony-laptop: allow complex per-value input/output validation

2007-02-13 Thread Richard Purdie
On Tue, 2007-02-13 at 09:47 +0100, Mattia Dongili wrote: > On Tue, February 13, 2007 5:55 am, Len Brown said: > > On Monday 12 February 2007 16:01, Mattia Dongili wrote: > >> allows consistency between the sony-laptop > >> specific 'brightness_default' and the backlight subsystem 0-based > >> 'brig

Re: [PATCH] sony-laptop: allow complex per-value input/output validation

2007-02-13 Thread Mattia Dongili
On Tue, February 13, 2007 5:55 am, Len Brown said: > On Monday 12 February 2007 16:01, Mattia Dongili wrote: >> allows consistency between the sony-laptop >> specific 'brightness_default' and the backlight subsystem 0-based >> 'brightness'. > > Why do we need to have "sony-laptop specific 'brightne

Re: [PATCH] sony-laptop: allow complex per-value input/output validation

2007-02-12 Thread Len Brown
On Monday 12 February 2007 16:01, Mattia Dongili wrote: > allows consistency between the sony-laptop > specific 'brightness_default' and the backlight subsystem 0-based > 'brightness'. Why do we need to have "sony-laptop specific 'brightness_default'" -- is that a shortcoming of the backlight subs

[PATCH] sony-laptop: allow complex per-value input/output validation

2007-02-12 Thread Mattia Dongili
From: Mattia Dongili <[EMAIL PROTECTED]> Replace sony_acpi_value.{min,max} with a callback function that allows more complex reasoning in accepting input and presenting output. Signed-off-by: Mattia Dongili <[EMAIL PROTECTED]> --- Len, this patch specifically allows consistency between the sony-