Re: [PATCH] swsusp: Use platform mode by default

2007-10-17 Thread Rafael J. Wysocki
On Wednesday, 17 October 2007 05:44, Qi Yong wrote: On Wed, Oct 17, 2007 at 10:46:12AM +0800, Qi Yong wrote: On 12/05/2007, Linus Torvalds [EMAIL PROTECTED] wrote: On Fri, 11 May 2007, Rafael J. Wysocki wrote: [--snip--] please apply. Signed-off-by: Qi Yong [EMAIL PROTECTED] --- With

Re: [PATCH] swsusp: Use platform mode by default

2007-10-16 Thread Qi Yong
On 14/05/2007, Stefan Seyfried [EMAIL PROTECTED] wrote: On Fri, May 11, 2007 at 03:51:38PM -0700, Linus Torvalds wrote: On Fri, 11 May 2007, Rafael J. Wysocki wrote: Just to clarify, the change in question isn't new. It was introduced by the commit

Re: [PATCH] swsusp: Use platform mode by default

2007-10-16 Thread Qi Yong
On 12/05/2007, Linus Torvalds [EMAIL PROTECTED] wrote: On Fri, 11 May 2007, Rafael J. Wysocki wrote: We're working on fixing the breakage, but currently it's difficult, because none of my testboxes has problems with the 'platform' hibernation and I cannot reproduce the reported issues.

Re: [PATCH] swsusp: Use platform mode by default

2007-10-16 Thread Linus Torvalds
On Wed, 17 Oct 2007, Qi Yong wrote: The key point is fall back to shutdown _only_ if !ops, otherwise don't touch hibernation_mode. And that solves my problem. Please, when resurrecting a five-month-old discussion, give more of the old context. I don't know about anybody else, but I get

Re: [PATCH] swsusp: Use platform mode by default

2007-10-16 Thread Qi Yong
On Wed, Oct 17, 2007 at 10:46:12AM +0800, Qi Yong wrote: On 12/05/2007, Linus Torvalds [EMAIL PROTECTED] wrote: On Fri, 11 May 2007, Rafael J. Wysocki wrote: We're working on fixing the breakage, but currently it's difficult, because none of my testboxes has problems with the

Re: [PATCH] swsusp: Use platform mode by default

2007-05-14 Thread Stefan Seyfried
On Fri, May 11, 2007 at 03:51:38PM -0700, Linus Torvalds wrote: On Fri, 11 May 2007, Rafael J. Wysocki wrote: Just to clarify, the change in question isn't new. It was introduced by the commit 9185cfa92507d07ac787bc73d06c4eec7239 before 2.6.20, at Seife's request and with

Re: [PATCH] swsusp: Use platform mode by default

2007-05-13 Thread Bill Davidsen
Rafael J. Wysocki wrote: On Friday, 11 May 2007 18:30, Linus Torvalds wrote: On Fri, 11 May 2007, Rafael J. Wysocki wrote: We're working on fixing the breakage, but currently it's difficult, because none of my testboxes has problems with the 'platform' hibernation and I cannot reproduce the

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Coywolf Qi Hunt
Hello, (This patch is merged in 2.6.20 as commit 9185cfa92507d07ac787bc73d06c4eec7239) With this patch, my desktop no longer powers off after hibernate(8). It just reboots. This user land fix can restore the old behavior: echo shutdown /sys/power/disk The commit causes user land

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Rafael J. Wysocki
On Friday, 11 May 2007 10:36, Coywolf Qi Hunt wrote: Hello, (This patch is merged in 2.6.20 as commit 9185cfa92507d07ac787bc73d06c4eec7239) With this patch, my desktop no longer powers off after hibernate(8). It just reboots. This user land fix can restore the old behavior: echo

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Linus Torvalds
On Fri, 11 May 2007, Rafael J. Wysocki wrote: We're working on fixing the breakage, but currently it's difficult, because none of my testboxes has problems with the 'platform' hibernation and I cannot reproduce the reported issues. The rule for anything ACPI-related has been: no

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Rafael J. Wysocki
On Friday, 11 May 2007 18:30, Linus Torvalds wrote: On Fri, 11 May 2007, Rafael J. Wysocki wrote: We're working on fixing the breakage, but currently it's difficult, because none of my testboxes has problems with the 'platform' hibernation and I cannot reproduce the reported issues.

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Linus Torvalds
On Fri, 11 May 2007, Rafael J. Wysocki wrote: Just to clarify, the change in question isn't new. It was introduced by the commit 9185cfa92507d07ac787bc73d06c4eec7239 before 2.6.20, at Seife's request and with Pavel's acceptance. Ok, if it's that old, we migt as leave it in. Clearly

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Pavel Machek
Hi! Just to clarify, the change in question isn't new. It was introduced by the commit 9185cfa92507d07ac787bc73d06c4eec7239 before 2.6.20, at Seife's request and with Pavel's acceptance. Ok, if it's that old, we migt as leave it in. Clearly there weren't many regressions, and this

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Len Brown
I agree that we should keep the platform default, as it went in 2 releases ago (nearly 6 months) without any reported failures until this one -- and it fixed a longstanding issue documented on many machines. We should debug Qi's failure like any other. We are actually in better shape on this one

[PATCH] swsusp: Use platform mode by default

2006-11-01 Thread Rafael J. Wysocki
It has been reported that on some systems the functionality after a resume from disk is limited if the system is simply powered off during the suspend instead of using the ACPI S4 suspend (aka platform mode). Unfortunately the default is currently to power off the system during the suspend so the

Re: [PATCH] swsusp: Use platform mode by default

2006-11-01 Thread Pavel Machek
On Wed 2006-11-01 13:23:14, Rafael J. Wysocki wrote: It has been reported that on some systems the functionality after a resume from disk is limited if the system is simply powered off during the suspend instead of using the ACPI S4 suspend (aka platform mode). Unfortunately the default is