Re: [PATCH 053/112] the generic thermal sysfs driver

2008-02-07 Thread Len Brown
> Lindent has several other known issues as far as Linux kernel > is concerned. I.e., it's not a fine tool to use and not review > what it did. agreed. this is a common one -- Lindent wants a ';' between every statement: @@ -32,7 +32,7 @@ #include MODULE_AUTHOR("Zhang Rui") -MODULE_DESCRIP

Re: [PATCH 053/112] the generic thermal sysfs driver

2008-02-07 Thread Randy Dunlap
Len Brown wrote: Thanks for the review, Randy. I've corrected the issues you pointed out, as well as run the doc through ispell and run thermal.c through Lindent. I've left the goto labels where Lindent put them. If there is a Linux style consensus on that issue, perhaps the Linux community can

Re: [PATCH 053/112] the generic thermal sysfs driver

2008-02-07 Thread Len Brown
Thanks for the review, Randy. I've corrected the issues you pointed out, as well as run the doc through ispell and run thermal.c through Lindent. I've left the goto labels where Lindent put them. If there is a Linux style consensus on that issue, perhaps the Linux community can enhance Lindent? (

Re: [PATCH 053/112] the generic thermal sysfs driver

2008-02-07 Thread Matthew Garrett
On Thu, Feb 07, 2008 at 04:38:43PM -0500, Len Brown wrote: > On Thursday 07 February 2008 15:09, Matthew Garrett wrote: > > There's still ongoing discussion about what the interface should look > > like (and I certainly agree that the difference in units between this > > class and hwmon should be

Re: [PATCH 053/112] the generic thermal sysfs driver

2008-02-07 Thread Len Brown
On Thursday 07 February 2008 15:09, Matthew Garrett wrote: > On Thu, Feb 07, 2008 at 04:34:15AM -0500, Len Brown wrote: > > From: Zhang Rui <[EMAIL PROTECTED]> > > > > The Generic Thermal sysfs driver for thermal management. > > There's still ongoing discussion about what the interface should loo

Re: [PATCH 053/112] the generic thermal sysfs driver

2008-02-07 Thread Matthew Garrett
On Thu, Feb 07, 2008 at 04:34:15AM -0500, Len Brown wrote: > From: Zhang Rui <[EMAIL PROTECTED]> > > The Generic Thermal sysfs driver for thermal management. There's still ongoing discussion about what the interface should look like (and I certainly agree that the difference in units between thi

Re: [PATCH 053/112] the generic thermal sysfs driver

2008-02-07 Thread Randy Dunlap
On Thu, 7 Feb 2008 04:34:15 -0500 Len Brown wrote: > From: Zhang Rui <[EMAIL PROTECTED]> > > The Generic Thermal sysfs driver for thermal management. > > Signed-off-by: Zhang Rui <[EMAIL PROTECTED]> > Signed-off-by: Thomas Sujith <[EMAIL PROTECTED]> > Signed-off-by: Len Brown <[EMAIL PROTECTED]

[PATCH 053/112] the generic thermal sysfs driver

2008-02-07 Thread Len Brown
From: Zhang Rui <[EMAIL PROTECTED]> The Generic Thermal sysfs driver for thermal management. Signed-off-by: Zhang Rui <[EMAIL PROTECTED]> Signed-off-by: Thomas Sujith <[EMAIL PROTECTED]> Signed-off-by: Len Brown <[EMAIL PROTECTED]> --- Documentation/thermal/sysfs-api.txt | 246 dri