Re: [PATCH 1/4] ACPI: WMI: Add ACPI-WMI mapping driver

2007-12-26 Thread Matthew Garrett
+acpi_status wmi_install_notify_handler(wmi_notify_handler handler, void *data) +{ + if (!handler) + return AE_BAD_PARAMETER; + + if (!wmi_external_handler) + return AE_ALREADY_ACQUIRED; Are you sure the negation on the second if is correct? I'm also a bit

Re: [PATCH 1/4] ACPI: WMI: Add ACPI-WMI mapping driver

2007-12-26 Thread Matthew Garrett
On Thu, Dec 27, 2007 at 01:09:39AM +, Carlos Corbacho wrote: On Wednesday 26 December 2007 21:17:18 Matthew Garrett wrote: + if (!wmi_external_handler) + return AE_ALREADY_ACQUIRED; I'm not sure (mostly because I don't like dealing with typedefs around pointers,

[PATCH 1/4] ACPI: WMI: Add ACPI-WMI mapping driver

2007-12-18 Thread Carlos Corbacho
The following is an implementation of the Windows Management Instrumentation (WMI) ACPI interface mapper (PNP0C14). What it does: Parses the _WDG method and exports functions to process WMI method calls, data block query/ set commands (both based on GUID) and does basic event handling. How: WMI

[PATCH 1/4] ACPI: WMI: Add ACPI-WMI mapping driver

2007-12-07 Thread Carlos Corbacho
The following is an implementation of the Windows Management Instrumentation (WMI) ACPI interface mapper (PNP0C14). What it does: Parses the _WDG method and exports functions to process WMI method calls, data block query/ set commands (both based on GUID) and does basic event handling. How: WMI